mirror of
https://github.com/vmware-tanzu/velero.git
synced 2026-10-22 06:13:00 +00:00
e2e: run the RetainPV case too, and move the predicate beside the mapping The RetainPV case was left out of the matrix on the assumption that it needed checking first. It did not: it passes. Run on kind with EnableCSI, Ran 1 of 70 Specs in 354 seconds, 1 passed, installing from overlays/sc-reclaim-policy/kind-csi and taking two real CSI snapshots of Kibishii's PVCs. So drop the exclusion rather than add a second row, and the label becomes plain Basic && Snapshot, which selects the plain snapshot case and the retained-PV one. That overlay is the other half of the Kibishii change, and nothing exercised it until now. KibishiiVolumesAreHostPath moves from test/types.go to sit beside installKibishii, since it is the inverse of that function's Kind branch and the two have to agree on what enabling CSI means. Each now points at the other in a comment. There is no import cycle: the kibishii package already dot-imports test, and every call site already dot-imports kibishii. Signed-off-by: krishhna24 <krishhnatupedev@gmail.com>