mirror of
https://github.com/vmware-tanzu/velero.git
synced 2026-04-20 07:40:33 +00:00
* Add default field to BSL CRD Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com> * Add a new flag `--default` under `velero backup-location create` add a new flag `--default` under `velero backup-location create` to specify this new location to be the new default BSL. Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com> * Add a new default field under `velero backup-location get` add a new default field under `velero backup-location get` to indicate which BSL is the default one. Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com> * Add a new sub-command and flag under `velero backup-location` Add a new sub-command called `velero backup-location set` sub-command and a new flag `velero backup-cation set --default` to configure which BSL is the default one. Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com> * Add new flag to get the default backup-location Add a new flag `--default` under `velero backup-location get` to displays the current default BSL. Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com> * Configures default BSL in BSL controller When upgrade the BSL CRDs, none of the BSL has been labeled as default. Sets the BSL default field to true if the BSL name matches to the default BSL setting. Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com> * Configures the default BSL in BSL controller for velero upgrade When upgrade the BSL CRDs, none of the BSL be marked as the default. Sets the BSL `.spec.default: true` if the BSL name matches against the `velero server --default-backup-storage-location`. Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com> * Add unit test to test default BSL behavior Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com> * Update check which one is the default BSL in backup/backup_sync/restore controller Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com> * Add changelog Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com> * Update docs locations.md and upgrade-to-1.6.md Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
209 lines
6.8 KiB
Go
209 lines
6.8 KiB
Go
/*
|
|
Copyright 2020 the Velero contributors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package backuplocation
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"path/filepath"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/pkg/errors"
|
|
"github.com/spf13/cobra"
|
|
"github.com/spf13/pflag"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
|
|
kbclient "sigs.k8s.io/controller-runtime/pkg/client"
|
|
|
|
velerov1api "github.com/vmware-tanzu/velero/pkg/apis/velero/v1"
|
|
"github.com/vmware-tanzu/velero/pkg/client"
|
|
"github.com/vmware-tanzu/velero/pkg/cmd"
|
|
"github.com/vmware-tanzu/velero/pkg/cmd/util/flag"
|
|
"github.com/vmware-tanzu/velero/pkg/cmd/util/output"
|
|
)
|
|
|
|
func NewCreateCommand(f client.Factory, use string) *cobra.Command {
|
|
o := NewCreateOptions()
|
|
|
|
c := &cobra.Command{
|
|
Use: use + " NAME",
|
|
Short: "Create a backup storage location",
|
|
Args: cobra.ExactArgs(1),
|
|
Run: func(c *cobra.Command, args []string) {
|
|
cmd.CheckError(o.Complete(args, f))
|
|
cmd.CheckError(o.Validate(c, args, f))
|
|
cmd.CheckError(o.Run(c, f))
|
|
},
|
|
}
|
|
|
|
o.BindFlags(c.Flags())
|
|
output.BindFlags(c.Flags())
|
|
output.ClearOutputFlagDefault(c)
|
|
|
|
return c
|
|
}
|
|
|
|
type CreateOptions struct {
|
|
Name string
|
|
Provider string
|
|
Bucket string
|
|
DefaultBackupStorageLocation bool
|
|
Prefix string
|
|
BackupSyncPeriod, ValidationFrequency time.Duration
|
|
Config flag.Map
|
|
Labels flag.Map
|
|
CACertFile string
|
|
AccessMode *flag.Enum
|
|
}
|
|
|
|
func NewCreateOptions() *CreateOptions {
|
|
return &CreateOptions{
|
|
Config: flag.NewMap(),
|
|
AccessMode: flag.NewEnum(
|
|
string(velerov1api.BackupStorageLocationAccessModeReadWrite),
|
|
string(velerov1api.BackupStorageLocationAccessModeReadWrite),
|
|
string(velerov1api.BackupStorageLocationAccessModeReadOnly),
|
|
),
|
|
}
|
|
}
|
|
|
|
func (o *CreateOptions) BindFlags(flags *pflag.FlagSet) {
|
|
flags.StringVar(&o.Provider, "provider", o.Provider, "Name of the backup storage provider (e.g. aws, azure, gcp).")
|
|
flags.StringVar(&o.Bucket, "bucket", o.Bucket, "Name of the object storage bucket where backups should be stored.")
|
|
flags.BoolVar(&o.DefaultBackupStorageLocation, "default", o.DefaultBackupStorageLocation, "Sets this new location to be the new default backup storage location. Optional.")
|
|
flags.StringVar(&o.Prefix, "prefix", o.Prefix, "Prefix under which all Velero data should be stored within the bucket. Optional.")
|
|
flags.DurationVar(&o.BackupSyncPeriod, "backup-sync-period", o.BackupSyncPeriod, "How often to ensure all Velero backups in object storage exist as Backup API objects in the cluster. Optional. Set this to `0s` to disable sync. Default: 1 minute.")
|
|
flags.DurationVar(&o.ValidationFrequency, "validation-frequency", o.ValidationFrequency, "How often to verify if the backup storage location is valid. Optional. Set this to `0s` to disable sync. Default 1 minute.")
|
|
flags.Var(&o.Config, "config", "Configuration key-value pairs.")
|
|
flags.Var(&o.Labels, "labels", "Labels to apply to the backup storage location.")
|
|
flags.StringVar(&o.CACertFile, "cacert", o.CACertFile, "File containing a certificate bundle to use when verifying TLS connections to the object store. Optional.")
|
|
flags.Var(
|
|
o.AccessMode,
|
|
"access-mode",
|
|
fmt.Sprintf("Access mode for the backup storage location. Valid values are %s", strings.Join(o.AccessMode.AllowedValues(), ",")),
|
|
)
|
|
}
|
|
|
|
func (o *CreateOptions) Validate(c *cobra.Command, args []string, f client.Factory) error {
|
|
if err := output.ValidateFlags(c); err != nil {
|
|
return err
|
|
}
|
|
|
|
if o.Provider == "" {
|
|
return errors.New("--provider is required")
|
|
}
|
|
|
|
if o.Bucket == "" {
|
|
return errors.New("--bucket is required")
|
|
}
|
|
|
|
if o.BackupSyncPeriod < 0 {
|
|
return errors.New("--backup-sync-period must be non-negative")
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (o *CreateOptions) Complete(args []string, f client.Factory) error {
|
|
o.Name = args[0]
|
|
return nil
|
|
}
|
|
|
|
func (o *CreateOptions) Run(c *cobra.Command, f client.Factory) error {
|
|
var backupSyncPeriod, validationFrequency *metav1.Duration
|
|
|
|
var caCertData []byte
|
|
if o.CACertFile != "" {
|
|
realPath, err := filepath.Abs(o.CACertFile)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
caCertData, err = ioutil.ReadFile(realPath)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
if c.Flags().Changed("backup-sync-period") {
|
|
backupSyncPeriod = &metav1.Duration{Duration: o.BackupSyncPeriod}
|
|
}
|
|
|
|
if c.Flags().Changed("validation-frequency") {
|
|
validationFrequency = &metav1.Duration{Duration: o.ValidationFrequency}
|
|
}
|
|
|
|
backupStorageLocation := &velerov1api.BackupStorageLocation{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: f.Namespace(),
|
|
Name: o.Name,
|
|
Labels: o.Labels.Data(),
|
|
},
|
|
Spec: velerov1api.BackupStorageLocationSpec{
|
|
Provider: o.Provider,
|
|
StorageType: velerov1api.StorageType{
|
|
ObjectStorage: &velerov1api.ObjectStorageLocation{
|
|
Bucket: o.Bucket,
|
|
Prefix: o.Prefix,
|
|
CACert: caCertData,
|
|
},
|
|
},
|
|
Config: o.Config.Data(),
|
|
Default: o.DefaultBackupStorageLocation,
|
|
AccessMode: velerov1api.BackupStorageLocationAccessMode(o.AccessMode.String()),
|
|
BackupSyncPeriod: backupSyncPeriod,
|
|
ValidationFrequency: validationFrequency,
|
|
},
|
|
}
|
|
|
|
if printed, err := output.PrintWithFormat(c, backupStorageLocation); printed || err != nil {
|
|
return err
|
|
}
|
|
|
|
kbClient, err := f.KubebuilderClient()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if o.DefaultBackupStorageLocation {
|
|
// There is one and only one default backup storage location.
|
|
// Disable the origin default backup storage location.
|
|
locations := new(velerov1api.BackupStorageLocationList)
|
|
if err := kbClient.List(context.Background(), locations, &kbclient.ListOptions{Namespace: f.Namespace()}); err != nil {
|
|
return errors.WithStack(err)
|
|
}
|
|
for _, location := range locations.Items {
|
|
if !location.Spec.Default {
|
|
continue
|
|
}
|
|
location.Spec.Default = false
|
|
if err := kbClient.Update(context.Background(), &location, &kbclient.UpdateOptions{}); err != nil {
|
|
return errors.WithStack(err)
|
|
}
|
|
break
|
|
}
|
|
}
|
|
|
|
if err := kbClient.Create(context.Background(), backupStorageLocation, &kbclient.CreateOptions{}); err != nil {
|
|
return errors.WithStack(err)
|
|
}
|
|
|
|
fmt.Printf("Backup storage location %q configured successfully.\n", backupStorageLocation.Name)
|
|
return nil
|
|
}
|