mirror of
https://github.com/vmware-tanzu/velero.git
synced 2026-08-16 04:06:06 +00:00
JosephandClaude Opus 4.6
3c49bbec75
Register cobra completion callbacks for all commands that accept existing Velero resource names. A centralized completeNames helper uses apimachinery's meta.ExtractList/Accessor to list resources with a 3-second timeout, filter by prefix, and deduplicate already-typed arguments. Wires ValidArgsFunction on 20 commands and RegisterFlagCompletionFunc on 9 flags across backup, restore, schedule, backuplocation, snapshotlocation, repo, and debug. Closes #9782 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com>
116 lines
3.1 KiB
Go
116 lines
3.1 KiB
Go
/*
|
|
Copyright The Velero contributors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package snapshotlocation
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"github.com/cockroachdb/errors"
|
|
"github.com/spf13/cobra"
|
|
"github.com/spf13/pflag"
|
|
|
|
kbclient "sigs.k8s.io/controller-runtime/pkg/client"
|
|
|
|
velerov1api "github.com/vmware-tanzu/velero/pkg/apis/velero/v1"
|
|
"github.com/vmware-tanzu/velero/pkg/builder"
|
|
"github.com/vmware-tanzu/velero/pkg/client"
|
|
"github.com/vmware-tanzu/velero/pkg/cmd"
|
|
"github.com/vmware-tanzu/velero/pkg/cmd/cli"
|
|
"github.com/vmware-tanzu/velero/pkg/cmd/util/flag"
|
|
"github.com/vmware-tanzu/velero/pkg/cmd/util/output"
|
|
)
|
|
|
|
func NewSetCommand(f client.Factory, use string) *cobra.Command {
|
|
o := NewSetOptions()
|
|
|
|
c := &cobra.Command{
|
|
Use: use + " NAME",
|
|
Short: "Set specific features for a snapshot location",
|
|
Args: cobra.ExactArgs(1),
|
|
Run: func(c *cobra.Command, args []string) {
|
|
cmd.CheckError(o.Complete(args, f))
|
|
cmd.CheckError(o.Validate(c, args, f))
|
|
cmd.CheckError(o.Run(c, f))
|
|
},
|
|
}
|
|
|
|
c.ValidArgsFunction = cli.CompleteVolumeSnapshotLocationNames(f)
|
|
o.BindFlags(c.Flags())
|
|
return c
|
|
}
|
|
|
|
type SetOptions struct {
|
|
Name string
|
|
Credential flag.Map
|
|
}
|
|
|
|
func NewSetOptions() *SetOptions {
|
|
return &SetOptions{
|
|
Credential: flag.NewMap(),
|
|
}
|
|
}
|
|
|
|
func (o *SetOptions) BindFlags(flags *pflag.FlagSet) {
|
|
flags.Var(&o.Credential, "credential", "Sets the credential to be used by this location as a key-value pair, where the key is the Kubernetes Secret name, and the value is the data key name within the Secret. Optional, one value only.")
|
|
}
|
|
|
|
func (o *SetOptions) Validate(c *cobra.Command, args []string, f client.Factory) error {
|
|
if err := output.ValidateFlags(c); err != nil {
|
|
return err
|
|
}
|
|
|
|
if len(o.Credential.Data()) > 1 {
|
|
return errors.New("--credential can only contain 1 key/value pair")
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (o *SetOptions) Complete(args []string, f client.Factory) error {
|
|
o.Name = args[0]
|
|
return nil
|
|
}
|
|
|
|
func (o *SetOptions) Run(c *cobra.Command, f client.Factory) error {
|
|
kbClient, err := f.KubebuilderClient()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
location := &velerov1api.VolumeSnapshotLocation{}
|
|
err = kbClient.Get(context.Background(), kbclient.ObjectKey{
|
|
Namespace: f.Namespace(),
|
|
Name: o.Name,
|
|
}, location)
|
|
if err != nil {
|
|
return errors.WithStack(err)
|
|
}
|
|
|
|
for name, key := range o.Credential.Data() {
|
|
location.Spec.Credential = builder.ForSecretKeySelector(name, key).Result()
|
|
break
|
|
}
|
|
|
|
if err := kbClient.Update(context.Background(), location, &kbclient.UpdateOptions{}); err != nil {
|
|
return errors.WithStack(err)
|
|
}
|
|
|
|
fmt.Printf("Volume snapshot location %q configured successfully.\n", o.Name)
|
|
return nil
|
|
}
|