mirror of
https://github.com/vmware-tanzu/velero.git
synced 2026-08-01 12:56:04 +00:00
Daniel Jiang
4f9e445142
Fixes #4760 This commit make changes in 2 parts: 1) When a volumesnapshotcontent is persisted during backup, velero will reset its `Source` field to remove the VolumeHandle, so that the csi-snapshotter will not try to call `CreateSnapshot` when its synced to another cluster with a backup. 2) Make sure the referenced volumesnapshotclasses are persisted and synced with the backup, so that when the volumesnapshotcontent is deleted the storage snapshot is also removed. Signed-off-by: Daniel Jiang <jiangd@vmware.com>
43 lines
1.6 KiB
Go
43 lines
1.6 KiB
Go
/*
|
|
Copyright The Velero Contributors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package csi
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
snapshotv1api "github.com/kubernetes-csi/external-snapshotter/client/v4/apis/volumesnapshot/v1"
|
|
corev1 "k8s.io/api/core/v1"
|
|
)
|
|
|
|
// ResetVolumeSnapshotContent make changes to the volumesnapshot content before it's persisted
|
|
// It will move the snapshot Handle to the source to avoid the snapshot-controller creating a snapshot when it's
|
|
// synced by the backup sync controller.
|
|
// It will return an error if the snapshot handle is not set, which should not happen when this func is called.
|
|
func ResetVolumeSnapshotContent(snapCont *snapshotv1api.VolumeSnapshotContent) error {
|
|
if snapCont.Status != nil && snapCont.Status.SnapshotHandle != nil && len(*snapCont.Status.SnapshotHandle) > 0 {
|
|
v := *snapCont.Status.SnapshotHandle
|
|
snapCont.Spec.Source = snapshotv1api.VolumeSnapshotContentSource{
|
|
SnapshotHandle: &v,
|
|
}
|
|
} else {
|
|
return fmt.Errorf("the volumesnapshotcontent '%s' does not have snapshothandle set", snapCont.Name)
|
|
}
|
|
|
|
snapCont.Spec.VolumeSnapshotRef = corev1.ObjectReference{}
|
|
return nil
|
|
}
|