mirror of
https://github.com/vmware-tanzu/velero.git
synced 2026-09-13 11:34:54 +00:00
Shubham PampattiwarandGitHub
1d9391b85e
The changelog check decided whether a PR was exempt using the labels in the triggering event payload (github.event.pull_request.labels). That payload is frozen at event time, so a PR that gets the kind/changelog-not-required label after its first run could not pass by re-running the failed job, and the exemption only took effect if a brand new event happened to fire afterward. Move the exemption logic into hack/changelog-check.sh and query the PR's current labels via the GitHub API instead. Re-runs and labels added after the initial run are now evaluated correctly. The workflow grants pull-requests: read and passes github.token so the script can read labels. The exempt label set (kind/changelog-not-required, Design, Website, Documentation) is unchanged. Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
27 lines
634 B
YAML
27 lines
634 B
YAML
name: Pull Request Changelog Check
|
|
# by setting `on: [pull_request]`, that means action will be trigger when PR is opened, synchronize, reopened.
|
|
# Add labeled and unlabeled events too.
|
|
on:
|
|
pull_request:
|
|
types: [opened, synchronize, reopened, labeled, unlabeled]
|
|
|
|
permissions:
|
|
contents: read
|
|
pull-requests: read
|
|
|
|
jobs:
|
|
|
|
build:
|
|
if: github.repository == 'velero-io/velero'
|
|
name: Run Changelog Check
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
|
|
- name: Check out the code
|
|
uses: actions/checkout@v7
|
|
|
|
- name: Changelog check
|
|
env:
|
|
GH_TOKEN: ${{ github.token }}
|
|
run: ./hack/changelog-check.sh
|