Shubham Pampattiwar 99e821a870 Address review feedback: move cache building to volumehelper ...

- Rename NewVolumeHelperImplWithCache to NewVolumeHelperImplWithNamespaces
- Move cache building logic from backup.go into volumehelper
- Return error from NewVolumeHelperImplWithNamespaces if cache build fails
- Remove fallback in main backup path - backup fails if cache build fails
- Update NewVolumeHelperImpl to call NewVolumeHelperImplWithNamespaces
- Add comments clarifying fallback is only used by plugins
- Update tests for new error return signature

This addresses review comments from @Lyndon-Li and @kaovilai:
- Cache building is now encapsulated in volumehelper
- No fallback in main backup path ensures predictable performance
- Code reuse between constructors

Fixes #9179

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

2025-12-15 14:18:05 -08:00

..

volume_policy_helper_test.go

Address review feedback: move cache building to volumehelper

2025-12-15 14:18:05 -08:00

volume_policy_helper.go

Address review feedback: move cache building to volumehelper

2025-12-15 14:18:05 -08:00