fix: reject empty versionId query parameter in object actions

S3 returns `InvalidArgument` when an object action receives a `versionId` query parameter with no value. The gateway silently treated it as an unversioned request instead.

Added a shared `versionId` validation helper and apply it to the object actions that accept the parameter, so malformed requests are rejected up front rather than reaching the backend.
This commit is contained in:
niksis02
2026-09-10 16:35:05 +04:00
parent be3ec8ba4d
commit 1e0d7b218d
23 changed files with 437 additions and 6 deletions
+14
View File
@@ -962,6 +962,20 @@ func GetQueryParam(ctx fiber.Ctx, key string) *string {
return &value
}
// ValidateVersionId ensures the versionId query parameter, if specified, isn't
// empty. S3 rejects both "?versionId=" and the valueless "?versionId" form, and
// rejects the request if any of the repeated values is empty.
func ValidateVersionId(ctx fiber.Ctx) error {
for _, val := range ctx.Request().URI().QueryArgs().PeekMulti("versionId") {
if len(val) == 0 {
debuglogger.Logf("empty versionId query parameter")
return s3err.GetInvalidArgumentErr(s3err.InvalidArgEmptyVersionId, "")
}
}
return nil
}
// ApplyOverride returns the override value if it exists and status is 200, otherwise returns original
func ApplyOverride(original, override *string) *string {
if override != nil {