From 85b06bf28cf33d17fa1ccab44a93a6a0546822d1 Mon Sep 17 00:00:00 2001 From: Ben McClelland Date: Fri, 25 Oct 2024 16:57:45 -0700 Subject: [PATCH 1/2] fix: azure list multipart uploads test failures The latest azurite made a change where the blob metadata must be explicitly requested when calling NewListBlobsFlatPager(). We were taking action on metadata iteams, and the tests were failing due to these always missing without requesting metadata to be included in the response. Fix is to enable metadata for the response. --- backend/azure/azure.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/backend/azure/azure.go b/backend/azure/azure.go index 465398b..c2eaac5 100644 --- a/backend/azure/azure.go +++ b/backend/azure/azure.go @@ -1036,7 +1036,8 @@ func (az *Azure) ListMultipartUploads(ctx context.Context, input *s3.ListMultipa prefix := string(metaTmpMultipartPrefix) pager := client.NewListBlobsFlatPager(&container.ListBlobsFlatOptions{ - Prefix: &prefix, + Include: container.ListBlobsInclude{Metadata: true}, + Prefix: &prefix, }) for pager.More() { From 565000c3e71d2c2f074fa6288bac3b3091f669b4 Mon Sep 17 00:00:00 2001 From: Ben McClelland Date: Mon, 28 Oct 2024 09:33:50 -0700 Subject: [PATCH 2/2] chore: update example service config for directory perms option This was missed when we added an option for setting directory permissions different than the default 0755. This adds the VGW_DIR_PERMS option and description to the example.conf file. --- extra/example.conf | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/extra/example.conf b/extra/example.conf index 79a5778..67cf9bc 100644 --- a/extra/example.conf +++ b/extra/example.conf @@ -311,6 +311,12 @@ ROOT_SECRET_ACCESS_KEY= # to directories at the top level gateway directory as buckets. #VGW_BUCKET_LINKS=false +# The default permissions mode when creating new directories is 0755. Use +# VGW_DIR_PERMS option to set a different mode for any new directory that the +# gateway creates. This applies to buckets created through the gateway as well +# as any parent directories automatically created with object uploads. +#VGW_DIR_PERMS=0755 + ########### # scoutfs # ########### @@ -346,6 +352,12 @@ ROOT_SECRET_ACCESS_KEY= # to directories at the top level gateway directory as buckets. #VGW_BUCKET_LINKS=false +# The default permissions mode when creating new directories is 0755. Use +# VGW_DIR_PERMS option to set a different mode for any new directory that the +# gateway creates. This applies to buckets created through the gateway as well +# as any parent directories automatically created with object uploads. +#VGW_DIR_PERMS=0755 + ###### # s3 # ######