From 4fa7d38e5628a244d3952a9106a238ce9775cd84 Mon Sep 17 00:00:00 2001 From: Ben McClelland Date: Mon, 16 Feb 2026 14:00:58 -0800 Subject: [PATCH] chore: fix warning in system.yml github workflow The system.yml file was giving this warning: Context access might be invalid: SAFE_RUN_SET The warning occurs because this was trying to access env.SAFE_RUN_SET in a with: key of an action, but GitHub Actions has restrictions on where context variables can be accessed. The env context isn't always guaranteed to be available in the with: key of actions, especially when it depends on runtime values set in previous steps. The recommended fix is to change from $GITHUB_ENV to $GITHUB_OUTPUT for this case. --- .github/workflows/system.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/system.yml b/.github/workflows/system.yml index 9235daac..466ab1f3 100644 --- a/.github/workflows/system.yml +++ b/.github/workflows/system.yml @@ -131,16 +131,17 @@ jobs: fi - name: Ensure coverage file exists, and generate working name + id: prepare_coverage run: | touch coverage.log run_set="${{ matrix.RUN_SET }}" SAFE_RUN_SET="${run_set//\//-}" - echo "SAFE_RUN_SET=$SAFE_RUN_SET" >> $GITHUB_ENV + echo "safe_run_set=$SAFE_RUN_SET" >> $GITHUB_OUTPUT - name: Upload command coverage log uses: actions/upload-artifact@v6 with: - name: coverage-${{ env.SAFE_RUN_SET }}-${{ matrix.RECREATE_BUCKETS }} + name: coverage-${{ steps.prepare_coverage.outputs.safe_run_set }}-${{ matrix.RECREATE_BUCKETS }} path: coverage.log retention-days: 1