mirrors/versitygw
1
0
Fork 0
mirror of https://github.com/versity/versitygw.git synced 2026-09-26 18:04:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: Removed etag from GetObject function

Browse Source
This commit is contained in:
jonaustin09
2023-05-24 08:25:56 -07:00
committed by Ben McClelland
parent b41dfd653c
commit 70f5e0fac9
6 changed files with 13 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
s3api/controllers/backend_moq_test.go
+4 -10
View File
@@ -51,7 +51,7 @@ var _ backend.Backend = &BackendMock{}
// GetIAMConfigFunc: func() ([]byte, error) {
// panic("mock out the GetIAMConfig method")
// },
// GetObjectFunc: func(bucket string, object string, startOffset int64, length int64, writer io.Writer, etag string) (*s3.GetObjectOutput, error) {
// GetObjectFunc: func(bucket string, object string, startOffset int64, length int64, writer io.Writer) (*s3.GetObjectOutput, error) {
// panic("mock out the GetObject method")
// },
// GetObjectAclFunc: func(bucket string, object string) (*s3.GetObjectAclOutput, error) {
@@ -161,7 +161,7 @@ type BackendMock struct {
GetIAMConfigFunc func() ([]byte, error)
// GetObjectFunc mocks the GetObject method.
GetObjectFunc func(bucket string, object string, startOffset int64, length int64, writer io.Writer, etag string) (*s3.GetObjectOutput, error)
GetObjectFunc func(bucket string, object string, startOffset int64, length int64, writer io.Writer) (*s3.GetObjectOutput, error)
// GetObjectAclFunc mocks the GetObjectAcl method.
GetObjectAclFunc func(bucket string, object string) (*s3.GetObjectAclOutput, error)
@@ -320,8 +320,6 @@ type BackendMock struct {
Length int64
// Writer is the writer argument value.
Writer io.Writer
// Etag is the etag argument value.
Etag string
}
// GetObjectAcl holds details about calls to the GetObjectAcl method.
GetObjectAcl []struct {
@@ -897,7 +895,7 @@ func (mock *BackendMock) GetIAMConfigCalls() []struct {
}
// GetObject calls GetObjectFunc.
func (mock *BackendMock) GetObject(bucket string, object string, startOffset int64, length int64, writer io.Writer, etag string) (*s3.GetObjectOutput, error) {
func (mock *BackendMock) GetObject(bucket string, object string, startOffset int64, length int64, writer io.Writer) (*s3.GetObjectOutput, error) {
if mock.GetObjectFunc == nil {
panic("BackendMock.GetObjectFunc: method is nil but Backend.GetObject was just called")
}
@@ -907,19 +905,17 @@ func (mock *BackendMock) GetObject(bucket string, object string, startOffset int
StartOffset int64
Length int64
Writer io.Writer
Etag string
}{
Bucket: bucket,
Object: object,
StartOffset: startOffset,
Length: length,
Writer: writer,
Etag: etag,
}
mock.lockGetObject.Lock()
mock.calls.GetObject = append(mock.calls.GetObject, callInfo)
mock.lockGetObject.Unlock()
return mock.GetObjectFunc(bucket, object, startOffset, length, writer, etag)
return mock.GetObjectFunc(bucket, object, startOffset, length, writer)
}
// GetObjectCalls gets all the calls that were made to GetObject.
@@ -932,7 +928,6 @@ func (mock *BackendMock) GetObjectCalls() []struct {
StartOffset int64
Length int64
Writer io.Writer
Etag string
} {
var calls []struct {
Bucket string
@@ -940,7 +935,6 @@ func (mock *BackendMock) GetObjectCalls() []struct {
StartOffset int64
Length int64
Writer io.Writer
Etag string
}
mock.lockGetObject.RLock()
calls = mock.calls.GetObject
s3api/controllers/base.go
+1 -1
View File
@@ -82,7 +82,7 @@ func (c S3ApiController) GetActions(ctx *fiber.Ctx) error {
return errors.New("wrong api call")
}
res, err := c.be.GetObject(bucket, key, int64(startOffset), int64(length), ctx.Response().BodyWriter(), "")
res, err := c.be.GetObject(bucket, key, int64(startOffset), int64(length), ctx.Response().BodyWriter())
return responce(ctx, res, err)
}
s3api/controllers/base_test.go
+1 -1
View File
@@ -120,7 +120,7 @@ func TestS3ApiController_GetActions(t *testing.T) {
GetObjectAttributesFunc: func(bucket, object string, attributes []string) (*s3.GetObjectAttributesOutput, error) {
return &s3.GetObjectAttributesOutput{}, nil
},
GetObjectFunc: func(bucket, object string, startOffset, length int64, writer io.Writer, etag string) (*s3.GetObjectOutput, error) {
GetObjectFunc: func(bucket, object string, startOffset, length int64, writer io.Writer) (*s3.GetObjectOutput, error) {
return &s3.GetObjectOutput{Metadata: nil}, nil
},
}}