From a4091fd61cff0af6744e784b2b8acfc922fffa5a Mon Sep 17 00:00:00 2001 From: Ben McClelland Date: Mon, 1 Sep 2025 17:29:51 -0700 Subject: [PATCH] fix: previous pr was not rebased before merging and caused a build error There was a change to the auth.VerifyAccess that changed IsPublicBucket to IsPublicRequest, but another PR (GetBucketLocation) that was merged at the same time (and not rebased) was using the old version. Update this to fix the build. --- s3api/controllers/bucket-get.go | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/s3api/controllers/bucket-get.go b/s3api/controllers/bucket-get.go index 5e2ed7a..f504832 100644 --- a/s3api/controllers/bucket-get.go +++ b/s3api/controllers/bucket-get.go @@ -629,14 +629,14 @@ func (c S3ApiController) GetBucketLocation(ctx *fiber.Ctx) (*Response, error) { parsedAcl := utils.ContextKeyParsedAcl.Get(ctx).(auth.ACL) err := auth.VerifyAccess(ctx.Context(), c.be, auth.AccessOptions{ - Readonly: c.readonly, - Acl: parsedAcl, - AclPermission: auth.PermissionRead, - IsRoot: isRoot, - Acc: acct, - Bucket: bucket, - Action: auth.GetBucketLocationAction, - IsBucketPublic: isPublicBucket, + Readonly: c.readonly, + Acl: parsedAcl, + AclPermission: auth.PermissionRead, + IsRoot: isRoot, + Acc: acct, + Bucket: bucket, + Action: auth.GetBucketLocationAction, + IsPublicRequest: isPublicBucket, }) if err != nil { return &Response{