From c3201081ceeee545949c3cdd434849b763c09cb0 Mon Sep 17 00:00:00 2001 From: Ben McClelland Date: Fri, 11 Jul 2025 10:55:39 -0700 Subject: [PATCH] fix: always log internal server error messages to stderr The debuglogger logs will only get printed if debug is enabled, but we always want the internal server error logs to be logged by the service since this is usually some actionable error that needs to be addressed with the backend storage system. This changes internal server error logs to always to sent to stderr. --- s3api/controllers/base.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/s3api/controllers/base.go b/s3api/controllers/base.go index ea829ff4..2b8bb9c5 100644 --- a/s3api/controllers/base.go +++ b/s3api/controllers/base.go @@ -23,6 +23,7 @@ import ( "math" "net/http" "net/url" + "os" "strconv" "strings" "time" @@ -3924,7 +3925,7 @@ func SendResponse(ctx *fiber.Ctx, err error, l *MetaOpts) error { return ctx.Send(s3err.GetAPIErrorResponse(apierr, "", "", "")) } - debuglogger.Logf("Internal Error, %v", err) + fmt.Fprintf(os.Stderr, "Internal Error, %v\n", err) ctx.Status(http.StatusInternalServerError) return ctx.Send(s3err.GetAPIErrorResponse( s3err.GetAPIError(s3err.ErrInternalError), "", "", "")) @@ -3978,7 +3979,7 @@ func SendXMLResponse(ctx *fiber.Ctx, resp any, err error, l *MetaOpts) error { return ctx.Send(s3err.GetAPIErrorResponse(serr, "", "", "")) } - debuglogger.Logf("Internal Error, %v", err) + fmt.Fprintf(os.Stderr, "Internal Error, %v\n", err) ctx.Status(http.StatusInternalServerError) return ctx.Send(s3err.GetAPIErrorResponse(