mirrors/versitygw
1
0
Fork 0
mirror of https://github.com/versity/versitygw.git synced 2026-01-09 04:53:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1053 from versity/ben/fix_ipa_quoting

Browse Source 
Potential fix for code scanning alert no. 15: Potentially unsafe quoting
This commit is contained in:
Ben McClelland
2025-02-03 09:17:19 -08:00
committed by GitHub
parent 888fdd3688 4add647501
commit fd4bb8ffbc
1 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
auth/iam_ipa.go
View File

@@ -354,15 +354,18 @@ func (ipa *IpaIAMService) newRequest(method string, args []string, dict map[stri
return "", fmt.Errorf("ipa request invalid: %w", err) return "", fmt.Errorf("ipa request invalid: %w", err)
} }
return fmt.Sprintf(`{ request := map[string]interface{}{
"id": %d, "id": id,
"method": %s, "method": json.RawMessage(jmethod),
"params": [ "params": []json.RawMessage{json.RawMessage(jargs), json.RawMessage(jdict)},
%s,
%s
]
} }
`, id, jmethod, jargs, jdict), nil
requestJSON, err := json.Marshal(request)
if err != nil {
return "", fmt.Errorf("failed to marshal request: %w", err)
}
return string(requestJSON), nil
} }
// pkcs7Unpad validates and unpads data from the given bytes slice. // pkcs7Unpad validates and unpads data from the given bytes slice.