mirror of
https://github.com/versity/versitygw.git
synced 2026-10-22 14:22:40 +00:00
Christian SchmittandClaude Opus 5.5
8137b7adae
signedAdminRequest takes the signing region and a body, and always names root in X-Vgw-Owner (admin create-bucket requires it, the other admin routes ignore it), so the create-bucket test reuses it instead of its own copy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
97 lines
3.2 KiB
Go
97 lines
3.2 KiB
Go
// Copyright 2026 Versity Software
|
|
// This file is licensed under the Apache License, Version 2.0
|
|
// (the "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing,
|
|
// software distributed under the License is distributed on an
|
|
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
// KIND, either express or implied. See the License for the
|
|
// specific language governing permissions and limitations
|
|
// under the License.
|
|
|
|
package s3api
|
|
|
|
import (
|
|
"io"
|
|
"net/http"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/gofiber/fiber/v3"
|
|
"github.com/versity/versitygw/backend"
|
|
"github.com/versity/versitygw/s3api/controllers"
|
|
)
|
|
|
|
// The admin CreateBucket must check its LocationConstraint against the
|
|
// gateway region on a standalone admin port, just like it does when the admin
|
|
// API shares the s3 port.
|
|
func TestAdminCreateBucketLocationConstraint(t *testing.T) {
|
|
const region = "eu-central-1"
|
|
|
|
servers := []struct {
|
|
name string
|
|
newApp func(t *testing.T) *fiber.App
|
|
}{
|
|
{name: "standalone admin server", newApp: func(t *testing.T) *fiber.App {
|
|
iam := testAdminIAM()
|
|
ctrl := controllers.New(backend.BackendUnsupported{}, iam, nil, nil, nil, false, false, "", 0)
|
|
srv := NewAdminServer(backend.BackendUnsupported{}, testAdminRoot, region, iam, nil, ctrl,
|
|
WithAdminConcurrencyLimiter(10, 10),
|
|
WithAdminQuiet(),
|
|
)
|
|
return srv.app
|
|
}},
|
|
{name: "admin on s3 server", newApp: func(t *testing.T) *fiber.App {
|
|
srv, err := New(backend.BackendUnsupported{}, testAdminRoot, region, testAdminIAM(), nil, nil, nil, nil,
|
|
WithConcurrencyLimiter(10, 10),
|
|
WithQuiet(),
|
|
WithAdminServer(),
|
|
)
|
|
if err != nil {
|
|
t.Fatalf("new s3 server: %v", err)
|
|
}
|
|
return srv.app
|
|
}},
|
|
}
|
|
|
|
tests := []struct {
|
|
name string
|
|
constraint string
|
|
wantStatus int
|
|
wantCode string
|
|
}{
|
|
// BackendUnsupported answers a CreateBucket that passed validation with 501.
|
|
{name: "gateway region", constraint: region, wantStatus: http.StatusNotImplemented},
|
|
{name: "no constraint", wantStatus: http.StatusBadRequest, wantCode: "IllegalLocationConstraintException"},
|
|
{name: "other region", constraint: "us-west-2", wantStatus: http.StatusBadRequest, wantCode: "IllegalLocationConstraintException"},
|
|
}
|
|
|
|
for _, srv := range servers {
|
|
for _, tt := range tests {
|
|
t.Run(srv.name+"/"+tt.name, func(t *testing.T) {
|
|
body := ""
|
|
if tt.constraint != "" {
|
|
body = "<CreateBucketConfiguration><LocationConstraint>" + tt.constraint + "</LocationConstraint></CreateBucketConfiguration>"
|
|
}
|
|
|
|
resp, err := srv.newApp(t).Test(signedAdminRequest(t, "/test-bucket/create", region, body))
|
|
if err != nil {
|
|
t.Fatalf("app.Test: %v", err)
|
|
}
|
|
defer resp.Body.Close()
|
|
|
|
respBody, _ := io.ReadAll(resp.Body)
|
|
if resp.StatusCode != tt.wantStatus {
|
|
t.Fatalf("status %d, want %d: %s", resp.StatusCode, tt.wantStatus, respBody)
|
|
}
|
|
if tt.wantCode != "" && !strings.Contains(string(respBody), "<Code>"+tt.wantCode+"</Code>") {
|
|
t.Fatalf("response %s, want error code %s", respBody, tt.wantCode)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
}
|