Files
versitygw/internal/sigv4auth/ctx.go
T
niksis02 2147a0c304 feat: integrate standalone IAM service with S3 gateway for identity-based policy enforcement
Fixes #1327
Fixes #1567
Closes #2264

Wires the S3 gateway up to the standalone IAM service so identity policies, not just bucket policies and ACLs, are enforced on the S3 data plane. The gateway authenticates SigV4 requests by calling new private derive-signing-key and resolve-identity endpoints on the IAM service instead of holding secrets itself, and evaluates identity policy through the same PolicyEvaluator path added to auth.VerifyAccess, combined with the bucket policy using explicit-deny-wins precedence. The private endpoints are served over their own mTLS listener (new iamapi/private package, genmtlscerts.sh to generate test material, and client-cert support in internal/netutil), separate from the public IAM API. As part of this the vendored aws/signer/v4 package is deleted and replaced by a pure-Go SigV4 implementation in internal/sigv4auth, which now reads canonical request data directly off the fiber.Ctx instead of reconstructing an http.Request, and is shared by both the S3 request-signing verification and the new private-endpoint signing.

DeleteObjects moves from an all-or-nothing authorization check to true partial success: VerifyObjectsAccess evaluates every object in a batch independently against both the identity policy and any object lock, so a denial or a locked object only removes that key from the batch instead of failing the whole request. It also batches the identity-policy round trip and the bucket-policy fetch once per request rather than once per object, and separates plain deletes from versioned ones since a versioned delete needs s3:DeleteObjectVersion rather than s3:DeleteObject. Object lock handling got a few correctness fixes alongside this: a bypass is now modeled as BypassNone/BypassRequested/BypassOverwrite rather than a single bool, because root's blanket ability to override a GOVERNANCE retention should only apply when the client actually asked to bypass it (DeleteObject/DeleteObjects/PutObjectRetention), not when the gateway is silently replacing a locked object via an overwrite, which needs the permission from everyone including root. Retention changes are now correctly classified as an extension (allowed under plain s3:PutObjectRetention) versus a weakening (date or mode change, which needs the bypass permission), and a COMPLIANCE lock can never be weakened by anyone regardless of permissions, matching AWS. Separately, VerifyObjectCopyAccess had a readonly-mode gap: it returned early for root/admin before ever calling VerifyAccess, so the readonly check inside VerifyAccess never ran for them on CopyObject; access checks are now ordered so the readonly gate always applies before any root/admin bypass, for copy as well as every other write path.

Bucket policies also gained Condition block support, via a new shared internal/condition package moved out of the IAM policy package since both bucket and identity policies share the same evaluation semantics. It implements the full AWS operator set — String{Equals,NotEquals,EqualsIgnoreCase,NotEqualsIgnoreCase,Like,NotLike}, Numeric{Equals,NotEquals,LessThan,LessThanEquals,GreaterThan,GreaterThanEquals}, Date{Equals,NotEquals,LessThan,LessThanEquals,GreaterThan,GreaterThanEquals}, Bool, BinaryEquals, Arn{Equals,Like,NotEquals,NotLike}, IpAddress/NotIpAddress, and Null — along with the ForAllValues/ForAnyValue set qualifiers and the IfExists modifier. A new requestConditionContext builds the per-request keys a bucket policy's Condition block can reference — aws:SourceIp, aws:SecureTransport, aws:CurrentTime, aws:EpochTime, aws:UserAgent, aws:Referer, s3:prefix, s3:delimiter, s3:max-keys, s3:x-amz-acl, s3:VersionId — following AWS's own per-action rules for which keys a given S3 operation actually populates. Identity-derived keys such as aws:PrincipalArn and aws:username are deliberately left unwired here, since the gateway has no way to know them; the standalone IAM service fills those in itself when it evaluates an identity policy.

Also added new integration test suites for S3-side IAM: s3_iam_access_control.go and s3_iam_session_access_control.go cover identity-policy enforcement and session-credential requests against real S3 operations, alongside expanded OIDC/web-identity coverage and a new runoidctests.sh runner wired into the OIDC GitHub Actions workflow.
2026-08-25 01:07:36 +04:00

145 lines
4.9 KiB
Go

// Copyright 2026 Versity Software
// This file is licensed under the Apache License, Version 2.0
// (the "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package sigv4auth
import (
"net/http"
"net/url"
"strings"
"github.com/gofiber/fiber/v3"
"github.com/versity/versitygw/debuglogger"
"github.com/versity/versitygw/internal/httpctx"
)
// signingInputFromCtx builds a SigningInput straight from ctx's underlying
// fasthttp request. isPreSign selects between header-auth's and presigned (query) auth's
// slightly different query/header handling; see queryFromCtx/
// presignQueryFromCtx and headersFromCtx.
func signingInputFromCtx(ctx fiber.Ctx, signedHdrs []string, contentLength int64, requiredSignedHdrs []string, isPreSign bool) (SigningInput, error) {
if err := validateRequiredSignedHeaders(signedHdrs, requiredSignedHdrs); err != nil {
return SigningInput{}, err
}
headers, err := headersFromCtx(ctx, signedHdrs, requiredSignedHdrs, isPreSign)
if err != nil {
return SigningInput{}, err
}
query := queryFromCtx(ctx)
if isPreSign {
query = presignQueryFromCtx(ctx)
}
return SigningInput{
Method: methodFromCtx(ctx),
Host: hostFromCtx(ctx),
URIPath: uriPathFromCtx(ctx),
Query: query,
Header: headers,
ContentLength: contentLength,
IsPreSign: isPreSign,
}, nil
}
// methodFromCtx returns ctx's HTTP method from the underlying fasthttp
// request header directly
func methodFromCtx(ctx fiber.Ctx) string {
return string(ctx.Request().Header.Method())
}
// headersFromCtx collects ctx's request headers eligible for signing: every
// header naming itself in signedHdrs, plus any header ignoredHeaders always
// signs regardless. Reads straight off the underlying fasthttp request
// (Header.All(), preserving every duplicate key exactly as sent).
func headersFromCtx(ctx fiber.Ctx, signedHdrs, requiredSignedHdrs []string, isPreSign bool) (http.Header, error) {
headers := http.Header{}
headersNotSigned := []string{}
for key, value := range ctx.Request().Header.All() {
keyStr := string(key)
if includeHeader(keyStr, signedHdrs) || IsIgnoredHeader(keyStr) {
headers.Add(keyStr, string(value))
continue
}
if isRequiredSignedHeader(keyStr, requiredSignedHdrs) {
headersNotSigned = append(headersNotSigned, strings.ToLower(keyStr))
}
}
if len(headersNotSigned) != 0 {
debuglogger.Logf("headers present in request but not included in SignedHeaders: %q", strings.Join(headersNotSigned, ", "))
return nil, &HeadersNotSignedError{Headers: headersNotSigned}
}
if !isPreSign {
for _, header := range signedHdrs {
if headers.Get(header) == "" {
headers.Set(header, "")
}
}
}
return headers, nil
}
// queryFromCtx returns ctx's full, unfiltered query string as url.Values —
// the header-auth path, where any existing query parameters (e.g.
// ?partNumber=2) are simply part of the canonical request, untouched.
func queryFromCtx(ctx fiber.Ctx) url.Values {
query := url.Values{}
for key, value := range ctx.Request().URI().QueryArgs().All() {
query.Add(string(key), string(value))
}
return query
}
// presignQueryFromCtx returns ctx's query string as url.Values with the
// generated SigV4 auth parameters excluded (generatedQueryAuthParams) —
// the presign path, which must recompute and re-add its own
// X-Amz-Credential/X-Amz-SignedHeaders/X-Amz-Signature rather than sign the
// client-presented ones.
func presignQueryFromCtx(ctx fiber.Ctx) url.Values {
query := url.Values{}
for key, value := range ctx.Request().URI().QueryArgs().All() {
keyStr := string(key)
if _, ok := generatedQueryAuthParams[keyStr]; ok {
continue
}
query.Add(keyStr, string(value))
}
return query
}
// uriPathFromCtx returns ctx's raw request path exactly as received on the
// wire (fasthttp's PathOriginal — unnormalized, unescaped-or-not exactly as
// sent, no dot-segment collapsing), "/" if empty. HostStyleParser rewrites
// PathOriginal itself to move a virtual-hosted-style request's bucket from
// the Host header into the path for routing, so the true original is read
// back from where it stashed it rather than from PathOriginal directly.
func uriPathFromCtx(ctx fiber.Ctx) string {
path := string(ctx.Request().URI().PathOriginal())
if httpctx.ContextKeyOriginalURIPath.IsSet(ctx) {
path, _ = httpctx.ContextKeyOriginalURIPath.Get(ctx).(string)
}
if path == "" {
return "/"
}
return path
}
// hostFromCtx returns ctx's Host header verbatim.
func hostFromCtx(ctx fiber.Ctx) string {
return string(ctx.Request().Header.Host())
}