mirror of
https://github.com/versity/versitygw.git
synced 2026-09-25 09:24:22 +00:00
Adds `TagUser`, `UntagUser` and `ListUserTags` to the standalone IAM service, backed by both the internal and Vault storers. Tag keys are matched case-insensitively but stored case-preserving, TagUser merges into the user's existing tags and rejects duplicate keys, UntagUser removal is idempotent, and ListUserTags is sorted by key and paginated. The per-request member count and the per-user tag total are enforced as separate quotas. All three actions are authorized against the target user's ARN, and TagUser and UntagUser populate aws:RequestTag/<key> and aws:TagKeys respectively, so a tag-scoped policy Condition governs which tags a caller may set or remove. The WebGUI gains a Tags section in the IAM user manage view, with an editor that applies a whole edited tag set as a single UntagUser and TagUser pair. Also corrects two error shapes that never matched AWS: a half-supplied tag member now reports a ValidationError naming the member field instead of MissingParameter, and the maxItems bound check reports separate lower- and upper-bound errors across every IAM list action.
224 lines
6.6 KiB
Go
224 lines
6.6 KiB
Go
// Copyright 2026 Versity Software
|
|
// This file is licensed under the Apache License, Version 2.0
|
|
// (the "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing,
|
|
// software distributed under the License is distributed on an
|
|
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
// KIND, either express or implied. See the License for the
|
|
// specific language governing permissions and limitations
|
|
// under the License.
|
|
|
|
package integration
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"net/http"
|
|
"slices"
|
|
"time"
|
|
|
|
"github.com/aws/aws-sdk-go-v2/aws"
|
|
awsmiddleware "github.com/aws/aws-sdk-go-v2/aws/middleware"
|
|
"github.com/aws/aws-sdk-go-v2/service/iam"
|
|
"github.com/versity/versitygw/iamapi/iamerr"
|
|
)
|
|
|
|
func IAMListUserPolicies_missing_user_name(s *S3Conf) error {
|
|
testName := "IAMListUserPolicies_missing_user_name"
|
|
body := []byte("Action=ListUserPolicies&Version=2010-05-08")
|
|
return authHandler(s, &authConfig{
|
|
testName: testName,
|
|
method: http.MethodPost,
|
|
service: "iam",
|
|
region: iamAuthRegion,
|
|
body: body,
|
|
date: time.Now().UTC(),
|
|
headers: map[string]string{
|
|
"Content-Type": "application/x-www-form-urlencoded",
|
|
},
|
|
}, func(req *http.Request) error {
|
|
return checkIAMAuthRequest(s, req, iamerr.MissingValue("userName"))
|
|
})
|
|
}
|
|
|
|
func IAMListUserPolicies_non_existing_user(s *S3Conf) error {
|
|
testName := "IAMListUserPolicies_non_existing_user"
|
|
return iamActionHandler(s, testName, func(client *iam.Client) error {
|
|
userName := "non-existing-" + genRandString(16)
|
|
_, err := listIAMUserPolicies(client, &iam.ListUserPoliciesInput{UserName: &userName})
|
|
return checkIAMApiErr(err, iamerr.NoSuchEntityUser(userName))
|
|
})
|
|
}
|
|
|
|
func IAMListUserPolicies_invalid_max_items(s *S3Conf) error {
|
|
testName := "IAMListUserPolicies_invalid_max_items"
|
|
return iamActionHandler(s, testName, func(client *iam.Client) error {
|
|
userName := newIAMUserName()
|
|
if _, err := createIAMUser(client, &iam.CreateUserInput{UserName: &userName}); err != nil {
|
|
return err
|
|
}
|
|
|
|
checkErr := checkIAMApiErr(
|
|
func() error {
|
|
_, err := listIAMUserPolicies(client, &iam.ListUserPoliciesInput{UserName: &userName, MaxItems: aws.Int32(1001)})
|
|
return err
|
|
}(),
|
|
iamerr.GetAPIError(iamerr.ErrMaxItemsTooHigh),
|
|
)
|
|
|
|
deleteErr := deleteIAMUser(client, userName)
|
|
if checkErr != nil {
|
|
return checkErr
|
|
}
|
|
return deleteErr
|
|
})
|
|
}
|
|
|
|
func IAMListUserPolicies_empty_result(s *S3Conf) error {
|
|
testName := "IAMListUserPolicies_empty_result"
|
|
return iamActionHandler(s, testName, func(client *iam.Client) error {
|
|
userName := newIAMUserName()
|
|
if _, err := createIAMUser(client, &iam.CreateUserInput{UserName: &userName}); err != nil {
|
|
return err
|
|
}
|
|
|
|
checkErr := func() error {
|
|
out, err := listIAMUserPolicies(client, &iam.ListUserPoliciesInput{UserName: &userName})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if len(out.PolicyNames) != 0 {
|
|
return fmt.Errorf("expected no policies, instead got %v", out.PolicyNames)
|
|
}
|
|
if out.IsTruncated {
|
|
return fmt.Errorf("expected IsTruncated to be false")
|
|
}
|
|
return nil
|
|
}()
|
|
|
|
deleteErr := deleteIAMUser(client, userName)
|
|
if checkErr != nil {
|
|
return checkErr
|
|
}
|
|
return deleteErr
|
|
})
|
|
}
|
|
|
|
func IAMListUserPolicies_success(s *S3Conf) error {
|
|
testName := "IAMListUserPolicies_success"
|
|
return iamActionHandler(s, testName, func(client *iam.Client) error {
|
|
userName := newIAMUserName()
|
|
if _, err := createIAMUser(client, &iam.CreateUserInput{UserName: &userName}); err != nil {
|
|
return err
|
|
}
|
|
|
|
checkErr := func() error {
|
|
want := []string{"Alpha", "Beta"}
|
|
for _, name := range want {
|
|
if _, err := putIAMUserPolicy(client, &iam.PutUserPolicyInput{
|
|
UserName: &userName,
|
|
PolicyName: aws.String(name),
|
|
PolicyDocument: aws.String(validIAMPolicyDocument),
|
|
}); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
out, err := listIAMUserPolicies(client, &iam.ListUserPoliciesInput{UserName: &userName})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if requestID, ok := awsmiddleware.GetRequestIDMetadata(out.ResultMetadata); !ok || requestID == "" {
|
|
return fmt.Errorf("expected ListUserPolicies response request id")
|
|
}
|
|
got := slices.Clone(out.PolicyNames)
|
|
slices.Sort(got)
|
|
if !slices.Equal(got, want) {
|
|
return fmt.Errorf("expected policy names %v, instead got %v", want, got)
|
|
}
|
|
if out.IsTruncated {
|
|
return fmt.Errorf("expected IsTruncated to be false")
|
|
}
|
|
return nil
|
|
}()
|
|
|
|
deleteErr := deleteIAMUserAndPolicies(client, userName)
|
|
if checkErr != nil {
|
|
return checkErr
|
|
}
|
|
return deleteErr
|
|
})
|
|
}
|
|
|
|
func IAMListUserPolicies_pagination(s *S3Conf) error {
|
|
testName := "IAMListUserPolicies_pagination"
|
|
return iamActionHandler(s, testName, func(client *iam.Client) error {
|
|
userName := newIAMUserName()
|
|
if _, err := createIAMUser(client, &iam.CreateUserInput{UserName: &userName}); err != nil {
|
|
return err
|
|
}
|
|
|
|
checkErr := func() error {
|
|
want := []string{"Alpha", "Beta", "Gamma"}
|
|
for _, name := range want {
|
|
if _, err := putIAMUserPolicy(client, &iam.PutUserPolicyInput{
|
|
UserName: &userName,
|
|
PolicyName: aws.String(name),
|
|
PolicyDocument: aws.String(validIAMPolicyDocument),
|
|
}); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
input := iam.ListUserPoliciesInput{UserName: &userName, MaxItems: aws.Int32(1)}
|
|
var pages []*iam.ListUserPoliciesOutput
|
|
for {
|
|
out, err := listIAMUserPolicies(client, &input)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
pages = append(pages, out)
|
|
if !out.IsTruncated {
|
|
break
|
|
}
|
|
input.Marker = out.Marker
|
|
}
|
|
|
|
if len(pages) != len(want) {
|
|
return fmt.Errorf("expected %d pages, instead got %d", len(want), len(pages))
|
|
}
|
|
var got []string
|
|
for i, page := range pages {
|
|
if len(page.PolicyNames) != 1 {
|
|
return fmt.Errorf("expected page %d to contain 1 policy, instead got %d", i+1, len(page.PolicyNames))
|
|
}
|
|
if page.IsTruncated != (i < len(pages)-1) {
|
|
return fmt.Errorf("unexpected IsTruncated value on page %d", i+1)
|
|
}
|
|
got = append(got, page.PolicyNames...)
|
|
}
|
|
slices.Sort(got)
|
|
if !slices.Equal(got, want) {
|
|
return fmt.Errorf("expected policy names %v, instead got %v", want, got)
|
|
}
|
|
return nil
|
|
}()
|
|
|
|
deleteErr := deleteIAMUserAndPolicies(client, userName)
|
|
if checkErr != nil {
|
|
return checkErr
|
|
}
|
|
return deleteErr
|
|
})
|
|
}
|
|
|
|
func listIAMUserPolicies(client *iam.Client, input *iam.ListUserPoliciesInput) (*iam.ListUserPoliciesOutput, error) {
|
|
ctx, cancel := context.WithTimeout(context.Background(), shortTimeout)
|
|
defer cancel()
|
|
return client.ListUserPolicies(ctx, input)
|
|
}
|