mirror of
https://github.com/versity/versitygw.git
synced 2026-01-07 12:15:18 +00:00
eae11b44c5
Fixes #1630 S3 returns `InvalidArgument: Invalid version id specified` for invalid version IDs in object-level actions that accept `versionId` as a query parameter. The `versionId` in S3 follows a specific structure, and if the input string doesn’t match this structure, the error is returned. In the gateway, the `versionId` is generated using the `ulid` package, which also has a defined structure. This PR adds validation for object-level operations that work with object versions by using the ULID parser. These actions include: `HeadObject`, `GetObject`, `PutObjectTagging`, `GetObjectTagging`, `DeleteObjectTagging`, `PutObjectLegalHold`, `GetObjectLegalHold`, `PutObjectRetention`, `GetObjectRetention`, `DeleteObject`, `CopyObject`, `UploadPartCopy`, and `GetObjectAttributes`.
425 lines
14 KiB
Bash
Executable File
425 lines
14 KiB
Bash
Executable File
#!/usr/bin/env bats
|
|
|
|
# Copyright 2024 Versity Software
|
|
# This file is licensed under the Apache License, Version 2.0
|
|
# (the "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http:#www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
load ./bats-support/load
|
|
load ./bats-assert/load
|
|
|
|
source ./tests/setup.sh
|
|
source ./tests/drivers/file.sh
|
|
source ./tests/drivers/rest.sh
|
|
source ./tests/drivers/create_bucket/create_bucket_rest.sh
|
|
source ./tests/drivers/complete_multipart_upload/complete_multipart_upload_rest.sh
|
|
source ./tests/drivers/list_buckets/list_buckets_rest.sh
|
|
source ./tests/drivers/upload_part/upload_part_rest.sh
|
|
source ./tests/util/util_file.sh
|
|
source ./tests/util/util_list_parts.sh
|
|
|
|
test_file="test_file"
|
|
|
|
@test "REST - multipart upload create then abort" {
|
|
run get_bucket_name "$BUCKET_ONE_NAME"
|
|
assert_success
|
|
bucket_name="$output"
|
|
|
|
run setup_bucket "$bucket_name"
|
|
assert_success
|
|
|
|
run create_abort_multipart_upload_rest "$bucket_name" "$test_file"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart upload create, list parts" {
|
|
run get_bucket_name "$BUCKET_ONE_NAME"
|
|
assert_success
|
|
bucket_name="$output"
|
|
|
|
run setup_bucket_and_large_file_v2 "$bucket_name" "$test_file"
|
|
assert_success
|
|
|
|
run split_file "$TEST_FILE_FOLDER/$test_file" 4
|
|
assert_success
|
|
|
|
run upload_check_parts "$bucket_name" "$test_file" \
|
|
"$TEST_FILE_FOLDER/$test_file-0" "$TEST_FILE_FOLDER/$test_file-1" "$TEST_FILE_FOLDER/$test_file-2" "$TEST_FILE_FOLDER/$test_file-3"
|
|
assert_success
|
|
|
|
run download_and_compare_file "$TEST_FILE_FOLDER/$test_file" "$bucket_name" "$test_file" "$TEST_FILE_FOLDER/$test_file-copy"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - complete upload - invalid part" {
|
|
if [ "$DIRECT" != "true" ]; then
|
|
skip "https://github.com/versity/versitygw/issues/1008"
|
|
fi
|
|
run get_bucket_name "$BUCKET_ONE_NAME"
|
|
assert_success
|
|
bucket_name="$output"
|
|
|
|
run setup_bucket_and_large_file_v2 "$bucket_name" "$test_file"
|
|
assert_success
|
|
|
|
run create_upload_finish_wrong_etag "$bucket_name" "$test_file"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - upload part copy (UploadPartCopy)" {
|
|
run get_bucket_name "$BUCKET_ONE_NAME"
|
|
assert_success
|
|
bucket_name="$output"
|
|
|
|
run setup_bucket_and_large_file_v2 "$bucket_name" "$test_file"
|
|
assert_success
|
|
|
|
run create_upload_part_copy_rest "$bucket_name" "$test_file" "$TEST_FILE_FOLDER/$test_file"
|
|
assert_success
|
|
|
|
run download_and_compare_file "$TEST_FILE_FOLDER/$test_file" "$bucket_name" "$test_file" "$TEST_FILE_FOLDER/$test_file-copy"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - UploadPartCopy w/o upload ID" {
|
|
run get_bucket_name "$BUCKET_ONE_NAME"
|
|
assert_success
|
|
bucket_name="$output"
|
|
|
|
run upload_part_copy_without_upload_id_or_part_number "$bucket_name" "$test_file" "1" "" \
|
|
400 "InvalidArgument" "This operation does not accept partNumber without uploadId"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - UploadPartCopy w/o part number" {
|
|
run get_bucket_name "$BUCKET_ONE_NAME"
|
|
assert_success
|
|
bucket_name="$output"
|
|
|
|
run upload_part_copy_without_upload_id_or_part_number "$bucket_name" "$test_file" "" "dummy" \
|
|
405 "MethodNotAllowed" "The specified method is not allowed against this resource"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - UploadPartCopy - ETag is quoted" {
|
|
run get_bucket_name "$BUCKET_ONE_NAME"
|
|
assert_success
|
|
bucket_name="$output"
|
|
|
|
run setup_bucket_and_file_v2 "$bucket_name" "$test_file"
|
|
assert_success
|
|
|
|
run put_object "rest" "$TEST_FILE_FOLDER/$test_file" "$bucket_name" "$test_file"
|
|
assert_success
|
|
|
|
run upload_part_copy_check_etag_header "$bucket_name" "$test_file"-mp "$bucket_name/$test_file"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - UploadPart - ETag is quoted" {
|
|
run get_bucket_name "$BUCKET_ONE_NAME"
|
|
assert_success
|
|
bucket_name="$output"
|
|
|
|
run setup_bucket_and_large_file_v2 "$bucket_name" "$test_file"
|
|
assert_success
|
|
|
|
run split_file "$TEST_FILE_FOLDER/$test_file" 4
|
|
assert_success
|
|
|
|
run create_multipart_upload_rest "$bucket_name" "$test_file" "" "parse_upload_id"
|
|
assert_success
|
|
# shellcheck disable=SC2030
|
|
upload_id=$output
|
|
|
|
run upload_part_check_etag_header "$bucket_name" "$test_file" "$upload_id" "1" "$TEST_FILE_FOLDER/${test_file}-0"
|
|
assert_success
|
|
}
|
|
|
|
# @test "REST - UploadPart w/o part number" {
|
|
# run get_bucket_name "$BUCKET_ONE_NAME"
|
|
# assert_success
|
|
# bucket_name="$output"
|
|
|
|
# run setup_bucket_and_large_file_v2 "$bucket_name" "$test_file"
|
|
# assert_success
|
|
|
|
# run split_file "$TEST_FILE_FOLDER/$test_file" 4
|
|
# assert_success
|
|
|
|
# run upload_part_rest_without_part_number "$bucket_name" "$test_file"
|
|
# assert_success
|
|
# }
|
|
|
|
@test "REST - UploadPart w/o upload ID" {
|
|
run get_bucket_name "$BUCKET_ONE_NAME"
|
|
assert_success
|
|
bucket_name="$output"
|
|
|
|
run setup_bucket_and_large_file_v2 "$bucket_name" "$test_file"
|
|
assert_success
|
|
|
|
run split_file "$TEST_FILE_FOLDER/$test_file" 4
|
|
assert_success
|
|
|
|
run upload_part_rest_without_upload_id "$bucket_name" "$test_file"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart w/invalid checksum type" {
|
|
run get_bucket_name "$BUCKET_ONE_NAME"
|
|
assert_success
|
|
bucket_name="$output"
|
|
|
|
run setup_bucket_v2 "$bucket_name"
|
|
assert_success
|
|
|
|
run create_multipart_upload_rest_with_checksum_type_and_algorithm_error "$bucket_name" "$test_file" "FULL_OBJECTS" "" \
|
|
check_rest_expected_error "400" "InvalidRequest" "Value for x-amz-checksum-type header is invalid"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart w/invalid checksum algorithm" {
|
|
run get_bucket_name "$BUCKET_ONE_NAME"
|
|
assert_success
|
|
bucket_name="$output"
|
|
|
|
run setup_bucket_v2 "$bucket_name"
|
|
assert_success
|
|
|
|
run create_multipart_upload_rest_with_checksum_type_and_algorithm_error "$bucket_name" "$test_file" "" "crc64nvm" \
|
|
check_rest_expected_error "400" "InvalidRequest" "Checksum algorithm provided is unsupported."
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart checksum w/crc64nvme, composite" {
|
|
if [ "$DIRECT" != "true" ]; then
|
|
skip "https://github.com/versity/versitygw/issues/1329"
|
|
fi
|
|
run get_bucket_name "$BUCKET_ONE_NAME"
|
|
assert_success
|
|
bucket_name="$output"
|
|
|
|
run setup_bucket_v2 "$bucket_name"
|
|
assert_success
|
|
|
|
run create_multipart_upload_rest_with_checksum_type_and_algorithm_error "$bucket_name" "$test_file" "COMPOSITE" "crc64nvme" \
|
|
check_rest_expected_error "400" "InvalidRequest" "The COMPOSITE checksum type cannot be used with the crc64nvme checksum algorithm."
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart checksum w/sha1, full object" {
|
|
if [ "$DIRECT" != "true" ]; then
|
|
skip "https://github.com/versity/versitygw/issues/1329"
|
|
fi
|
|
run get_bucket_name "$BUCKET_ONE_NAME"
|
|
assert_success
|
|
bucket_name="$output"
|
|
|
|
run setup_bucket_v2 "$bucket_name"
|
|
assert_success
|
|
|
|
run create_multipart_upload_rest_with_checksum_type_and_algorithm_error "$bucket_name" "$test_file" "FULL_OBJECT" "sha1" \
|
|
check_rest_expected_error "400" "InvalidRequest" "The FULL_OBJECT checksum type cannot be used with the sha1 checksum algorithm."
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart checksum w/sha256, full object" {
|
|
if [ "$DIRECT" != "true" ]; then
|
|
skip "https://github.com/versity/versitygw/issues/1329"
|
|
fi
|
|
run get_bucket_name "$BUCKET_ONE_NAME"
|
|
assert_success
|
|
bucket_name="$output"
|
|
|
|
run setup_bucket_v2 "$BUCKET_ONE_NAME"
|
|
assert_success
|
|
|
|
run create_multipart_upload_rest_with_checksum_type_and_algorithm_error "$BUCKET_ONE_NAME" "$test_file" "FULL_OBJECT" "sha256" \
|
|
check_rest_expected_error "400" "InvalidRequest" "The FULL_OBJECT checksum type cannot be used with the sha256 checksum algorithm."
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart - lowercase checksum type and algorithm" {
|
|
run get_bucket_name "$BUCKET_ONE_NAME"
|
|
assert_success
|
|
bucket_name="$output"
|
|
|
|
run setup_bucket "$bucket_name"
|
|
assert_success
|
|
|
|
run create_multipart_upload_rest "$bucket_name" "$test_file" "CHECKSUM_TYPE=full_object CHECKSUM_ALGORITHM=crc64nvme" "parse_upload_id"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart - full object checksum type doesn't require UploadPart checksums" {
|
|
run get_bucket_name "$BUCKET_ONE_NAME"
|
|
assert_success
|
|
bucket_name="$output"
|
|
|
|
run setup_bucket "$bucket_name"
|
|
assert_success
|
|
|
|
run create_test_file "$test_file" $((5*1024*1024))
|
|
assert_success
|
|
|
|
run create_multipart_upload_rest "$bucket_name" "$test_file" "CHECKSUM_TYPE=FULL_OBJECT CHECKSUM_ALGORITHM=CRC32" "parse_upload_id"
|
|
assert_success
|
|
upload_id=$output
|
|
log 5 "upload ID: $upload_id"
|
|
|
|
run upload_part_rest "$bucket_name" "$test_file" "$upload_id" 1 "$TEST_FILE_FOLDER/$test_file"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart - composite - sha256" {
|
|
if [ "$DIRECT" != "true" ]; then
|
|
skip "https://github.com/versity/versitygw/issues/1359"
|
|
fi
|
|
run test_multipart_upload_with_checksum "$BUCKET_ONE_NAME" "$test_file" "COMPOSITE" "SHA256"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart - composite - sha1" {
|
|
if [ "$DIRECT" != "true" ]; then
|
|
skip "https://github.com/versity/versitygw/issues/1359"
|
|
fi
|
|
run test_multipart_upload_with_checksum "$BUCKET_ONE_NAME" "$test_file" "COMPOSITE" "SHA1"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart - composite - crc32" {
|
|
if [ "$DIRECT" != "true" ]; then
|
|
skip "https://github.com/versity/versitygw/issues/1359"
|
|
fi
|
|
run test_multipart_upload_with_checksum "$BUCKET_ONE_NAME" "$test_file" "COMPOSITE" "CRC32"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart - composite - crc32c" {
|
|
if [ "$DIRECT" != "true" ]; then
|
|
skip "https://github.com/versity/versitygw/issues/1359"
|
|
fi
|
|
run test_multipart_upload_with_checksum "$BUCKET_ONE_NAME" "$test_file" "COMPOSITE" "CRC32C"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart - full object - crc32" {
|
|
run test_multipart_upload_with_checksum "$BUCKET_ONE_NAME" "$test_file" "FULL_OBJECT" "CRC32"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart - full object - crc32c" {
|
|
run test_multipart_upload_with_checksum "$BUCKET_ONE_NAME" "$test_file" "FULL_OBJECT" "CRC32C"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart - full object - crc64nvme" {
|
|
run test_multipart_upload_with_checksum "$BUCKET_ONE_NAME" "$test_file" "FULL_OBJECT" "CRC64NVME"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart - x-amz-checksum-algorithm is ignored in CompleteMultipartUpload" {
|
|
run test_complete_multipart_upload_unneeded_algorithm_parameter "$BUCKET_ONE_NAME" "$test_file" "FULL_OBJECT" "CRC32C"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart - composite - incorrect sha256" {
|
|
if [ "$DIRECT" != "true" ]; then
|
|
skip "https://github.com/versity/versitygw/issues/1359"
|
|
fi
|
|
run test_complete_multipart_upload_incorrect_checksum "$BUCKET_ONE_NAME" "$test_file" "COMPOSITE" "SHA256"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart - composite - incorrect sha1" {
|
|
if [ "$DIRECT" != "true" ]; then
|
|
skip "https://github.com/versity/versitygw/issues/1359"
|
|
fi
|
|
run test_complete_multipart_upload_incorrect_checksum "$BUCKET_ONE_NAME" "$test_file" "COMPOSITE" "SHA1"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart - composite - incorrect crc32" {
|
|
if [ "$DIRECT" != "true" ]; then
|
|
skip "https://github.com/versity/versitygw/issues/1359"
|
|
fi
|
|
run test_complete_multipart_upload_incorrect_checksum "$BUCKET_ONE_NAME" "$test_file" "COMPOSITE" "CRC32C"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart - composite - incorrect crc32c" {
|
|
if [ "$DIRECT" != "true" ]; then
|
|
skip "https://github.com/versity/versitygw/issues/1359"
|
|
fi
|
|
run test_complete_multipart_upload_incorrect_checksum "$BUCKET_ONE_NAME" "$test_file" "COMPOSITE" "CRC32C"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart - full object - incorrect crc32" {
|
|
run test_complete_multipart_upload_incorrect_checksum "$BUCKET_ONE_NAME" "$test_file" "FULL_OBJECT" "CRC32"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart - full object - incorrect crc32c" {
|
|
run test_complete_multipart_upload_incorrect_checksum "$BUCKET_ONE_NAME" "$test_file" "FULL_OBJECT" "CRC32C"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart - full object - incorrect crc64nvme" {
|
|
run test_complete_multipart_upload_incorrect_checksum "$BUCKET_ONE_NAME" "$test_file" "FULL_OBJECT" "CRC64NVME"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart - composite - invalid sha1" {
|
|
run test_complete_multipart_upload_invalid_checksum "$BUCKET_ONE_NAME" "$test_file" "COMPOSITE" "SHA1"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart - composite - invalid sha256" {
|
|
run test_complete_multipart_upload_invalid_checksum "$BUCKET_ONE_NAME" "$test_file" "COMPOSITE" "SHA256"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart - composite - invalid crc32" {
|
|
run test_complete_multipart_upload_invalid_checksum "$BUCKET_ONE_NAME" "$test_file" "COMPOSITE" "CRC32"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart - composite - invalid crc32c" {
|
|
run test_complete_multipart_upload_invalid_checksum "$BUCKET_ONE_NAME" "$test_file" "COMPOSITE" "CRC32C"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart - full object - invalid crc32" {
|
|
run test_complete_multipart_upload_invalid_checksum "$BUCKET_ONE_NAME" "$test_file" "FULL_OBJECT" "CRC32"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart - full object - invalid crc32c" {
|
|
run test_complete_multipart_upload_invalid_checksum "$BUCKET_ONE_NAME" "$test_file" "FULL_OBJECT" "CRC32C"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart - full object - invalid crc64nvme" {
|
|
run test_complete_multipart_upload_invalid_checksum "$BUCKET_ONE_NAME" "$test_file" "FULL_OBJECT" "CRC64NVME"
|
|
assert_success
|
|
}
|
|
|
|
@test "REST - multipart - x-amz-mp-object-size - invalid string" {
|
|
run setup_bucket_and_large_file "$BUCKET_ONE_NAME" "$test_file"
|
|
assert_success
|
|
|
|
run complete_multipart_upload_invalid_object_size_string "$BUCKET_ONE_NAME" "$test_file" "$TEST_FILE_FOLDER/$test_file"
|
|
assert_success
|
|
}
|