Files
versitygw/tests/integration/iam_create_user.go
T
niksis02 ec8048fa3c feat: add IAM Role CRUD
Adds `CreateRole`, `GetRole`, `ListRoles`, `DeleteRole`, and `UpdateAssumeRolePolicy` to the standalone IAM service, following the same controller/storage patterns established for users. Both the internal filesystem/S3-backed store and the Vault-backed store implement the new `Storer` methods, with role-specific indexing and lookup helpers mirroring the existing user ones.

Role creation requires a trust policy, passed as `AssumeRolePolicyDocument`. A trust policy is a distinct kind of IAM policy document that governs who (or what) is allowed to assume a role, rather than what actions the role itself is permitted to perform. Its grammar is effectively the inverse of an identity policy: `Principal` is required, `Action`/`NotAction` values must carry the `sts:` prefix, and `Resource`/`NotResource` are forbidden. This is implemented in `iamapi/policy/trust.go` as a new validation path alongside the existing identity-policy validation, and is reused by `UpdateAssumeRolePolicy` when replacing a role's trust policy.

Also fixes user name uniqueness enforcement to be case-insensitive, matching AWS IAM behavior, and applies the same case-insensitive handling to role names. The internal store now maintains lowercase name indexes for both users and roles, and the Vault store resolves the canonical stored key via a case-insensitive list-and-compare fallback since Vault's KV paths are case-sensitive.
2026-08-15 17:38:26 +04:00

308 lines
11 KiB
Go

// Copyright 2026 Versity Software
// This file is licensed under the Apache License, Version 2.0
// (the "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.
package integration
import (
"context"
"fmt"
"net/http"
"regexp"
"strings"
"time"
"github.com/aws/aws-sdk-go-v2/aws"
awsmiddleware "github.com/aws/aws-sdk-go-v2/aws/middleware"
"github.com/aws/aws-sdk-go-v2/service/iam"
iamtypes "github.com/aws/aws-sdk-go-v2/service/iam/types"
"github.com/versity/versitygw/iamapi/iamerr"
)
var integrationIAMUserIDPattern = regexp.MustCompile(`^AIDA[A-Z2-7]{17}$`)
func IAMCreateUser_user_already_exists(s *S3Conf) error {
testName := "IAMCreateUser_user_already_exists"
return iamActionHandler(s, testName, func(client *iam.Client) error {
userName := newIAMUserName()
_, err := createIAMUser(client, &iam.CreateUserInput{
UserName: &userName,
})
if err != nil {
return err
}
_, err = createIAMUser(client, &iam.CreateUserInput{UserName: &userName})
return checkIAMApiErr(err, iamerr.EntityAlreadyExistsUser(userName))
})
}
func IAMCreateUser_already_exists_case_insensitive(s *S3Conf) error {
testName := "IAMCreateUser_already_exists_case_insensitive"
return iamActionHandler(s, testName, func(client *iam.Client) error {
userName := newIAMUserName()
if _, err := createIAMUser(client, &iam.CreateUserInput{
UserName: &userName,
}); err != nil {
return err
}
upperName := strings.ToUpper(userName)
_, err := createIAMUser(client, &iam.CreateUserInput{UserName: &upperName})
checkErr := checkIAMApiErr(err, iamerr.EntityAlreadyExistsUser(upperName))
deleteErr := deleteIAMUser(client, userName)
if checkErr != nil {
return checkErr
}
return deleteErr
})
}
func IAMCreateUser_invalid_user_name(s *S3Conf) error {
testName := "IAMCreateUser_invalid_user_name"
return iamActionHandler(s, testName, func(client *iam.Client) error {
_, err := createIAMUser(client, &iam.CreateUserInput{
UserName: aws.String("invalid/user"),
})
return checkIAMApiErr(err, iamerr.InvalidUserName("userName"))
})
}
func IAMCreateUser_long_user_name(s *S3Conf) error {
testName := "IAMCreateUser_long_user_name"
return iamActionHandler(s, testName, func(client *iam.Client) error {
_, err := createIAMUser(client, &iam.CreateUserInput{
UserName: aws.String(strings.Repeat("a", 65)),
})
return checkIAMApiErr(err, iamerr.UserNameTooLong("userName", 64))
})
}
func IAMCreateUser_missing_user_name(s *S3Conf) error {
testName := "IAMCreateUser_missing_user_name"
body := []byte("Action=CreateUser&Version=2010-05-08")
return authHandler(s, &authConfig{
testName: testName,
method: http.MethodPost,
service: "iam",
region: iamAuthRegion,
body: body,
date: time.Now().UTC(),
headers: map[string]string{
"Content-Type": "application/x-www-form-urlencoded",
},
}, func(req *http.Request) error {
return checkIAMAuthRequest(s, req, iamerr.ValidationError("1 validation error detected: Value at 'userName' failed to satisfy constraint: Member must not be null"))
})
}
func IAMCreateUser_invalid_tag_key(s *S3Conf) error {
testName := "IAMCreateUser_invalid_tag_key"
return iamActionHandler(s, testName, func(client *iam.Client) error {
_, err := createIAMUser(client, &iam.CreateUserInput{
UserName: aws.String(newIAMUserName()),
Tags: []iamtypes.Tag{
{Key: aws.String("invalid*key"), Value: aws.String("value")},
},
})
return checkIAMApiErr(err, iamerr.ValidationError("1 validation error detected: Value at 'tags.1.member.key' failed to satisfy constraint: Member must satisfy regular expression pattern: [\\p{L}\\p{Z}\\p{N}_.:/=+\\-@]+"))
})
}
func IAMCreateUser_invalid_tag_value(s *S3Conf) error {
testName := "IAMCreateUser_invalid_tag_value"
return iamActionHandler(s, testName, func(client *iam.Client) error {
_, err := createIAMUser(client, &iam.CreateUserInput{
UserName: aws.String(newIAMUserName()),
Tags: []iamtypes.Tag{
{Key: aws.String("key"), Value: aws.String("invalid*value")},
},
})
return checkIAMApiErr(err, iamerr.ValidationError("1 validation error detected: Value at 'tags.1.member.value' failed to satisfy constraint: Member must satisfy regular expression pattern: [\\p{L}\\p{Z}\\p{N}_.:/=+\\-@]*"))
})
}
func IAMCreateUser_long_tag_key(s *S3Conf) error {
testName := "IAMCreateUser_long_tag_key"
return iamActionHandler(s, testName, func(client *iam.Client) error {
_, err := createIAMUser(client, &iam.CreateUserInput{
UserName: aws.String(newIAMUserName()),
Tags: []iamtypes.Tag{
{Key: aws.String(strings.Repeat("k", 129)), Value: aws.String("value")},
},
})
return checkIAMApiErr(err, iamerr.ValidationError("1 validation error detected: Value at 'tags.1.member.key' failed to satisfy constraint: Member must have length less than or equal to 128"))
})
}
func IAMCreateUser_long_tag_value(s *S3Conf) error {
testName := "IAMCreateUser_long_tag_value"
return iamActionHandler(s, testName, func(client *iam.Client) error {
_, err := createIAMUser(client, &iam.CreateUserInput{
UserName: aws.String(newIAMUserName()),
Tags: []iamtypes.Tag{
{Key: aws.String("key"), Value: aws.String(strings.Repeat("v", 257))},
},
})
return checkIAMApiErr(err, iamerr.ValidationError("1 validation error detected: Value at 'tags.1.member.value' failed to satisfy constraint: Member must have length less than or equal to 256"))
})
}
func IAMCreateUser_duplicate_tag_keys(s *S3Conf) error {
testName := "IAMCreateUser_duplicate_tag_keys"
return iamActionHandler(s, testName, func(client *iam.Client) error {
_, err := createIAMUser(client, &iam.CreateUserInput{
UserName: aws.String(newIAMUserName()),
Tags: []iamtypes.Tag{
{Key: aws.String("key"), Value: aws.String("one")},
{Key: aws.String("KEY"), Value: aws.String("two")},
},
})
return checkIAMApiErr(err, iamerr.InvalidInput("Duplicate tag keys found. Please note that Tag keys are case insensitive."))
})
}
func IAMCreateUser_success(s *S3Conf) error {
testName := "IAMCreateUser_success"
return iamActionHandler(s, testName, func(client *iam.Client) error {
userName := newIAMUserName()
out, err := createIAMUser(client, &iam.CreateUserInput{
UserName: &userName,
Path: aws.String("/"),
Tags: []iamtypes.Tag{
{Key: aws.String("key"), Value: aws.String("value")},
},
})
if err != nil {
return err
}
checkErr := checkCreateUserOutput(out, userName, "/", true)
deleteErr := deleteIAMUser(client, userName)
if checkErr != nil {
return checkErr
}
return deleteErr
})
}
func IAMCreateUser_default_path(s *S3Conf) error {
testName := "IAMCreateUser_default_path"
return iamActionHandler(s, testName, func(client *iam.Client) error {
userName := newIAMUserName()
out, err := createIAMUser(client, &iam.CreateUserInput{UserName: &userName})
if err != nil {
return err
}
checkErr := checkCreateUserOutput(out, userName, "/", false)
deleteErr := deleteIAMUser(client, userName)
if checkErr != nil {
return checkErr
}
return deleteErr
})
}
func IAMCreateUser_invalid_path(s *S3Conf) error {
testName := "IAMCreateUser_invalid_path"
return iamActionHandler(s, testName, func(client *iam.Client) error {
_, err := createIAMUser(client, &iam.CreateUserInput{
UserName: aws.String(newIAMUserName()),
Path: aws.String("invalid"),
})
return checkIAMApiErr(err, iamerr.InvalidPath("path"))
})
}
func IAMCreateUser_long_path(s *S3Conf) error {
testName := "IAMCreateUser_long_path"
return iamActionHandler(s, testName, func(client *iam.Client) error {
_, err := createIAMUser(client, &iam.CreateUserInput{
UserName: aws.String(newIAMUserName()),
Path: aws.String("/" + strings.Repeat("a", 511) + "/"),
})
return checkIAMApiErr(err, iamerr.PathTooLong("path", 512))
})
}
func createIAMUser(client *iam.Client, input *iam.CreateUserInput) (*iam.CreateUserOutput, error) {
ctx, cancel := context.WithTimeout(context.Background(), shortTimeout)
defer cancel()
return client.CreateUser(ctx, input)
}
func deleteIAMUser(client *iam.Client, userName string) error {
ctx, cancel := context.WithTimeout(context.Background(), shortTimeout)
defer cancel()
_, err := client.DeleteUser(ctx, &iam.DeleteUserInput{UserName: &userName})
return err
}
// deleteIAMUserAndAccessKeys deletes all of the user's access keys before
// deleting the user, since DeleteUser rejects users with access keys still
// attached. Use this for test cleanup after a test has created access keys;
// use deleteIAMUser directly when the test itself manages key deletion.
func deleteIAMUserAndAccessKeys(client *iam.Client, userName string) error {
out, err := listIAMAccessKeys(client, &iam.ListAccessKeysInput{UserName: &userName})
if err != nil {
return err
}
for _, key := range out.AccessKeyMetadata {
if err := deleteIAMAccessKey(client, userName, aws.ToString(key.AccessKeyId)); err != nil {
return err
}
}
return deleteIAMUser(client, userName)
}
func newIAMUserName() string {
return "create-user-" + genRandString(16)
}
func checkCreateUserOutput(out *iam.CreateUserOutput, userName, path string, expectTags bool) error {
if out == nil || out.User == nil {
return fmt.Errorf("expected CreateUser output user")
}
user := out.User
if aws.ToString(user.Path) != path {
return fmt.Errorf("expected user path to be %q, instead got %q", path, aws.ToString(user.Path))
}
if aws.ToString(user.UserName) != userName {
return fmt.Errorf("expected user name to be %q, instead got %q", userName, aws.ToString(user.UserName))
}
expectedARN := "arn:aws:iam::000000000000:user" + path + userName
if aws.ToString(user.Arn) != expectedARN {
return fmt.Errorf("expected user ARN to be %q, instead got %q", expectedARN, aws.ToString(user.Arn))
}
if !integrationIAMUserIDPattern.MatchString(aws.ToString(user.UserId)) {
return fmt.Errorf("expected AWS IAM user id, instead got %q", aws.ToString(user.UserId))
}
if user.CreateDate == nil || user.CreateDate.IsZero() {
return fmt.Errorf("expected user create date")
}
if expectTags {
if len(user.Tags) != 1 || aws.ToString(user.Tags[0].Key) != "key" || aws.ToString(user.Tags[0].Value) != "value" {
return fmt.Errorf("expected user tag key=value, instead got %#v", user.Tags)
}
} else if len(user.Tags) != 0 {
return fmt.Errorf("expected no user tags, instead got %#v", user.Tags)
}
if requestID, ok := awsmiddleware.GetRequestIDMetadata(out.ResultMetadata); !ok || requestID == "" {
return fmt.Errorf("expected CreateUser response request id")
}
return nil
}