mirror of
https://github.com/versity/versitygw.git
synced 2026-08-29 04:06:56 +00:00
Nils LegerandGitHub
a780f3473a
* feat(azure): implement server-side copy with fallback Add server-side object copy for the Azure backend using StartCopyFromURL, with a fallback to download+reupload when server-side copy is unavailable. The copy logic lives in backend/azure/copy.go and handles metadata, tagging and object lock configurations. The copy-source SAS service version is configurable via the --copy-sas-version flag (AZ_COPY_SAS_VERSION) and defaults to the SDK version, so production is unchanged. Endpoints that lag the SDK's SAS version (e.g. Azurite) cannot verify a SAS signed with the newer version and can set an older one. On a metadata-COPY, the internal website-redirect key is dropped from the destination to match the download+reupload fallback. Testing: - Add CopyObject_cross_bucket_server_side_copy, which copies an object with data, user metadata, content-type and tags across two buckets and verifies all are preserved and an ETag is returned. - Configure the Azurite functional-test gateway with AZ_COPY_SAS_VERSION and let Azurite trust its self-signed test certificate (NODE_EXTRA_CA_CERTS) so it can fetch the copy source from its own HTTPS endpoint, ensuring CI exercises the real server-side copy path instead of always falling back. Signed-off-by: Nils Leger <nils.leger@getflip.com> * docs: update copyright year Signed-off-by: Nils Leger <nils.leger@getflip.com> * fix: always fallback to download+upload whenever there is an error building the server-side copy URL Signed-off-by: Nils Leger <nils.leger@getflip.com> --------- Signed-off-by: Nils Leger <nils.leger@getflip.com>
83 lines
2.4 KiB
Go
83 lines
2.4 KiB
Go
// Copyright 2023 Versity Software
|
|
// This file is licensed under the Apache License, Version 2.0
|
|
// (the "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing,
|
|
// software distributed under the License is distributed on an
|
|
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
// KIND, either express or implied. See the License for the
|
|
// specific language governing permissions and limitations
|
|
// under the License.
|
|
|
|
package gwcli
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/urfave/cli/v2"
|
|
"github.com/versity/versitygw/backend/azure"
|
|
)
|
|
|
|
var (
|
|
azAccount, azKey, azServiceURL, azSASToken, azCopySASVersion string
|
|
)
|
|
|
|
// AzureCommand returns the "azure" subcommand, common to all versitygw
|
|
// binaries.
|
|
func AzureCommand() *cli.Command {
|
|
return &cli.Command{
|
|
Name: "azure",
|
|
Usage: "azure blob storage backend",
|
|
Description: `direct translation from s3 objects to azure blobs`,
|
|
Action: runAzure,
|
|
Flags: []cli.Flag{
|
|
&cli.StringFlag{
|
|
Name: "account",
|
|
Usage: "azure account name",
|
|
EnvVars: []string{"AZ_ACCOUNT_NAME"},
|
|
Aliases: []string{"a"},
|
|
Destination: &azAccount,
|
|
},
|
|
&cli.StringFlag{
|
|
Name: "access-key",
|
|
Usage: "azure account key",
|
|
EnvVars: []string{"AZ_ACCESS_KEY"},
|
|
Aliases: []string{"k"},
|
|
Destination: &azKey,
|
|
},
|
|
&cli.StringFlag{
|
|
Name: "sas-token",
|
|
Usage: "azure blob storage SAS token",
|
|
EnvVars: []string{"AZ_SAS_TOKEN"},
|
|
Aliases: []string{"st"},
|
|
Destination: &azSASToken,
|
|
},
|
|
&cli.StringFlag{
|
|
Name: "url",
|
|
Usage: "azure service URL",
|
|
EnvVars: []string{"AZ_ENDPOINT"},
|
|
Aliases: []string{"u"},
|
|
Destination: &azServiceURL,
|
|
},
|
|
&cli.StringFlag{
|
|
Name: "copy-sas-version",
|
|
Usage: "service version used to sign the copy-source SAS for server-side copy (defaults to the SDK version; set this for endpoints that lag the SDK, e.g. Azurite)",
|
|
EnvVars: []string{"AZ_COPY_SAS_VERSION"},
|
|
Destination: &azCopySASVersion,
|
|
},
|
|
},
|
|
}
|
|
}
|
|
|
|
func runAzure(ctx *cli.Context) error {
|
|
be, err := azure.New(azAccount, azKey, azServiceURL, azSASToken, CopyObjectThreshold, azCopySASVersion)
|
|
if err != nil {
|
|
return fmt.Errorf("init azure: %w", err)
|
|
}
|
|
|
|
return RunGateway(ctx.Context, be)
|
|
}
|