diff --git a/src/disk.sh b/src/disk.sh index 53fe997..ac61ed3 100644 --- a/src/disk.sh +++ b/src/disk.sh @@ -154,8 +154,8 @@ normalizeSize() { local diskDesc="$2" local dir="$3" - local gb free space - local dataSize spare=1073741824 + local free dataSize + local spare=1073741824 if [[ "${diskSpace,,}" == "max" || "${diskSpace,,}" == "half" ]]; then @@ -168,12 +168,12 @@ normalizeSize() { fi (( free < spare )) && free="$spare" - gb=$(( free / 1073741825 )) + local gb=$(( free / 1073741825 )) diskSpace="${gb}G" fi - space="${diskSpace// /}" + local space="${diskSpace// /}" [ -z "$space" ] && space="256G" [ -z "${space//[0-9. ]}" ] && space="${space}G" space=$(echo "${space^^}" | sed 's/MB/M/g;s/GB/G/g;s/TB/T/g') @@ -573,13 +573,12 @@ addDisk () { local diskCache="$9" local fs dir used space - local diskExt diskFile - local dataSize missing + local diskExt dataSize local available currentSize - local previousExt previousFmt + local previousExt diskExt=$(fmt2ext "$diskFmt") - diskFile="$diskBase.$diskExt" + local diskFile="$diskBase.$diskExt" dir=$(dirname "$diskFile") [ ! -d "$dir" ] && return 0 @@ -598,9 +597,9 @@ addDisk () { if [ ! -s "$diskFile" ] ; then if [[ "${diskFmt,,}" != "raw" ]]; then - previousFmt="raw" + local previousFmt="raw" else - previousFmt="qcow2" + local previousFmt="qcow2" fi previousExt=$(fmt2ext "$previousFmt") @@ -641,18 +640,18 @@ addDisk () { currentSize=$(getSize "$diskFile") || exit 73 used=$(du -sB 1 "$diskFile" | cut -f1) available=$(df --output=avail -B 1 "$dir" | tail -n 1) - missing=$(( currentSize - used - available )) + local missing=$(( currentSize - used - available )) (( missing < 0 )) && missing=0 if (( missing > 0 )); then - local gb base msg + local gb base gb=$(formatBytes "$available") base=$(baseDir "$dir") missing=$(formatBytes "$missing") currentSize=$(formatBytes "$currentSize") - msg="The virtual size of the ${diskDesc,,} is $currentSize" + local msg="The virtual size of the ${diskDesc,,} is $currentSize" if [ -n "$used" ] && [[ "$used" != "0" ]]; then used=$(formatBytes "$used") diff --git a/src/network.sh b/src/network.sh index ba0071f..15e5cf8 100644 --- a/src/network.sh +++ b/src/network.sh @@ -84,8 +84,7 @@ getMTU() { minMTU() { - local mtu="" - local min="" + local mtu min="" for mtu in "$@"; do [[ -z "$mtu" || "$mtu" == "0" ]] && continue @@ -124,7 +123,7 @@ gatewayMAC() { maskToCIDR() { local mask="$1" - local prefix="" + local prefix if ! command -v ipcalc > /dev/null 2>&1; then error "Required command 'ipcalc' is not installed!" @@ -154,7 +153,7 @@ maskToCIDR() { networkCIDR() { local ip="$1" - local network="" + local network network=$(ipcalc -n -b "$ip/$MASK" 2>/dev/null | awk ' /^Network:/ { @@ -215,8 +214,7 @@ detectAddresses() { IP6="" if [ -f /proc/net/if_inet6 ] && [[ "$(cat /proc/sys/net/ipv6/conf/all/disable_ipv6 2>/dev/null)" != "1" ]]; then - local rc=0 - { IP6=$(ip -6 addr show dev "$DEV" scope global up); rc=$?; } 2>/dev/null || : + { IP6=$(ip -6 addr show dev "$DEV" scope global up); local rc=$?; } 2>/dev/null || : (( rc != 0 )) && IP6="" [ -n "$IP6" ] && IP6=$(echo "$IP6" | sed -e's/^.*inet6 \([^ ]*\)\/.*$/\1/;t;d' | head -n 1) fi @@ -226,7 +224,7 @@ detectAddresses() { detectAdapter() { - local result="" + local result NIC="" BUS="" @@ -252,7 +250,7 @@ detectAdapter() { containerID() { - local id="" + local id id=$(hostname -s 2>/dev/null || true) @@ -286,7 +284,7 @@ disableIPv6() { subnetInUse() { local subnet="$1" - local broader="" narrower="" routes="" + local broader narrower routes if ! broader=$(ip -4 route show table all match "$subnet" 2>/dev/null); then error "Failed to inspect existing routes for subnet $subnet." @@ -324,15 +322,14 @@ guestIP() { natGuestIP() { local ip="$1" - local start="" guest="" subnet="" - local second="" third="" rc="" + local guest subnet second third third=$(cut -d. -f3 <<< "$ip") if [[ "$ip" == "172.30."* ]]; then - start="31" + local start="31" else - start="30" + local start="30" fi for (( second=start; second<=254; second++ )); do @@ -342,7 +339,7 @@ natGuestIP() { if subnetInUse "$subnet"; then continue else - rc=$? + local rc=$? (( rc == 1 )) || return 1 fi @@ -357,7 +354,7 @@ natGuestIP() { if subnetInUse "$subnet"; then continue else - rc=$? + local rc=$? (( rc == 1 )) || return 1 fi @@ -411,7 +408,7 @@ configureDNS() { local host="$4" local mask="$5" local gateway="$6" - local arguments="$DNSMASQ_OPTS" rc + local arguments="$DNSMASQ_OPTS" if ! echo "$gateway" > /run/shm/qemu.gw; then error "Failed to write gateway file." @@ -478,7 +475,7 @@ configureDNS() { arguments=$(echo "$arguments" | sed 's/\t/ /g' | tr -s ' ' | sed 's/^ *//') enabled "$DEBUG" && printf "Dnsmasq arguments:\n\n%s\n\n" "${arguments// -/$'\n-'}" - { $DNSMASQ ${arguments:+ $arguments}; rc=$?; } || : + { $DNSMASQ ${arguments:+ $arguments}; local rc=$?; } || : if (( rc != 0 )); then @@ -501,9 +498,9 @@ configureDNS() { getHostPorts() { - local port="" ports="" - local num="" mode="${1:-tcp}" local list="${HOST_PORTS// /}," + local port ports="" + local mode="${1:-tcp}" for port in ${list//,/ }; do @@ -512,14 +509,14 @@ getHostPorts() { case "$mode" in "tcp" ) [[ "$port" == *"/udp" ]] && continue - num="${port%/tcp}" + local num="${port%/tcp}" ;; "all" ) if [[ "$port" == *"/udp" ]]; then - num="${port%/udp}" + local num="${port%/udp}" [ -n "$num" ] && ports+="$num/udp," else - num="${port%/tcp}" + local num="${port%/tcp}" [ -n "$num" ] && ports+="$num/tcp," fi continue @@ -545,16 +542,15 @@ getUserPorts() { local defaults="22/tcp,5000/tcp,5001/tcp" local list="$defaults,${USER_PORTS// /}," - local num="" ports="" proto="" - local userport="" hostport="" + local ports="" + local userport hostport exclude - local exclude="" exclude=$(getHostPorts "all") for userport in ${list//,/ }; do - proto="tcp" - num="$userport" + local proto="tcp" + local num="$userport" if [[ "$userport" == *"/udp" ]]; then proto="udp" @@ -593,7 +589,7 @@ getUserPorts() { getSlirp() { local ip="$1" - local args="" list="" + local args="" list list=$(getUserPorts) @@ -617,8 +613,8 @@ getSlirp() { getPasst() { - local args="" list="" port="" - local num="" tcp="" udp="" + local list port + local tcp="" udp="" args="" local bind="$UPLINK" list=$(getUserPorts) @@ -629,12 +625,12 @@ getPasst() { if [[ "$port" == *"/udp" ]]; then - num="${port%/udp}" + local num="${port%/udp}" [ -n "$num" ] && udp+="$num," elif [[ "$port" == *"/tcp" ]]; then - num="${port%/tcp}" + local num="${port%/tcp}" [ -n "$num" ] && tcp+="$num," else @@ -665,8 +661,7 @@ getPasst() { configureVTAP() { - local msg="" - local rc + local msg enabled "$DEBUG" && echo "Configuring MACVTAP networking..." @@ -678,7 +673,7 @@ configureVTAP() { fi # Create a macvtap network for the VM guest - { msg=$(ip link add link "$DEV" name "$TAP" address "$MAC" type macvtap mode bridge 2>&1); rc=$?; } || : + { msg=$(ip link add link "$DEV" name "$TAP" address "$MAC" type macvtap mode bridge 2>&1); local rc=$?; } || : case "$msg" in "RTNETLINK answers: File exists"* ) @@ -711,11 +706,11 @@ configureVTAP() { sleep 2 done - local TAP_NR TAP_PATH MAJOR MINOR + local TAP_NR MAJOR MINOR TAP_NR=$(/dev/null 2>&1; then - local rc=0 rm -f "$log" PASST_OPTS="${PASST_OPTS/ -q/}" - { "$PASST" ${PASST_OPTS:+$PASST_OPTS}; rc=$?; } || : + { "$PASST" ${PASST_OPTS:+$PASST_OPTS}; local rc=$?; } || : if (( rc != 0 )); then [ -f "$log" ] && [ -s "$log" ] && cat "$log" @@ -889,10 +883,10 @@ configurePasst() { createBridge() { local gateway="$1" - local rc msg="" + local msg # Create a bridge with a static IP for the VM guest - { msg=$(ip link add dev "$BRIDGE" type bridge 2>&1); rc=$?; } || : + { msg=$(ip link add dev "$BRIDGE" type bridge 2>&1); local rc=$?; } || : if (( rc != 0 )); then enabled "$ROOTLESS" && ! enabled "$DEBUG" && return 1 @@ -930,10 +924,10 @@ createBridge() { createTap() { local tuntap="$1" - local rc msg="" + local msg # Set tap to the bridge created - { msg=$(ip tuntap add dev "$TAP" mode tap 2>&1); rc=$?; } || : + { msg=$(ip tuntap add dev "$TAP" mode tap 2>&1); local rc=$?; } || : if (( rc != 0 )); then enabled "$ROOTLESS" && ! enabled "$DEBUG" && return 1 @@ -976,7 +970,7 @@ hasTable() { getTablesBackend() { - local version="" + local version version=$(iptables --version 2>/dev/null || true) case "$version" in @@ -989,7 +983,7 @@ getTablesBackend() { setTables() { local mode="$1" - local path="" + local path path=$(command -v "iptables-$mode" 2>/dev/null || true) [ -z "$path" ] && return 1 @@ -1003,7 +997,7 @@ showRules() { local chain="$2" local label="$3" local rule_tag="$4" - local rules="" + local rules local own_rule="--comment[[:space:]]+\"?$rule_tag\"?([[:space:]]|\$)" enabled "$DEBUG" || return 0 @@ -1022,7 +1016,7 @@ showRules() { checkExistingTables() { - local msg="" rules="" conflicts="" + local rules conflicts local rule_tag="QEMU_DNAT" local own_rule="--comment[[:space:]]+\"?$rule_tag\"?([[:space:]]|\$)" @@ -1040,7 +1034,7 @@ checkExistingTables() { <<< "$rules" || true) if [ -n "$conflicts" ]; then - msg="your existing NAT rules may take precedence over VM port forwarding" + local msg="your existing NAT rules may take precedence over VM port forwarding" if enabled "$DEBUG"; then warn "${msg}." @@ -1060,7 +1054,7 @@ checkExistingTables() { <<< "$rules" || true) if [ -n "$conflicts" ]; then - msg="your existing firewall rules may block traffic forwarded to or from the VM" + local msg="your existing firewall rules may block traffic forwarded to or from the VM" if enabled "$DEBUG"; then warn "${msg}." @@ -1088,13 +1082,13 @@ runTableRule() { local silent="$1" local result="$2" - local rc msg="" + local msg shift 2 printf -v "$result" '%s' "" - { msg=$("$@" 2>&1); rc=$?; } || : + { msg=$("$@" 2>&1); local rc=$?; } || : (( rc == 0 )) && return 0 printf -v "$result" '%s' "$msg" @@ -1154,8 +1148,8 @@ applyTables() { local ip="$1" local subnet="$2" local silent="${3:-N}" - local exclude="" port="" - local table_error="" + local exclude port + local table_error local dnat_chain="QEMU_DNAT" local rule_tag="$dnat_chain" @@ -1283,8 +1277,8 @@ applyTables() { clearTables() { - local table="" line="" chain="" - local rules="" remaining="" message="" + local line + local rules remaining message local dnat_chain="QEMU_DNAT" local rule_tag="$dnat_chain" local own_rule="--comment[[:space:]]+\"?$rule_tag\"?([[:space:]]|\$)" @@ -1309,15 +1303,15 @@ clearTables() { while IFS= read -r line; do case "$line" in - \*nat ) table="nat" ;; - \*filter ) table="filter" ;; - \*mangle ) table="mangle" ;; - \*raw ) table="raw" ;; + \*nat ) local table="nat" ;; + \*filter ) local table="filter" ;; + \*mangle ) local table="mangle" ;; + \*raw ) local table="raw" ;; esac if [[ "$line" == -A* ]] && [[ "$line" =~ $own_rule ]]; then - chain="${line#-A }" + local chain="${line#-A }" chain="${chain%% *}" # Rules inside this chain are removed together by the flush below. @@ -1383,7 +1377,7 @@ clearTables() { hasTaggedRules() { local save="$1" - local rules="" + local rules local dnat_chain="QEMU_DNAT" local rule_tag="$dnat_chain" local own_rule="--comment[[:space:]]+\"?$rule_tag\"?([[:space:]]|\$)" @@ -1405,9 +1399,8 @@ configureTables() { local ip="$1" local subnet="$2" - local preferred="" - local alternate="" - local alternate_save="" + local preferred + local alternate_save local preferred_clean="N" local alternate_dirty="N" @@ -1418,8 +1411,8 @@ configureTables() { } case "$preferred" in - "nft" ) alternate="legacy" ;; - "legacy" ) alternate="nft" ;; + "nft" ) local alternate="legacy" ;; + "legacy" ) local alternate="nft" ;; * ) enabled "$ROOTLESS" && ! enabled "$DEBUG" && return 1 warn "unsupported IP tables backend: $preferred" @@ -1608,7 +1601,7 @@ configureTables() { configureNAT() { local tuntap="TUN device is missing. $ADD_ERR --device /dev/net/tun" - local rc ip subnet msg="" forwarding="" + local ip subnet forwarding="" enabled "$DEBUG" && echo "Configuring NAT networking..." @@ -1616,7 +1609,8 @@ configureNAT() { if [ ! -c /dev/net/tun ]; then [ ! -d /dev/net ] && mkdir -m 755 /dev/net > /dev/null 2>&1 || : - { msg=$(mknod /dev/net/tun c 10 200 2>&1); rc=$?; } || : + local msg + { msg=$(mknod /dev/net/tun c 10 200 2>&1); local rc=$?; } || : if (( rc == 0 )); then chmod 666 /dev/net/tun @@ -1635,7 +1629,7 @@ configureNAT() { forwarding=$(< /proc/sys/net/ipv4/ip_forward) if [[ "$forwarding" != "1" ]]; then - { sysctl -w net.ipv4.ip_forward=1 > /dev/null 2>&1; rc=$?; } || : + { sysctl -w net.ipv4.ip_forward=1 > /dev/null 2>&1; local rc=$?; } || : forwarding="" [ -r /proc/sys/net/ipv4/ip_forward ] && @@ -1661,7 +1655,7 @@ configureNAT() { error "VM subnet $subnet conflicts with an existing route inside the container." return 1 else - rc=$? + local rc=$? (( rc == 1 )) || return 1 fi @@ -1678,7 +1672,7 @@ configureNAT() { NET_OPTS="-netdev tap,id=hostnet0,ifname=$TAP" if [ -c /dev/vhost-net ]; then - { exec 40>>/dev/vhost-net; rc=$?; } 2>/dev/null || : + { exec 40>>/dev/vhost-net; local rc=$?; } 2>/dev/null || : (( rc == 0 )) && NET_OPTS+=",vhost=on,vhostfd=40" fi @@ -1740,7 +1734,7 @@ closeNetwork() { checkOS() { local iface="macvlan" - local os="" kernel="" + local os="" kernel kernel=$(uname -a) @@ -1891,14 +1885,12 @@ configureMTU() { configureMAC() { - local container="" - local file="" - + local container container=$(containerID) if [ -z "$MAC" ]; then - file="$STORAGE/dsm.mac" + local file="$STORAGE/dsm.mac" if [ -s "$file" ]; then if ! MAC=$(readFile "$file"); then @@ -1941,7 +1933,7 @@ configureMAC() { showHostInfo() { - local mtu="" host="" uplink="" prefix="" + local mtu host uplink prefix prefix=$(ip -4 -o address show dev "$DEV" scope global 2>/dev/null | awk -v ip="$UPLINK" ' diff --git a/src/power.sh b/src/power.sh index 99ce645..78dcd61 100644 --- a/src/power.sh +++ b/src/power.sh @@ -92,7 +92,7 @@ qemuPidFile() { waitQemuExit() { local timeout="${1:-10}" - local file="" + local file qemuPidFile file waitPidFile "$file" "$timeout" @@ -101,7 +101,7 @@ waitQemuExit() { waitQemuPid() { local -n _pid="$1" - local cnt=0 value="" + local cnt=0 value while ! readQemuPid value; do sleep 0.02 @@ -116,7 +116,7 @@ waitQemuPid() { forceKillQemu() { local reason="$1" - local pid="" display + local pid display ! readQemuPid pid && return 0 ! isAlive "$pid" && return 0 @@ -145,7 +145,7 @@ cleanupHelpers() { startConsole() { local output="${1:-/dev/tty}" - local cnt=0 pid="" + local cnt=0 rm -f -- "$CONSOLE_SOCKET" "$CONSOLE_PID" @@ -159,7 +159,7 @@ startConsole() { exec nc -lU "$CONSOLE_SOCKET" "$output" ) & - pid=$! + local pid="$!" echo "$pid" > "$CONSOLE_PID" while [ ! -S "$CONSOLE_SOCKET" ]; do @@ -246,14 +246,14 @@ finish() { sendGuestShutdown() { local pid="$1" - local response url + local response # Don't send the powerdown signal because vDSM ignores ACPI signals # nc -q 1 -w 1 -U "$QEMU_DIR/monitor.sock" &> /dev/null <<<'system_powerdown' || : # Send shutdown command to guest agent via serial port API_TIMEOUT=$(strip "$API_TIMEOUT") - url="http://localhost/read?command=$API_CMD&timeout=$API_TIMEOUT" + local url="http://localhost/read?command=$API_CMD&timeout=$API_TIMEOUT" response=$(curl --unix-socket "$HOST_API_SOCKET" -sk -m "$(( API_TIMEOUT+2 ))" -S "$url" 2>&1) if [[ "$response" =~ "\"success\"" ]]; then @@ -338,7 +338,7 @@ waitForShutdown() { graceful_shutdown() { local sig="$1" - local pid="" code=0 + local pid code [[ $BASHPID != "$TRAP_PID" ]] && return diff --git a/src/print.sh b/src/print.sh index 77c0d47..1b9c30e 100644 --- a/src/print.sh +++ b/src/print.sh @@ -37,9 +37,7 @@ exitIfShuttingDown() { queryGuest() { - local rc - - { json=$(curl --unix-socket "$socket" -m 20 -sk "$url"); rc=$?; } || : + { json=$(curl --unix-socket "$socket" -m 20 -sk "$url"); local rc=$?; } || : exitIfShuttingDown @@ -55,9 +53,8 @@ readJsonField() { local query="$1" local result - local rc - { result=$(jq -r "$query" <<< "$json"); rc=$?; } || : + { result=$(jq -r "$query" <<< "$json"); local rc=$?; } || : if (( rc != 0 )); then error "$jq_err $rc ( $json )" @@ -75,12 +72,12 @@ readJsonField() { readGuestStatus() { - local result msg rc + local result msg result=$(readJsonField '.status') || return 1 if [[ "$result" != "success" ]]; then - { msg=$(jq -r '.message // empty' <<< "$json"); rc=$?; } || : + { msg=$(jq -r '.message // empty' <<< "$json"); local rc=$?; } || : if (( rc != 0 )); then error "$jq_err $rc ( $json )" @@ -158,12 +155,12 @@ checkAddressConflict() { writeDhcpPage() { - local title body script html + local html msg="http://$location" - title="Virtual DSM" - body="The location of DSM is http://$location" - script="" + local title="Virtual DSM" + local body="The location of DSM is http://$location" + local script="" html=$(<"$template") html="${html/\[1\]/$title}" @@ -180,11 +177,11 @@ writeDhcpPage() { buildStaticMessage() { - local nic ip port + local nic ip nic=$(<"$driver") ip=$(<"$address") - port="${location##*:}" + local port="${location##*:}" if [[ "${nic,,}" != "macvlan" ]]; then msg="port $port" diff --git a/src/reset.sh b/src/reset.sh index c490868..3769d0b 100644 --- a/src/reset.sh +++ b/src/reset.sh @@ -41,7 +41,7 @@ detectEngine() { detectRootless() { - local uid_map="" + local uid_map uid_map=$(awk '{$1=$1; print}' /proc/self/uid_map 2>/dev/null || true) @@ -58,8 +58,6 @@ checkPrivileged() { local cap_bnd local last_cap - local max_cap - # Get the capability bounding set cap_bnd=$(grep '^CapBnd:' /proc/$$/status | awk '{print $2}') cap_bnd=$(printf "%d" "0x${cap_bnd}") @@ -68,7 +66,7 @@ checkPrivileged() { last_cap=$(cat /proc/sys/kernel/cap_last_cap) # Calculate the maximum capability value - max_cap=$(((1 << (last_cap + 1)) - 1)) + local max_cap=$(((1 << (last_cap + 1)) - 1)) if [ "$cap_bnd" -eq "$max_cap" ]; then PRIVILEGED="Y" @@ -144,9 +142,7 @@ finiteMemoryLimit() { local limit="$1" local sentinel="4611686018427387904" - local i=0 - local left="" - local right="" + local i [[ "$limit" =~ ^[0-9]+$ ]] || return 1 @@ -154,8 +150,8 @@ finiteMemoryLimit() { (( ${#limit} > ${#sentinel} )) && return 1 for (( i=0; i<${#sentinel}; i++ )); do - left="${limit:i:1}" - right="${sentinel:i:1}" + local left="${limit:i:1}" + local right="${sentinel:i:1}" (( left < right )) && return 0 (( left > right )) && return 1 @@ -166,11 +162,8 @@ finiteMemoryLimit() { getMemoryInfo() { - local host_total="" - local host_avail="" - local limit="" - local current="" - local available="" + local limit="" current="" + local host_total host_avail host_total=$(free -b | awk '/^Mem:/ {print $2; exit}') host_avail=$(free -b | awk '/^Mem:/ {print $7; exit}') @@ -189,7 +182,7 @@ getMemoryInfo() { if finiteMemoryLimit "$limit" && [[ "$current" =~ ^[0-9]+$ ]]; then (( limit < RAM_TOTAL )) && RAM_TOTAL="$limit" - available=$(( limit - current )) + local available=$(( limit - current )) (( available < 0 )) && available=0 (( available < RAM_AVAIL )) && RAM_AVAIL="$available" fi diff --git a/src/utils.sh b/src/utils.sh index 6196f55..3e6401c 100644 --- a/src/utils.sh +++ b/src/utils.sh @@ -133,8 +133,7 @@ waitPid() { waitPidFile() { - local i=0 - local pid="" + local i=0 pid local file="$1" local timeout="${2:-10}" @@ -201,7 +200,7 @@ fKill() { sKill() { - local pid="" + local pid local file="$1" [ ! -s "$file" ] && return 0 @@ -381,8 +380,7 @@ restoreState() { escape () { - local s - s=${1//&/\&} + local s=${1//&/\&} s=${s///\>} s=${s//'"'/\"} @@ -408,7 +406,7 @@ html() { local title local body - local script + local script="${2:-}" local footer title=$(escape "$APP") @@ -420,8 +418,6 @@ html() { body="

${body/.../}

" fi - [ -n "${2:-}" ] && script="$2" || script="" - local HTML HTML=$(<"$TEMPLATE") HTML="${HTML/\[1\]/$title}" @@ -478,9 +474,9 @@ getCountry() { local url=$1 local query=$2 - local rc json result + local json result - { json=$(curl -m 5 -H "Accept: application/json" -sfk "$url"); rc=$?; } || : + { json=$(curl -m 5 -H "Accept: application/json" -sfk "$url"); local rc=$?; } || : (( rc != 0 )) && return 0 { result=$(echo "$json" | jq -r "$query" 2> /dev/null); rc=$?; } || :