Windows: fix untranslated Repair EFI Boot Loader menu item (#1929)

The main menu is localized by looking up command IDs in the language
dictionary from 40001 upwards, stopping at the first ID without an
entry. An ID has an entry when its name in the embedded Resource.h
matches a string key.

40069 was defined as IDM_MOUNIT_NO_CACHE, while its string key is
IDM_MOUNT_NO_CACHE, so the loop stopped there. As a result,
IDM_REPAIR_EFI_BOOT_LOADER (40070) was never localized and appeared
in English in every language, although all translations include it.

Rename the define to match its string key. The Mount button menu item
that uses this ID already takes its text from GetString and is
unchanged.
This commit is contained in:
amail80
2026-10-18 18:03:14 +09:00
committed by GitHub
parent e35a80fe29
commit 4b114b4de0
2 changed files with 4 additions and 4 deletions
+3 -3
View File
@@ -890,7 +890,7 @@ static HMENU CreateMountNoCacheDropdownMenu()
HMENU hmenu = CreatePopupMenu();
// add menu items
AppendMenu(hmenu, MF_STRING, IDM_MOUNIT_NO_CACHE, GetString("IDM_MOUNT_NO_CACHE"));
AppendMenu(hmenu, MF_STRING, IDM_MOUNT_NO_CACHE, GetString("IDM_MOUNT_NO_CACHE"));
return hmenu;
}
@@ -9348,9 +9348,9 @@ BOOL CALLBACK MainDialogProc (HWND hwndDlg, UINT uMsg, WPARAM wParam, LPARAM lPa
return 1;
}
if ((lw == IDOK || lw == IDM_MOUNT_VOLUME || lw == IDM_MOUNT_VOLUME_OPTIONS || lw == IDM_MOUNIT_NO_CACHE))
if ((lw == IDOK || lw == IDM_MOUNT_VOLUME || lw == IDM_MOUNT_VOLUME_OPTIONS || lw == IDM_MOUNT_NO_CACHE))
{
MountSelectedVolume (hwndDlg, lw == IDM_MOUNT_VOLUME_OPTIONS, lw == IDM_MOUNIT_NO_CACHE);
MountSelectedVolume (hwndDlg, lw == IDM_MOUNT_VOLUME_OPTIONS, lw == IDM_MOUNT_NO_CACHE);
return 1;
}
+1 -1
View File
@@ -274,7 +274,7 @@
#define IDM_DEFAULT_MOUNT_PARAMETERS 40066
#define IDM_DECRYPT_NONSYS_VOL 40067
#define IDM_VERIFY_RESCUE_DISK_ISO 40068
#define IDM_MOUNIT_NO_CACHE 40069
#define IDM_MOUNT_NO_CACHE 40069
#define IDM_REPAIR_EFI_BOOT_LOADER 40070
// Next default values for new objects