Release 1.14

Nagle's algorithm probably serves no purpose with whois queries
often being tiny.

.github/images/centos.Dockerfile

@@ -2,8 +2,8 @@ ARG image=centos/centos:latest
 FROM quay.io/$image
 
 # Install dependencies
-RUN yum update -y
-RUN yum install -y autoconf automake gcc libtool make diffutils file gzip
+RUN if command -v yum > /dev/null; then dnf=yum; fi; ${dnf:-dnf} update -y
+RUN if command -v yum > /dev/null; then dnf=yum; fi; ${dnf:-dnf} install -y autoconf automake gcc libtool make diffutils file gzip
 
 # Add source code
 ADD . /src

.github/workflows/build-container.yml

@@ -48,6 +48,7 @@ jobs:
             type=sha
 
       - name: Login to GitHub Container Registry
+        if: github.repository_owner == 'bgp'
         uses: docker/login-action@v3
         with:
           registry: ghcr.io
@@ -60,5 +61,5 @@ jobs:
           file: .github/images/alpine:3.Dockerfile
           context: .
           platforms: linux/amd64,linux/arm64
-          push: true
+          push: ${{ github.repository_owner == 'bgp' }}
           tags: ${{ steps.meta.outputs.tags }}

CHANGES

@@ -1,5 +1,9 @@
+1.14 (2024-05-14)
+    - Small performance gain: set TCP_NODELAY on the socket
+
 1.13 (2024-05-01)
     - Fixed a bug for Mac users by removing sx_maxsockbuf()
+    - Fixed a comma printing bug in IOS XR as-path-set output
 
 1.12 (2024-02-12)
     - Fix a bug in the mikrotik printer

Makefile.am

@@ -36,4 +36,8 @@ maintainer-clean-local:
 check:
 	./bgpq4 -v
 	@echo
-	./bgpq4 -6 AS15562:AS-SNIJDERS | grep 2001:67c:208c::
+	-if [ -s /etc/resolv.conf ]; then \
+		./bgpq4 -ddd -6 AS15562:AS-SNIJDERS ; \
+	else \
+		echo "No or empty /etc/resolv.conf, skipping online test"; \
+	fi

VERSION

@@ -1 +1 @@
-1.13
+1.14

expander.c

@@ -29,6 +29,7 @@
 #include <sys/types.h>
 #include <sys/socket.h>
 #include <sys/select.h>
+#include <netinet/tcp.h>
 
 #include <assert.h>
 #include <ctype.h>
@@ -1034,7 +1035,7 @@ bgpq_expand(struct bgpq_expander *b)
 	struct addrinfo 	 hints, *res = NULL, *rp;
 	struct linger		 sl;
 	struct asn_entry	*asne;
-	int			 fd = -1, err, ret, aquery = 0;
+	int			 fd = -1, err, ret, aquery = 0, nodelay = 1;
 	int			 slen;
 
 	sl.l_onoff = 1;
@@ -1075,6 +1076,11 @@ bgpq_expand(struct bgpq_expander *b)
 			continue;
 		}
 
+		if (setsockopt(fd, IPPROTO_TCP, TCP_NODELAY, &nodelay,
+		    sizeof(nodelay)) == -1)
+			SX_DEBUG(debug_expander, "Unable to set TCP_NODELAY on"
+			    " socket: %s\n", strerror(errno));
+
 		break;
 	}