apply more suggestions from code review

This commit is contained in:
Sebastian Stenzel
2025-11-04 22:07:05 +01:00
parent 0bdcb2b3be
commit 6b7324723e
2 changed files with 2 additions and 2 deletions

View File

@@ -85,9 +85,9 @@ public class UpdateChecker extends ScheduledService<UpdateInfo<?>> {
protected void succeeded() {
var updateInfo = getValue();
super.succeeded(); // this will nil the value property!
lastSuccessfulUpdateCheck.set(Instant.now());
if (updateInfo != null) {
LOG.info("Current version: {}, latest version: {}", getCurrentVersion(), updateInfo.version());
lastSuccessfulUpdateCheck.set(Instant.now());
}
}

View File

@@ -60,7 +60,7 @@ public class UpdatesPreferencesController implements FxController {
public CheckBox checkForUpdatesCheckbox;
@Inject
UpdatesPreferencesController(Application application, Environment environment, ResourceBundle resourceBundle, Settings settings, UpdateChecker updateChecker, FallbackUpdateMechanism fallbackUpdateMechanism) {
UpdatesPreferencesController(Application application, Environment environment, ResourceBundle resourceBundle, Settings settings, UpdateChecker updateChecker) {
this.application = application;
this.environment = environment;
this.resourceBundle = resourceBundle;