mirrors/git-pages
1
0
Fork 0
mirror of https://codeberg.org/git-pages/git-pages.git synced 2026-07-19 16:02:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

[security] Actually check result of appendNewAuditRecord.

Browse Source 
Before this commit, if `backend.AppendAuditLog` failed, the request
would proceed anyway. This is contrary to the explicit contract and
design intent.

If Go had `#[must_use]`, this would not have happened :/

V12-Ref: F-77170
This commit is contained in:
Catherine
2026-05-30 14:31:55 +00:00
parent 0cd96a2b0b
commit 16505f6054
1 changed files with 28 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/audit.go
+28 -15
View File
@@ -363,65 +363,78 @@ func notifyAudit(ctx context.Context, id AuditID) {
func (audited *auditedBackend) CommitManifest(
ctx context.Context, name string, manifest *Manifest, opts ModifyManifestOptions,
) (err error) {
) error {
domain, project, ok := strings.Cut(name, "/")
if !ok {
panic("malformed manifest name")
}
audited.appendNewAuditRecord(ctx, &AuditRecord{
if err := audited.appendNewAuditRecord(ctx, &AuditRecord{
Event: AuditEvent_CommitManifest.Enum(),
Domain: proto.String(domain),
Project: proto.String(project),
Manifest: manifest,
})
}); err != nil {
return err
}
return audited.Backend.CommitManifest(ctx, name, manifest, opts)
}
func (audited *auditedBackend) DeleteManifest(
ctx context.Context, name string, opts ModifyManifestOptions,
) (err error) {
) error {
domain, project, ok := strings.Cut(name, "/")
if !ok {
panic("malformed manifest name")
}
audited.appendNewAuditRecord(ctx, &AuditRecord{
if err := audited.appendNewAuditRecord(ctx, &AuditRecord{
Event: AuditEvent_DeleteManifest.Enum(),
Domain: proto.String(domain),
Project: proto.String(project),
})
}); err != nil {
return err
}
return audited.Backend.DeleteManifest(ctx, name, opts)
}
func (audited *auditedBackend) ExpireManifest(ctx context.Context, name string) (err error) {
func (audited *auditedBackend) ExpireManifest(ctx context.Context, name string) error {
domain, project, ok := strings.Cut(name, "/")
if !ok {
panic("malformed manifest name")
}
audited.appendNewAuditRecord(ctx, &AuditRecord{
if err := audited.appendNewAuditRecord(ctx, &AuditRecord{
Event: AuditEvent_ExpireManifest.Enum(),
Domain: proto.String(domain),
Project: proto.String(project),
})
}); err != nil {
return err
}
return audited.Backend.ExpireManifest(ctx, name)
}
func (audited *auditedBackend) FreezeDomain(ctx context.Context, domain string) (err error) {
audited.appendNewAuditRecord(ctx, &AuditRecord{
func (audited *auditedBackend) FreezeDomain(ctx context.Context, domain string) error {
if err := audited.appendNewAuditRecord(ctx, &AuditRecord{
Event: AuditEvent_FreezeDomain.Enum(),
Domain: proto.String(domain),
})
}); err != nil {
return err
}
return audited.Backend.FreezeDomain(ctx, domain)
}
func (audited *auditedBackend) UnfreezeDomain(ctx context.Context, domain string) (err error) {
audited.appendNewAuditRecord(ctx, &AuditRecord{
func (audited *auditedBackend) UnfreezeDomain(ctx context.Context, domain string) error {
if err := audited.appendNewAuditRecord(ctx, &AuditRecord{
Event: AuditEvent_UnfreezeDomain.Enum(),
Domain: proto.String(domain),
})
}); err != nil {
return err
}
return audited.Backend.UnfreezeDomain(ctx, domain)
}