mirror of
https://codeberg.org/git-pages/git-pages.git
synced 2026-05-26 00:50:23 +00:00
Revert "Remove redundant bounds check from ExtractTar. NFCI"
This reverts commit 485cd4b9b1.
It wasn't redundant.
This commit is contained in:
@@ -18,7 +18,12 @@ import (
|
||||
var ErrArchiveTooLarge = errors.New("archive too large")
|
||||
|
||||
func ExtractTar(reader io.Reader) (*Manifest, error) {
|
||||
archive := tar.NewReader(reader)
|
||||
// If the tar stream is itself compressed, both the outer and the inner bounds checks
|
||||
// are load-bearing.
|
||||
boundedReader := ReadAtMost(reader, int64(config.Limits.MaxSiteSize.Bytes()),
|
||||
fmt.Errorf("%w: %s limit exceeded", ErrArchiveTooLarge, config.Limits.MaxSiteSize.HR()))
|
||||
|
||||
archive := tar.NewReader(boundedReader)
|
||||
|
||||
manifest := Manifest{
|
||||
Contents: map[string]*Entry{
|
||||
|
||||
Reference in New Issue
Block a user