mirror of
https://github.com/google/nomulus
synced 2026-01-06 21:47:31 +00:00
Don't include "Command" suffix in WHOIS metrics command name label
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=152414152
This commit is contained in:
@@ -112,7 +112,9 @@ public class WhoisMetrics {
|
||||
private Clock clock = null;
|
||||
|
||||
public Builder setCommand(WhoisCommand command) {
|
||||
return setCommandName(command.getClass().getSimpleName());
|
||||
// All WHOIS command class names share the "Command" suffix, so strip it out in order to
|
||||
// have shorter labels.
|
||||
return setCommandName(command.getClass().getSimpleName().replaceFirst("Command$", ""));
|
||||
}
|
||||
|
||||
public abstract Builder setCommandName(String commandName);
|
||||
|
||||
@@ -352,7 +352,7 @@ public class WhoisHttpServerTest {
|
||||
server.run();
|
||||
WhoisMetric expected =
|
||||
WhoisMetric.builderForRequest(clock)
|
||||
.setCommandName("NameserverLookupByHostCommand")
|
||||
.setCommandName("NameserverLookupByHost")
|
||||
.setNumResults(1)
|
||||
.setStatus(SC_OK)
|
||||
.build();
|
||||
|
||||
@@ -456,7 +456,7 @@ public class WhoisServerTest {
|
||||
server.run();
|
||||
WhoisMetric expected =
|
||||
WhoisMetric.builderForRequest(clock)
|
||||
.setCommandName("NameserverLookupByIpCommand")
|
||||
.setCommandName("NameserverLookupByIp")
|
||||
.setNumResults(2)
|
||||
.setStatus(SC_OK)
|
||||
.build();
|
||||
@@ -470,7 +470,7 @@ public class WhoisServerTest {
|
||||
server.run();
|
||||
WhoisMetric expected =
|
||||
WhoisMetric.builderForRequest(clock)
|
||||
.setCommandName("DomainLookupCommand")
|
||||
.setCommandName("DomainLookup")
|
||||
.setNumResults(0)
|
||||
.setStatus(SC_NOT_FOUND)
|
||||
.build();
|
||||
|
||||
Reference in New Issue
Block a user