mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-07-08 09:06:58 +00:00
Code Issues Releases Wiki Activity

Forbid negative premium prices (#3108)

Browse Source 
This hasn't been an issue, but it seems like a good idea. Note that I'm
allowing prices of 0 here just in case there's some shenanigans at some
point in time where we want a domain to technically be premium without
having a cost.
This commit is contained in:
gbrodman
2026-07-07 15:33:10 -04:00
committed by GitHub
parent 1fe1043306
commit 4d6b5a82df
2 changed files with 42 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/src/main/java/google/registry/model/tld/label/PremiumList.java
+8
View File
@@ -169,6 +169,14 @@ public final class PremiumList extends BaseDomainLabelList<BigDecimal, PremiumEn
getInstance().revisionId = revisionId;
return this;
}
@Override
public PremiumEntry build() {
checkArgument(getInstance().price != null, "Price must not be null");
checkArgument(
getInstance().price.compareTo(BigDecimal.ZERO) >= 0, "Price must not be negative");
return super.build();
}
}
}
core/src/test/java/google/registry/model/tld/label/PremiumListTest.java
+34 -18
View File
@@ -110,28 +110,44 @@ public class PremiumListTest {
@Test
void testValidation_labelMustBeLowercase() {
Exception e =
assertThrows(
IllegalArgumentException.class,
() ->
new PremiumEntry.Builder()
.setPrice(BigDecimal.valueOf(399))
.setLabel("UPPER.tld")
.build());
assertThat(e).hasMessageThat().contains("must be in puny-coded, lower-case form");
assertThat(
assertThrows(
IllegalArgumentException.class,
() ->
new PremiumEntry.Builder()
.setPrice(BigDecimal.valueOf(399))
.setLabel("UPPER.tld")
.build()))
.hasMessageThat()
.contains("must be in puny-coded, lower-case form");
}
@Test
void testValidation_priceMustNotBeNegative() {
assertThat(
assertThrows(
IllegalArgumentException.class,
() ->
new PremiumEntry.Builder()
.setPrice(BigDecimal.valueOf(-100))
.setLabel("anchor")
.build()))
.hasMessageThat()
.isEqualTo("Price must not be negative");
}
@Test
void testValidation_labelMustBePunyCoded() {
Exception e =
assertThrows(
IllegalArgumentException.class,
() ->
new PremiumEntry.Builder()
.setPrice(BigDecimal.valueOf(399))
.setLabel("lower.みんな")
.build());
assertThat(e).hasMessageThat().contains("must be in puny-coded, lower-case form");
assertThat(
assertThrows(
IllegalArgumentException.class,
() ->
new PremiumEntry.Builder()
.setPrice(BigDecimal.valueOf(399))
.setLabel("lower.みんな")
.build()))
.hasMessageThat()
.contains("must be in puny-coded, lower-case form");
}
@Test