Drop should publish field from ReservedList entity (#2369)

* Remove the shouldPublish field from the reservedLIst entity

* Add generated schema file

core/src/main/java/google/registry/model/tld/label/ReservedList.java

@@ -71,10 +71,6 @@ public final class ReservedList
    */
   @Insignificant @Transient Map<String, ReservedListEntry> reservedListMap;
 
-  // TODO(b/321053918): Remove this field once the column is nullable
-  @Column(nullable = true)
-  boolean shouldPublish = true;
-
   @PreRemove
   void preRemove() {
     tm().query("DELETE FROM ReservedEntry WHERE revision_id = :revisionId")

core/src/test/java/google/registry/tools/server/ListReservedListsActionTest.java

@@ -69,7 +69,7 @@ class ListReservedListsActionTest extends ListActionTestCase {
         Optional.of("*"),
         Optional.empty(),
         Optional.empty(),
-        "^name\\s+.*shouldPublish.*",
+        "^name\\s+.*",
         "^-+\\s+-+",
         "^xn--q9jyb4c-private\\s+.*",
         "^xn--q9jyb4c-published\\s+.*");

db/src/main/resources/sql/schema/db-schema.sql.generated

@@ -693,7 +693,6 @@
        revision_id  bigserial not null,
         creation_timestamp timestamptz,
         name text not null,
-        should_publish boolean,
         primary key (revision_id)
     );
 

gradle.properties

@@ -1,4 +1,4 @@
-# This file defines properties used by the Gradle build. It must be kept in
+# This file defines properties used by the gradle build.  It must be kept in
 # sync with config/nom_build.py.
 #
 # To regenerate, run ./nom_build --generate-gradle-properties