mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-04-12 12:37:14 +00:00
Code Issues Releases Wiki Activity

Clean up misc Javadoc and deprecation warnings

Browse Source 
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136156922
This commit is contained in:
ctingue
2016-10-14 07:56:22 -07:00
committed by Ben McIlwain
parent 064026a4a5
commit 67da55536f
4 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
java/google/registry/monitoring/metrics/MetricMetrics.java
View File

@@ -49,6 +49,7 @@ final class MetricMetrics {
LABELS);
/** A gauge representing a snapshot of the number of active timeseries being reported. */
@SuppressWarnings("unused")
private static final Metric<Long> timeseriesCount =
MetricRegistryImpl.getDefault()
.newGauge(

3
java/google/registry/rde/RdeImportUtils.java
View File

@@ -135,8 +135,7 @@ public class RdeImportUtils {
// TODO (wolfgang): Add validation method for IDN tables
try (InputStream input =
gcsUtils.openInputStream(new GcsFilename(escrowBucketName, escrowFilePath))) {
try {
RdeParser parser = new RdeParser(input);
try (RdeParser parser = new RdeParser(input)) {
// validate that tld exists and is in PREDELEGATION state
String tld = parser.getHeader().getTld();
try {

10
javatests/google/registry/testing/AbstractEppResourceSubject.java
View File

@@ -106,7 +106,7 @@ abstract class AbstractEppResourceSubject
public HistoryEntrySubject hasOnlyOneHistoryEntryWhich() {
hasOnlyOneHistoryEntry();
return assertAboutHistoryEntries().that(getHistoryEntries().get(0)).withCustomDisplaySubject(
"the only history entry for " + getDisplaySubject());
"the only history entry for " + actualAsString());
}
public Which<HistoryEntrySubject> hasHistoryEntryAtIndex(int index) {
@@ -117,12 +117,12 @@ abstract class AbstractEppResourceSubject
}
return new Which<>(assertAboutHistoryEntries()
.that(getHistoryEntries().get(index)).withCustomDisplaySubject(String.format(
"the history entry for %s at index %s", getDisplaySubject(), index)));
"the history entry for %s at index %s", actualAsString(), index)));
}
public And<S> hasStatusValue(StatusValue statusValue) {
if (!actual().getStatusValues().contains(statusValue)) {
failWithRawMessage("%s should have had status value %s", getDisplaySubject(), statusValue);
failWithRawMessage("%s should have had status value %s", actualAsString(), statusValue);
}
return andChainer();
}
@@ -130,7 +130,7 @@ abstract class AbstractEppResourceSubject
public And<S> doesNotHaveStatusValue(StatusValue statusValue) {
if (actual().getStatusValues().contains(statusValue)) {
failWithRawMessage(
"%s should not have had status value %s", getDisplaySubject(), statusValue);
"%s should not have had status value %s", actualAsString(), statusValue);
}
return andChainer();
}
@@ -138,7 +138,7 @@ abstract class AbstractEppResourceSubject
public And<S> hasExactlyStatusValues(StatusValue... statusValues) {
if (!ImmutableSet.copyOf(actual().getStatusValues())
.equals(ImmutableSet.copyOf(statusValues))) {
assertThat(actual().getStatusValues()).named("status values for " + getDisplaySubject())
assertThat(actual().getStatusValues()).named("status values for " + actualAsString())
.containsExactly((Object[]) statusValues);
}
return andChainer();

2
javatests/google/registry/testing/DomainApplicationSubject.java
View File

@@ -54,7 +54,7 @@ public final class DomainApplicationSubject
ImmutableSet.copyOf(actual().getEncodedSignedMarks()),
ImmutableSet.of(encodedSignedMarks))) {
assertThat(actual().getEncodedSignedMarks())
.named("the encoded signed marks of " + getDisplaySubject())
.named("the encoded signed marks of " + actualAsString())
.containsExactly((Object[]) encodedSignedMarks);
}
return andChainer();