mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-01-09 23:47:49 +00:00
Code Issues Releases Wiki Activity

Migrates users from the unitless, ambiguous plus(long) and minus(long) methods on various Joda-Time APIs to their Duration-accepting overloads.

Browse Source 
​
This makes the units explicit, which prevents confusion and bugs.

More information: []
Tested:
    TAP --sample for global presubmit queue
    []

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=172455602
This commit is contained in:
kak
2017-10-17 05:57:48 -07:00
committed by jianglai
parent 108deb7f9d
commit 6f9b039e72
4 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
javatests/google/registry/flows/domain/DomainCreateFlowTest.java
View File

@@ -154,7 +154,7 @@ public class DomainCreateFlowTest extends ResourceFlowTestCase<DomainCreateFlow,
public DomainCreateFlowTest() {
setEppInput("domain_create.xml");
clock.setTo(DateTime.parse("1999-04-03T22:00:00.0Z").minus(1));
clock.setTo(DateTime.parse("1999-04-03T22:00:00.0Z").minus(Duration.millis(1)));
}
@Before

2
javatests/google/registry/model/EppResourceUtilsTest.java
View File

@@ -70,7 +70,7 @@ public class EppResourceUtilsTest {
newHostResource("ns1.cat.tld").asBuilder()
.setCreationTimeForTest(clock.nowUtc())
.build());
assertThat(loadAtPointInTime(host, clock.nowUtc().minus(1)).now()).isNull();
assertThat(loadAtPointInTime(host, clock.nowUtc().minus(Duration.millis(1))).now()).isNull();
}
@Test

5
javatests/google/registry/tools/CreateTldCommandTest.java
View File

@@ -37,6 +37,7 @@ import java.io.PrintStream;
import java.math.BigDecimal;
import org.joda.money.Money;
import org.joda.time.DateTime;
import org.joda.time.Duration;
import org.joda.time.Interval;
import org.junit.Before;
import org.junit.Test;
@@ -333,7 +334,9 @@ public class CreateTldCommandTest extends CommandTestCase<CreateTldCommand> {
IllegalArgumentException.class,
"Don't pass both --initial_tld_state and --tld_state_transitions");
runCommandForced(
String.format("--tld_state_transitions=%s=PREDELEGATION,%s=SUNRISE", now, now.plus(1)),
String.format(
"--tld_state_transitions=%s=PREDELEGATION,%s=SUNRISE",
now, now.plus(Duration.millis(1))),
"--initial_tld_state=GENERAL_AVAILABILITY",
"--dns_writers=VoidDnsWriter",
"xn--q9jyb4c");

8
javatests/google/registry/tools/UpdateTldCommandTest.java
View File

@@ -530,7 +530,9 @@ public class UpdateTldCommandTest extends CommandTestCase<UpdateTldCommand> {
thrown.expect(
ParameterException.class, "not formatted correctly or has transition times out of order");
runCommandForced(
String.format("--tld_state_transitions=%s=PREDELEGATION,%s=SUNRISE", now, now.minus(1)),
String.format(
"--tld_state_transitions=%s=PREDELEGATION,%s=SUNRISE",
now, now.minus(Duration.millis(1))),
"xn--q9jyb4c");
}
@@ -630,7 +632,9 @@ public class UpdateTldCommandTest extends CommandTestCase<UpdateTldCommand> {
thrown.expect(
ParameterException.class, "not formatted correctly or has transition times out of order");
runCommandForced(
String.format("--renew_billing_cost_transitions=\"%s=USD 1,%s=USD 2\"", now, now.minus(1)),
String.format(
"--renew_billing_cost_transitions=\"%s=USD 1,%s=USD 2\"",
now, now.minus(Duration.millis(1))),
"xn--q9jyb4c");
}