mirror of
https://github.com/google/nomulus
synced 2026-09-05 23:57:01 +00:00
Migrates users from the unitless, ambiguous plus(long) and minus(long) methods on various Joda-Time APIs to their Duration-accepting overloads.
This makes the units explicit, which prevents confusion and bugs.
More information: []
Tested:
TAP --sample for global presubmit queue
[]
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=172455602
This commit is contained in:
@@ -530,7 +530,9 @@ public class UpdateTldCommandTest extends CommandTestCase<UpdateTldCommand> {
|
||||
thrown.expect(
|
||||
ParameterException.class, "not formatted correctly or has transition times out of order");
|
||||
runCommandForced(
|
||||
String.format("--tld_state_transitions=%s=PREDELEGATION,%s=SUNRISE", now, now.minus(1)),
|
||||
String.format(
|
||||
"--tld_state_transitions=%s=PREDELEGATION,%s=SUNRISE",
|
||||
now, now.minus(Duration.millis(1))),
|
||||
"xn--q9jyb4c");
|
||||
}
|
||||
|
||||
@@ -630,7 +632,9 @@ public class UpdateTldCommandTest extends CommandTestCase<UpdateTldCommand> {
|
||||
thrown.expect(
|
||||
ParameterException.class, "not formatted correctly or has transition times out of order");
|
||||
runCommandForced(
|
||||
String.format("--renew_billing_cost_transitions=\"%s=USD 1,%s=USD 2\"", now, now.minus(1)),
|
||||
String.format(
|
||||
"--renew_billing_cost_transitions=\"%s=USD 1,%s=USD 2\"",
|
||||
now, now.minus(Duration.millis(1))),
|
||||
"xn--q9jyb4c");
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user