mirror of
https://github.com/google/nomulus
synced 2026-01-05 04:56:03 +00:00
Add an explanation to dummied-out JPA init (#299)
* Add an explanation to dummied-out JPA init Add a more elaborate explanation of why actual JpaTransactionManager initialization was removed from the factory.
This commit is contained in:
@@ -33,6 +33,12 @@ public class TransactionManagerFactory {
|
||||
// PostgreSQL tables in production, ensure that all of the test environments are set up
|
||||
// correctly and restore the code that creates a JpaTransactionManager when
|
||||
// RegistryEnvironment.get() != UNITTEST.
|
||||
//
|
||||
// We removed the original code because it didn't work in sandbox (due to the absence of the
|
||||
// persistence.xml file, which has since been added), and then (after adding this) didn't work
|
||||
// in crash because the postgresql password hadn't been set up. Prior to restoring, we'll need
|
||||
// to do setup in all environments, and we probably only want to do this once we're actually
|
||||
// using Cloud SQL for one of the new tables.
|
||||
return DummyJpaTransactionManager.create();
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user