mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-02-12 15:51:34 +00:00
Code Issues Releases Wiki Activity

Rename "absent" to "empty" in test names

Browse Source 
This is left over from the transition from Guava to Java 8 Optionals.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=207154260
This commit is contained in:
mcilwain
2018-08-02 13:24:29 -07:00
committed by jianglai
parent 8664101687
commit a111ff0b0a
3 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
javatests/google/registry/request/RequestParametersTest.java
View File

@@ -69,12 +69,12 @@ public class RequestParametersTest {
}
@Test
public void testExtractOptionalParameter_notPresent_returnsAbsent() {
public void testExtractOptionalParameter_notPresent_returnsEmpty() {
assertThat(extractOptionalParameter(req, "spin")).isEmpty();
}
@Test
public void testExtractOptionalParameter_empty_returnsAbsent() {
public void testExtractOptionalParameter_empty_returnsEmpty() {
when(req.getParameter("spin")).thenReturn("");
assertThat(extractOptionalParameter(req, "spin")).isEmpty();
}
@@ -192,7 +192,7 @@ public class RequestParametersTest {
}
@Test
public void testOptionalExtractEnumValue_noValue_returnsAbsent() {
public void testOptionalExtractEnumValue_noValue_returnsEmpty() {
when(req.getParameter("spin")).thenReturn("");
assertThat(extractOptionalEnumParameter(req, Club.class, "spin")).isEmpty();
}
@@ -239,7 +239,7 @@ public class RequestParametersTest {
}
@Test
public void testExtractOptionalDatetimeParameter_empty_returnsAbsent() {
public void testExtractOptionalDatetimeParameter_empty_returnsEmpty() {
when(req.getParameter("timeParam")).thenReturn("");
assertThat(extractOptionalDatetimeParameter(req, "timeParam")).isEmpty();
}

4
javatests/google/registry/request/RouterTest.java
View File

@@ -64,7 +64,7 @@ public final class RouterTest {
}
@Test
public void testRoute_pathMismatch_returnsAbsent() {
public void testRoute_pathMismatch_returnsEmpty() {
assertThat(Router.create(SlothComponent.class).route("/doge")).isEmpty();
}
@@ -92,7 +92,7 @@ public final class RouterTest {
}
@Test
public void testRoute_prefixDoesNotMatch_returnsAbsent() {
public void testRoute_prefixDoesNotMatch_returnsEmpty() {
assertThat(Router.create(PrefixComponent.class).route("")).isEmpty();
assertThat(Router.create(PrefixComponent.class).route("/")).isEmpty();
assertThat(Router.create(PrefixComponent.class).route("/ulysses")).isEmpty();

4
javatests/google/registry/tools/params/PhoneNumberParameterTest.java
View File

@@ -37,12 +37,12 @@ public class PhoneNumberParameterTest {
}
@Test
public void testConvert_empty_returnsAbsent() {
public void testConvert_empty_returnsEmpty() {
assertThat(instance.convert("")).isEmpty();
}
@Test
public void testConvert_nullString_returnsAbsent() {
public void testConvert_nullString_returnsEmpty() {
assertThat(instance.convert("null")).isEmpty();
}
}