mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-09-26 01:44:23 +00:00
Code Issues Releases Wiki Activity

Delete private="true" from .soy files

Browse Source 
private="true" has never done very much unfortunately. There is an alternate
way to mark templates as private by setting 'visibility="private"' which does
get enforced both by the soy compiler and by custom per-language strategies in
the various backends.

Unfortunately, it isn't possible to safely migrate from one to the other since
users may be calling these templates from server side soy which enforces
visibility via a runtime exception.  So they are just being deleted.

LSC: https://docs.google.com/document/d/1aOM_tBmanDQolF8mAuB0y29yB76cmYS5qOVYBAzFzyw/edit#

Tested:
    TAP --sample for global presubmit queue
    []

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=159565458
This commit is contained in:
lukes
2017-06-21 10:00:53 -04:00
committed by Ben McIlwain
parent 2b7f78db98
commit e94ba8d2af
4 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/google/registry/ui/soy/registrar/Console.soy
+1 -1
View File
@@ -75,7 +75,7 @@
/** Sidebar nav. Ids on each elt for testing only. */
{template .navbar_ private="true"}
{template .navbar_ visibility="private"}
{@param showPaymentLink: bool}
<div id="reg-nav" class="{css kd-content-sidebar}">
<ul id="reg-navlist">