mirror of
https://github.com/google/nomulus
synced 2026-01-09 15:43:52 +00:00
Don't include deleted domains in the ICANN reporting total_domains field (#1713)
This shouldn't matter for billing or anything like that because the actual actions performed that month are still correct, but before this PR we're including all domains ever created in the total_domains number, including deleted domains <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/google/nomulus/1713) <!-- Reviewable:end -->
This commit is contained in:
@@ -36,7 +36,7 @@ JOIN
|
||||
tld,
|
||||
current_sponsor_registrar_id,
|
||||
domain_name
|
||||
FROM "Domain" AS d;''')
|
||||
FROM "Domain" AS d WHERE d.deletion_time > now();''')
|
||||
ON
|
||||
current_sponsor_registrar_id = registrar_id
|
||||
GROUP BY tld, registrar_name
|
||||
|
||||
@@ -62,7 +62,6 @@ class TransactionsReportingQueryBuilderTest {
|
||||
|
||||
TransactionsReportingQueryBuilder queryBuilder =
|
||||
createQueryBuilder("cloud_sql_icann_reporting");
|
||||
;
|
||||
ImmutableMap<String, String> actualQueries = queryBuilder.getViewQueryMap(yearMonth);
|
||||
for (String queryName : expectedQueryNames) {
|
||||
String actualTableName = String.format("%s_201709", queryName);
|
||||
|
||||
@@ -36,7 +36,7 @@ JOIN
|
||||
tld,
|
||||
current_sponsor_registrar_id,
|
||||
domain_name
|
||||
FROM "Domain" AS d;''')
|
||||
FROM "Domain" AS d WHERE d.deletion_time > now();''')
|
||||
ON
|
||||
current_sponsor_registrar_id = registrar_id
|
||||
GROUP BY tld, registrar_name
|
||||
|
||||
Reference in New Issue
Block a user