nomulus

mirrors/nomulus

Fork 0

mirror of https://github.com/google/nomulus synced 2026-10-01 12:16:02 +00:00

Commit Graph

Author	SHA1	Message	Date
gloriosoandjianglai	c2b5eaa4d2	Replace http://errorprone.info with https://errorprone.info since that site serves from https now Tested: TAP --sample for global presubmit queue [] ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=195473725	2018-05-05 23:52:20 -04:00
gloriosoandjianglai	08b068b7bf	Remove unnecessary Objects.equals() call on collections This fixes a bug where collections of incompatible types are being tested for equality to each other (e.g.: Set<Foo> equals Set<Integer> should never return true unless both sets are empty, a bit of a vacuous assertion). This change is necessary to unblock future improvements to the static analysis capabilities of the java compiler. Tested: TAP --sample for global presubmit queue [] ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=178798071	2017-12-13 12:43:45 -05:00

Author

SHA1

Message

Date

gloriosoandjianglai

c2b5eaa4d2

Replace http://errorprone.info with https://errorprone.info since that site

serves from https now

Tested:
    TAP --sample for global presubmit queue
    []

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=195473725

2018-05-05 23:52:20 -04:00

gloriosoandjianglai

08b068b7bf

Remove unnecessary Objects.equals() call on collections

This fixes a bug where collections of incompatible types are being tested for equality to each other (e.g.: Set<Foo> equals Set<Integer> should never return true unless both sets are empty, a bit of a vacuous assertion).

This change is necessary to unblock future improvements to the static analysis capabilities of the java compiler.
Tested:
    TAP --sample for global presubmit queue
    []

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=178798071

2017-12-13 12:43:45 -05:00