Make TaskMatcher default to POST methods (#1418)

* Make TaskMatcher default to POST methods

TaskOptions.Builder.withUrl() defaults to POST methods.  Therefore, it seems
reasonable to verify that task queue methods are using the POST method,
especially given that the method must now be identified explicitly when using
CloudTaskUtils.  This check would have guarded against the bug fixed by #1413.

* Elaborate on comment

* Further improved the comment

core/src/main/java/google/registry/backup/CommitLogCheckpointAction.java

@@ -80,7 +80,7 @@ public final class CommitLogCheckpointAction implements Runnable {
               // Enqueue a diff task between previous and current checkpoints.
               cloudTasksUtils.enqueue(
                   QUEUE_NAME,
-                  CloudTasksUtils.createGetTask(
+                  CloudTasksUtils.createPostTask(
                       ExportCommitLogDiffAction.PATH,
                       Service.BACKEND.toString(),
                       ImmutableMultimap.of(

core/src/test/java/google/registry/testing/CloudTasksHelper.java

@@ -188,7 +188,12 @@ public class CloudTasksHelper implements Serializable {
 
     String taskName;
     String service;
-    HttpMethod method;
+    // App Engine TaskOption methods default to "POST".  This isn't obvious from the code, so we
+    // default it to POST here so that we don't accidentally create an entry with a GET method when
+    // converting to CloudTaskUtils, which requires that the method be specified explicitly.
+    // Should we ever actually want to do a GET, we'll likewise have to set this explicitly for the
+    // tests.
+    HttpMethod method = HttpMethod.POST;
     String url;
     Multimap<String, String> headers = ArrayListMultimap.create();
     Multimap<String, String> params = ArrayListMultimap.create();

proxy/kubernetes/proxy-deployment-qa-canary.yaml

@@ -0,0 +1,54 @@
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+  namespace: default
+  name: proxy-deployment-canary
+  labels:
+    app: proxy-canary
+spec:
+  replicas: 3
+  selector:
+    matchLabels:
+      app: proxy-canary
+  template:
+    metadata:
+      labels:
+        app: proxy-canary
+    spec:
+      containers:
+      - name: proxy-canary
+        image: gcr.io/GCP_PROJECT/proxy
+        ports:
+        - containerPort: 30000
+          name: health-check
+        - containerPort: 30001
+          name: whois
+        - containerPort: 30002
+          name: epp
+        - containerPort: 30010
+          name: http-whois
+        - containerPort: 30011
+          name: https-whois
+        readinessProbe:
+          tcpSocket:
+            port: health-check
+          initialDelaySeconds: 5
+          periodSeconds: 10
+        livenessProbe:
+          tcpSocket:
+            port: health-check
+          initialDelaySeconds: 15
+          periodSeconds: 20
+        imagePullPolicy: Always
+        args: ["--env", "qa_canary", "--log"]
+        env:
+        - name: POD_ID
+          valueFrom:
+            fieldRef:
+              fieldPath: metadata.name
+        - name: NAMESPACE_ID
+          valueFrom:
+            fieldRef:
+              fieldPath: metadata.namespace
+        - name: CONTAINER_NAME
+          value: proxy-canary

proxy/kubernetes/proxy-deployment-qa.yaml

@@ -0,0 +1,54 @@
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+  namespace: default
+  name: proxy-deployment
+  labels:
+    app: proxy
+spec:
+  replicas: 3
+  selector:
+    matchLabels:
+      app: proxy
+  template:
+    metadata:
+      labels:
+        app: proxy
+    spec:
+      containers:
+      - name: proxy
+        image: gcr.io/GCP_PROJECT/proxy
+        ports:
+        - containerPort: 30000
+          name: health-check
+        - containerPort: 30001
+          name: whois
+        - containerPort: 30002
+          name: epp
+        - containerPort: 30010
+          name: http-whois
+        - containerPort: 30011
+          name: https-whois
+        readinessProbe:
+          tcpSocket:
+            port: health-check
+          initialDelaySeconds: 5
+          periodSeconds: 10
+        livenessProbe:
+          tcpSocket:
+            port: health-check
+          initialDelaySeconds: 15
+          periodSeconds: 20
+        imagePullPolicy: Always
+        args: ["--env", "qa", "--log"]
+        env:
+        - name: POD_ID
+          valueFrom:
+            fieldRef:
+              fieldPath: metadata.name
+        - name: NAMESPACE_ID
+          valueFrom:
+            fieldRef:
+              fieldPath: metadata.namespace
+        - name: CONTAINER_NAME
+          value: proxy

proxy/src/main/java/google/registry/proxy/ProxyConfig.java

@@ -30,6 +30,8 @@ public class ProxyConfig {
     SANDBOX_CANARY,
     CRASH,
     CRASH_CANARY,
+    QA,
+    QA_CANARY,
     ALPHA,
     LOCAL,
   }

proxy/src/main/java/google/registry/proxy/config/proxy-config-qa-canary.yaml

@@ -0,0 +1 @@
+# Add environment-specific proxy configuration here.

proxy/src/main/java/google/registry/proxy/config/proxy-config-qa.yaml

@@ -0,0 +1 @@
+# Add environment-specific proxy configuration here.