Remove dos.xml from the configs (#1587)

* Remove dos.xml from the configs

We don't have dos config right now, and applying dos from "gcloud app
deploy" is deprecated and has started causing problems.

If we add dos configs, it should be using "gcloud app firewall-rules".

build.gradle

@@ -331,6 +331,13 @@ subprojects {
 
   apply from: "${rootDir.path}/java_common.gradle"
 
+  if (project.name != 'docs') {
+    compileJava {
+      // TODO: Remove this once we migrate off AppEngine.
+      options.release = 8
+    }
+  }
+
   if (project.name == 'third_party') return
 
   project.tasks.test.dependsOn runPresubmits

core/src/main/java/google/registry/env/common/default/WEB-INF/dos.xml

@@ -1,16 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<blacklistentries>
-
-  <!-- Example IPv4 CIDR Subnet
-  <blacklist>
-    <subnet>1.2.3.4/24</subnet>
-    <description>An IPv4 subnet</description>
-  </blacklist> -->
-
-  <!-- Example IPv6 CIDR Subnet
-  <blacklist>
-    <subnet>abcd::123:4567/48</subnet>
-    <description>An IPv6 subnet</description>
-  </blacklist> -->
-
-</blacklistentries>

core/src/main/java/google/registry/env/common/pubapi/WEB-INF/dos.xml

@@ -1,16 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<blacklistentries>
-
-  <!-- Example IPv4 CIDR Subnet
-  <blacklist>
-    <subnet>1.2.3.4/24</subnet>
-    <description>An IPv4 subnet</description>
-  </blacklist> -->
-
-  <!-- Example IPv6 CIDR Subnet
-  <blacklist>
-    <subnet>abcd::123:4567/48</subnet>
-    <description>An IPv6 subnet</description>
-  </blacklist> -->
-
-</blacklistentries>

core/src/main/java/google/registry/rde/RdeUploadAction.java

@@ -143,7 +143,7 @@ public final class RdeUploadAction implements Runnable, EscrowTask {
     // If a prefix is not provided, but we are in SQL mode, try to determine the prefix. This should
     // only happen when the RDE upload cron job runs to catch up any un-retried (i. e. expected)
     // RDE failures.
-    if (prefix.isEmpty() && !tm().isOfy()) {
+    if (!prefix.isPresent() && !tm().isOfy()) {
       // The prefix is always in the format of: rde-2022-02-21t00-00-00z-2022-02-21t00-07-33z, where
       // the first datetime is the watermark and the second one is the time when the RDE beam job
       // launched. We search for the latest folder that starts with "rde-[watermark]".

docs/build.gradle

@@ -37,9 +37,6 @@ test {
   useJUnitPlatform()
 }
 
-sourceCompatibility = '11'
-targetCompatibility = '11'
-
 task flowDocsTool(type: JavaExec) {
   systemProperty 'test.projectRoot', rootProject.projectRootDir
   jvmArgs = ['--add-exports', 'jdk.javadoc/jdk.javadoc.internal.tool=ALL-UNNAMED']

java_common.gradle

@@ -128,13 +128,6 @@ tasks.withType(JavaCompile).configureEach {
     }
 }
 
-// TODO: Change source version to 11 after target version is changed to 11 and
-// once we figure out what's wrong with Dagger compilation with source version
-// >8.
-sourceCompatibility = '8'
-// TODO: Change target version to 11. Source version can stay at 8.
-targetCompatibility = '8'
-
 compileJava { options.encoding = "UTF-8" }
 compileTestJava { options.encoding = "UTF-8" }
 

release/cloudbuild-deploy.yaml

@@ -45,7 +45,7 @@ steps:
     fi
     gsutil cp gs://$PROJECT_ID-deploy/${TAG_NAME}/${_ENV}.tar .
     tar -xvf ${_ENV}.tar
-    for filename in cron dispatch dos index queue; do
+    for filename in cron dispatch index queue; do
       gcloud -q --project $project_id app deploy \
         default/WEB-INF/appengine-generated/$filename.yaml
     done