1
0
mirror of https://github.com/google/nomulus synced 2026-03-22 10:25:11 +00:00

Compare commits

...

2 Commits

Author SHA1 Message Date
Ben McIlwain
301a6681f5 Add test confirming that login works without contact obj URI (#2983)
This is a follow-up to PR #2954.
2026-03-19 19:47:03 +00:00
Weimin Yu
2dd7cee3e5 Remove dangling shell script: rollback_tool (#2984)
Underlying python lib for AppEngine rollback is already gone.
2026-03-17 19:29:26 +00:00
2 changed files with 11 additions and 6 deletions

View File

@@ -133,7 +133,7 @@ public abstract class LoginFlowTestCase extends FlowTestCase<LoginFlow> {
}
@Test
void testSuccess_contactObjectUri_worksWhenNotProhibited() throws Exception {
void testSuccess_contactObjectUriSent_worksWhenNotProhibited() throws Exception {
persistResource(
FeatureFlag.get(PROHIBIT_CONTACT_OBJECTS_ON_LOGIN)
.asBuilder()
@@ -142,6 +142,16 @@ public abstract class LoginFlowTestCase extends FlowTestCase<LoginFlow> {
doSuccessfulTest("login_with_contact_objuri.xml");
}
@Test
void testSuccess_contactObjectUriNotSent_worksWhenNotProhibited() throws Exception {
persistResource(
FeatureFlag.get(PROHIBIT_CONTACT_OBJECTS_ON_LOGIN)
.asBuilder()
.setStatusMap(ImmutableSortedMap.of(START_OF_TIME, FeatureStatus.INACTIVE))
.build());
doSuccessfulTest("login_valid.xml");
}
@Test
void testFailure_invalidTypes() {
doFailingTest("login_invalid_types.xml", UnimplementedObjectServiceException.class);

View File

@@ -1,5 +0,0 @@
#!/bin/sh
# Wrapper for rollback_tool.py.
cd $(dirname $0)
python3 ./release/rollback/rollback_tool.py "$@"
exit $?