mirrors/object-browser
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added informative message for 413 error file too large (#1379)

Browse Source
This commit is contained in:
jinapurapu
2022-01-11 19:45:14 -08:00
committed by GitHub
parent 0400e0c6d5
commit 6527bd02e8
3 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
portal-ui/src/screens/Console/Buckets/ListBuckets/Objects/ListObjects/ListObjects.tsx
View File

@@ -761,6 +761,9 @@ const ListObjects = ({
) {
setSnackBarMessage(errorMessage);
}
if (xhr.status === 413) {
setSnackBarMessage("Error - File size too large");
}
if (xhr.status === 200) {
completeObject(identity);
if (files.length === 0) {

5
restapi/error.go
View File

@@ -17,6 +17,7 @@ var (
ErrorGeneric = errors.New("an error occurred, please try again")
errInvalidCredentials = errors.New("invalid Login")
errForbidden = errors.New("403 Forbidden")
errFileTooLarge = errors.New("413 File too Large")
errorGenericInvalidSession = errors.New("invalid session")
// ErrorGenericNotFound Generic error for not found
ErrorGenericNotFound = errors.New("not found")
@@ -173,6 +174,10 @@ func prepareError(err ...error) *models.Error {
errorCode = 403
errorMessage = err[0].Error()
}
if err[0].Error() == errFileTooLarge.Error() {
errorCode = 413
errorMessage = err[0].Error()
}
// bucket already exists
if minio.ToErrorResponse(err[0]).Code == "BucketAlreadyOwnedByYou" {
errorCode = 400

3
restapi/user_objects.go
View File

@@ -110,6 +110,9 @@ func registerObjectsHandlers(api *operations.ConsoleAPI) {
// upload object
api.UserAPIPostBucketsBucketNameObjectsUploadHandler = user_api.PostBucketsBucketNameObjectsUploadHandlerFunc(func(params user_api.PostBucketsBucketNameObjectsUploadParams, session *models.Principal) middleware.Responder {
if err := getUploadObjectResponse(session, params); err != nil {
if strings.Contains(*err.DetailedMessage, "413") {
return user_api.NewPostBucketsBucketNameObjectsUploadDefault(413).WithPayload(err)
}
return user_api.NewPostBucketsBucketNameObjectsUploadDefault(int(err.Code)).WithPayload(err)
}
return user_api.NewPostBucketsBucketNameObjectsUploadOK()