mirrors/pinniped
1
0
Fork 0
mirror of https://github.com/vmware-tanzu/pinniped.git synced 2026-01-06 05:27:23 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

skip client-side validation of manifest when k8s server < 1.27

Browse Source 
After upgrading libs to k8s 1.35, this stopped working on very old
versions of Kube. Not really a problem, because version 1.26 and below
are all over 3 years old. You can still install Pinniped on these old
version if you skip kubectl's client-side validation.
This commit is contained in:
Ryan Richard
2025-12-19 13:15:36 -08:00
parent 217b6b5620
commit 35f8c5876d
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pipelines/shared-helpers/prepare-cluster-for-integration-tests.sh
View File

@@ -854,7 +854,7 @@ echo
set -x
kapp deploy --yes --app "$concierge_app_name" --diff-changes --file "$manifest"
if ! { (($(kubectl version --output json | jq -r .serverVersion.major) == 1)) && (($(kubectl version --output json | jq -r .serverVersion.minor) < 19)); }; then
if ! { (($(kubectl version --output json | jq -r .serverVersion.major) == 1)) && (($(kubectl version --output json | jq -r .serverVersion.minor) < 27)); }; then
# Also perform a dry-run create with kubectl just to see if there are any validation errors.
# Skip this on very old clusters, since we use some API fields (like seccompProfile) which did not exist back then.
# Use can still install on these clusters by using kapp or by using kubectl --validate=false.
@@ -939,7 +939,7 @@ echo
set -x
kapp deploy --yes --app "$supervisor_app_name" --diff-changes --file "$manifest"
if ! { (($(kubectl version --output json | jq -r .serverVersion.major) == 1)) && (($(kubectl version --output json | jq -r .serverVersion.minor) < 23)); }; then
if ! { (($(kubectl version --output json | jq -r .serverVersion.major) == 1)) && (($(kubectl version --output json | jq -r .serverVersion.minor) < 27)); }; then
# Also perform a dry-run create with kubectl just to see if there are any validation errors.
# Skip this on very old clusters, since we use some API fields (like seccompProfile) which did not exist back then.
# In the Supervisor CRDs we began to use CEL validations which were introduced in Kubernetes 1.23.