Ryan Richard
8f8db3f542
Make github org comparison case-insensitive, but return original case
...
Co-authored-by: Joshua Casey <joshuatcasey@gmail.com >
2024-05-22 21:21:45 -05:00
Ryan Richard
8923704f3c
Finish initial github login flow
...
Also:
- fix github teams query: fix bug and sort/unique the results
- add IDP display name to github downstream subject
- fix error types returned by LoginFromCallback
- add trace logs to github API results
- update e2e test
- implement placeholder version of refresh for github
2024-05-22 21:21:45 -05:00
Joshua Casey
ba2d122308
fix lint
2024-05-22 21:21:45 -05:00
Joshua Casey
938bea9910
upstreamgitub.go now uses githubclient to determine username and groups
2024-05-22 21:21:45 -05:00
Joshua Casey
8719c7a2db
Standardize error messages and url handling within NewGitHubClient
...
Co-authored-by: Ryan Richard <richardry@vmware.com >
2024-05-22 21:21:45 -05:00
Ryan Richard
16fa12f455
Handle empty or invalid github API responses
...
Co-authored-by: Joshua Casey <joshuatcasey@gmail.com >
2024-05-22 21:21:45 -05:00
Joshua Casey
555b1c80e3
Use passed-in context
...
Co-authored-by: Ryan Richard <richardry@vmware.com >
2024-05-22 21:21:45 -05:00
Joshua Casey
a12a5f387a
Empty allowedOrganizations will return all teams
...
Co-authored-by: Ryan Richard <richardry@vmware.com >
2024-05-22 21:21:45 -05:00
Joshua Casey
c087e33b86
Add client wrapper for github.com/google/go-github/v62
2024-05-22 21:21:45 -05:00
Ryan Richard
49c468f00a
Add GetUser() interface and implement LoginFromCallback() for GitHub
...
ALso fixed some of the GitHub test helpers
2024-05-22 21:21:45 -05:00
Joshua Casey
b7f79f0adc
Add github-specific tests in callback_handler_github_test.go
...
Co-authored-by: Ryan Richard <richardry@vmware.com >
2024-05-22 21:21:45 -05:00
Ryan Richard
2756a106a9
Merge pull request #1966 from vmware-tanzu/jtc/add-docs-for-github-app
...
Add docs for GitHub app and GitHub OAuth app
2024-05-22 15:04:38 -07:00
Ryan Richard
efffa0def2
document creating GitHub OAuth App
2024-05-22 15:03:09 -07:00
Joshua Casey
6beb1c135c
Add docs for GitHub App configuration on github.com
2024-05-22 16:25:42 -05:00
Joshua Casey
7ac141ba08
Merge pull request #1960 from vmware-tanzu/jtc/merge-main-at-3fe3cf71-into-github
...
Merge main at `3fe3cf71` into `github_identity_provider`
2024-05-16 20:37:42 -05:00
Joshua Casey
fd7838ef2c
Add 'github' as an example to the 'pinniped login oidc --upstream-identity-provider-type' help text
2024-05-16 16:22:13 -05:00
Joshua Casey
7ffb1de1c9
Merge branch 'github_identity_provider' into jtc/merge-main-at-3fe3cf71-into-github
2024-05-16 16:07:30 -05:00
Joshua Casey
e4daa5a924
Merge branch 'main' into jtc/merge-main-at-3fe3cf71-into-github
2024-05-16 16:05:34 -05:00
Joshua Casey
147022234e
Merge pull request #1959 from vmware-tanzu/github_hack_prepare_supervisor
...
update hack/prepare-supervisor-on-kind.sh for GitHub IDPs
2024-05-16 16:04:41 -05:00
Ryan Richard
2054708c53
update hack/prepare-supervisor-on-kind.sh for GitHub IDPs
2024-05-16 13:49:53 -07:00
Ryan Richard
3fe3cf71ab
Merge pull request #1928 from vmware-tanzu/jtc/add-idp-type-discovery
...
Add `pinniped_supported_identity_provider_types` to the IDP discovery endpoint
2024-05-16 13:06:38 -07:00
Joshua Casey
7787885463
Add federation domain cleanup in E2E integration test
...
Co-authored-by: Ryan Richard <richardry@vmware.com >
2024-05-16 14:18:43 -05:00
Ryan Richard
f320980006
Add integration test to prove that 'pinniped login oidc' will infer the flowtype from the Supervisor's IDP discovery
...
Co-authored-by: Joshua T Casey <caseyj@vmware.com >
2024-05-16 12:57:33 -05:00
Ryan Richard
7e0a3c114d
Pinniped CLI and the oidc-client package are now enhanced by pinniped_supported_identity_provider_types
...
Co-authored-by: Joshua Casey <joshuatcasey@gmail.com >
2024-05-16 12:57:12 -05:00
Joshua Casey
a86d7d27c1
Add pinniped_supported_identity_provider_types to the IDP discovery endpoint
2024-05-16 12:55:45 -05:00
Joshua Casey
b00cf65732
Merge pull request #1958 from vmware-tanzu/jtc/merge-main-at-6b3f175-into-github
...
Merge main at `6b3f175` into `github_identity_provider`
2024-05-16 11:02:50 -05:00
Joshua Casey
69364b2183
Merge branch 'main' into jtc/merge-main-at-6b3f175-into-github
2024-05-16 09:22:28 -05:00
Joshua Casey
6b3f175885
Merge pull request #1957 from vmware-tanzu/pinny/bump-deps
...
Bump dependencies
2024-05-16 08:55:13 -05:00
Pinny
cb7aa561cf
Bump dependencies
2024-05-16 13:02:49 +00:00
Joshua Casey
253869ad46
Merge pull request #1954 from vmware-tanzu/pinny/bump-deps
...
Bump dependencies
2024-05-15 14:41:24 -05:00
Pinny
109da32164
Bump dependencies
2024-05-15 17:50:34 +00:00
Joshua Casey
b69c0ac746
Merge pull request #1860 from vmware-tanzu/github_proposal
...
Add proposal for Authenticating Users via GitHub
2024-05-15 12:11:42 -05:00
Joshua Casey
4cc61c038e
Merge pull request #1951 from vmware-tanzu/pinny/bump-deps
...
Bump dependencies
2024-05-15 08:54:31 -05:00
Pinny
ae725feee9
Bump dependencies
2024-05-15 13:02:47 +00:00
Joshua Casey
49a57576dd
Merge pull request #1953 from vmware-tanzu/site_and_readme_updates
...
some small readme and site updates
2024-05-14 14:45:46 -05:00
Ryan Richard
b94b9ad2d8
some small readme and site updates
2024-05-14 09:57:16 -07:00
Joshua Casey
b28e416d0c
Merge pull request #1950 from vmware-tanzu/refactor_ptls
...
refactor ptls to clarify the difference between FIPS and non-FIPS modes
2024-05-13 20:32:43 -05:00
Ryan Richard
e13f4a7f29
refactor ptls to clarify the difference between FIPS and non-FIPS modes
...
and backfill some basic tests
2024-05-13 16:52:15 -07:00
Joshua Casey
f96cbea521
Merge pull request #1948 from vmware-tanzu/pinny/bump-deps
...
Bump dependencies
2024-05-13 09:33:18 -05:00
Pinny
d4fb9be250
Bump dependencies
2024-05-13 13:01:21 +00:00
Joshua Casey
41cdb6bbaf
Merge pull request #1946 from vmware-tanzu/jtc/merge-main-at-d7849c79-to-github
...
Merge main at `d7849c79` to `github_identity_provider`
2024-05-10 16:35:35 -05:00
Joshua Casey
f43b6f04dc
Fix lint issues from golangci-lint 1.58.1
2024-05-10 15:15:59 -05:00
Joshua Casey
791b785dea
Merge branch 'main' into jtc/merge-main-at-d7849c79-to-github
2024-05-10 14:22:09 -05:00
Ryan Richard
d7849c793c
Merge pull request #1939 from vmware-tanzu/jtc/bump-golangci-lint-to-1-58
...
Bump golangci-lint to 1.58.1
2024-05-10 12:17:18 -07:00
Joshua Casey
5568372bb9
Do not use v for the version prefix in lint-version.txt
2024-05-10 13:27:15 -05:00
Joshua Casey
cba26c92f5
Remove with_modules from hack/module.sh
2024-05-10 13:12:00 -05:00
Joshua Casey
47de5118f2
Remove deprecated .golangci.yaml options
2024-05-10 12:51:03 -05:00
Joshua Casey
81f3acfa38
Update some build tags since go1.22+ is now required
2024-05-10 12:51:03 -05:00
Joshua Casey
aac48fc308
Enable 'spancheck' linter
2024-05-10 12:51:03 -05:00
Joshua Casey
5635d6c862
Enable 'fatcontext' linter and mark 'canonicalheader' as unusable
2024-05-10 12:51:02 -05:00
