Make pv_watchfd_info() and pv_reset_watchfd() static, as they are only used in one place (cppcheck recommendation).

This commit is contained in:
Andrew Wood
2026-05-11 20:50:43 +01:00
parent 229aadf194
commit 270bcb066e
2 changed files with 3 additions and 5 deletions
-2
View File
@@ -644,7 +644,6 @@ void pv_reset_calc(pvtransfercalc_t);
void pv_reset_transfer(pvtransferstate_t);
void pv_reset_flags(pvtransientflags_t);
void pv_reset_display(pvdisplay_t);
void pv_reset_watchfd(pvwatchfd_t);
void pv_freecontents_display(pvdisplay_t);
void pv_freecontents_transfer(pvtransferstate_t);
void pv_freecontents_calc(pvtransfercalc_t);
@@ -667,7 +666,6 @@ void pv_sig_nopause(void);
bool pv_remote_check(pvstate_t);
int pv_watchfd_info(pvstate_t, pvwatchfd_t, bool);
bool pv_watchfd_changed(pvwatchfd_t);
off_t pv_watchfd_position(pvwatchfd_t);
int pv_watchpid_scanfds(pvstate_t, pid_t, int, int *, pvwatchfd_t *);
+3 -3
View File
@@ -109,7 +109,7 @@ static bool filesize(pvwatchfd_t info)
* it's not readable or not a regular file, no error is reported with
* pv_error() when returning the error code.
*/
int pv_watchfd_info(pvstate_t state, pvwatchfd_t info, bool automatic)
static int pv_watchfd_info(pvstate_t state, pvwatchfd_t info, bool automatic)
{
struct vnode_fdinfowithpath vnodeInfo = { };
@@ -182,7 +182,7 @@ int pv_watchfd_info(pvstate_t state, pvwatchfd_t info, bool automatic)
* it's not readable or not a regular file, no error is reported with
* pv_error() when returning the error code.
*/
int pv_watchfd_info(pvstate_t state, pvwatchfd_t info, bool automatic)
static int pv_watchfd_info(pvstate_t state, pvwatchfd_t info, bool automatic)
{
if (NULL == state)
return -1;
@@ -472,7 +472,7 @@ static bool extend_info_array(int *array_length_ptr, pvwatchfd_t *info_array_ptr
/*
* Reset calculated values in the given watchfd info structure.
*/
void pv_reset_watchfd(pvwatchfd_t info)
static void pv_reset_watchfd(pvwatchfd_t info)
{
if (NULL == info)
return;