More specific TODOs for one way of implementing #81.

This commit is contained in:
Andrew Wood
2025-10-07 22:17:10 +01:00
parent 64c4e8efb9
commit 72d9efc993
2 changed files with 3 additions and 3 deletions
+2 -3
View File
@@ -518,12 +518,11 @@ struct pvwatchfd_s {
off_t size; /* size of whole file, 0 if unknown */
off_t position; /* position last seen at */
struct timespec start_time; /* time we started watching the fd */
/* TODO: changes for #81, retaining closed fds for a little while: */
/* TODO: track "closed" as well as "displayable"/"unused" */
/* TODO: track when closed, i.e. when ready to be removed */
struct timespec last_active; /* time the fd was last seen open (TODO, #81) */
pid_t watch_pid; /* PID to watch */
int watch_fd; /* fd to watch */
bool displayable; /* false if not displayable */
bool inactive; /* true if the fd is now closed (TODO, #81) */
bool unused; /* true if free for re-use */
};
typedef struct pvwatchfd_s *pvwatchfd_t;
+1
View File
@@ -712,6 +712,7 @@ int pv_watchfd_loop(pvstate_t state)
int fd; /* watched fd, or -1 for all */
pvwatchfd_t info_array; /* watch information for each fd */
int array_length; /* length of watch info array */
/* TODO: "finished but not time to stop showing" flag for #81 */
bool finished; /* "PID:FD": fd closed; or PID gone */
} *watching;
unsigned int watch_idx;