Commit Graph
482 Commits
Author SHA1 Message Date
Andrew Wood ba0738496e In the stub pv_remote_check() used where remote control is unavailable (OpenBSD), return false so there is a return value. 2026-04-06 15:19:24 +01:00
Andrew Wood 3aac6a7b64 Tidy up the comments. 2026-04-05 20:23:38 +01:00
Andrew Wood fc23d71226 Return an error from pv__write_pidfile() if the final rename() fails. 2026-04-05 19:34:00 +01:00
Andrew Wood c2474f5c33 Tidy up the comments. 2026-04-05 19:30:51 +01:00
Andrew Wood 9427d210d8 Remove the "ratio" option flag, as it is not needed (#67). 2026-04-05 15:10:53 +01:00
Andrew Wood bd5b709dda Calculate the size, in monitor mode (#67). 2026-04-04 21:43:43 +01:00
Andrew Wood b79273bb91 At the end of the transfer, exchange information with the other monitor when in "monitor both" mode, so both sides learn each other's final transfer value, to give the correct final ratio (#67). 2026-04-04 21:07:04 +01:00
Andrew Wood 74de4e9a01 Merge branch 'wrap_process' 2026-04-04 13:30:50 +01:00
Andrew Wood d8cc637b56 Add the "%{ratio}" formatter (#67). 2026-04-03 21:49:41 +01:00
Andrew Wood 8f19633dd7 In "-M both" mode, exchange information about the total amount transferred with the other side (#67). 2026-04-03 21:12:13 +01:00
Andrew Wood 7892e54d7e Rather than setting an option flag for ratio, add it to the default format string on the "out" side (#67). 2026-04-03 20:20:50 +01:00
Andrew Wood d7327aaf95 Replace pv_state_set_format() with pv_set_format_options(), which takes a structure rather than a long list of arguments, to make it easier to pass around - and rely on pv_state_name_set() being called first rather than doing it within this function, so it is only doing one job (#67). 2026-04-03 20:00:42 +01:00
Andrew Wood 80358e84f3 If no display options are passed and "-M both" is active, set a "ratio" option flag to display the in:out ratio as well (#67). 2026-04-02 23:08:49 +01:00
Andrew Wood 002780fbaf Ignore files autogenerated by "autoreconf" (#185). 2026-04-01 22:14:57 +01:00
Andrew Wood 1003bbb121 Remove src/include/config.h.in from the repository as it is generated by "autoreconf" and causes conflicts (#185). 2026-04-01 22:11:40 +01:00
Andrew Wood 7ce6d275ba Merge pull request 'fix discard const qualifier from pointers' (#180) from heitbaum/pv:const into main
Reviewed-on: https://codeberg.org/ivarch/pv/pulls/180
2026-03-31 23:10:13 +02:00
Andrew Wood 8ef4ff2e84 If an empty format string is supplied, such as -F "", make that imply -q and cancel -c, so that -F "" -F "%b %t %r %p %e" -M both will monitor both sides but only display the output side - which will be useful when ratio is added (#67). 2026-03-30 21:41:16 +01:00
Andrew Wood 00f06f2b2c Pass the othermonitor_* values into the main state, and add TODO markers for next steps (#67). 2026-03-29 21:49:47 +01:00
Andrew Wood 2a54d4edcc Set up a pair of pipes for the in and out monitors to use to pass progress details between each other, and replace repeated "close if open" code with a macro (#67). 2026-03-28 22:40:45 +00:00
Andrew Wood 8281b918ef Add a TODO marker for monitor mode suggesting another way to pass ratio information between in and out (#67). 2026-03-27 22:28:07 +00:00
Andrew Wood 7edbd3e951 Add a TODO about how to get ratio information (#67). 2026-03-24 23:06:36 +00:00
Andrew Wood d98237134b Adjust the -M help so it specifies the range of accepted values (#67). 2026-03-23 22:33:25 +00:00
Andrew Wood a063b95005 Fix the rate calculation when --bits is used - patch from user mojohakase (#182). 2026-03-21 22:28:27 +00:00
Andrew Wood 5c84305817 Hide the __attribute__() definition from splint so it doesn't generate spurious warnings. 2026-03-21 15:48:35 +00:00
Andrew Wood c8e13d226b Wait for the other processes associated with monitoring mode before returning, closing stdout beforehand so the monitored command will end (#67). 2026-03-21 15:47:07 +00:00
Andrew Wood 6a20139f5c Add a macro to remove __attribute__(()) if not compiling with GCC. 2026-03-20 23:48:28 +00:00
Andrew Wood 7be959ece1 Add more debugging, and pass a dummy input file list of just "-" to the monitoring transfer loop (#67). 2026-03-20 23:13:33 +00:00
Andrew Wood b3896f93b2 Add more debugging, and set the pipefd entries to -1 after closing them to avoid double-close (#67). 2026-03-20 23:00:44 +00:00
Andrew Wood 09a55ef62a Put the constant on the left hand side to avoid accidental assignment if an "=" is omitted (#67). 2026-03-20 22:14:35 +00:00
Andrew Wood 149be3f9ab Run the transfer main loop for the in and out monitoring sides, using another process for "out" if monitoring both (#67). 2026-03-20 22:12:14 +00:00
Andrew Wood f647b12a2d Pass through "make indent" for consistency (#67). 2026-03-20 22:11:19 +00:00
Andrew Wood ff8e396500 Do not add the monitor command arguments as PV input files; and execute the monitor command in the monitor process (#67). 2026-03-19 22:58:47 +00:00
Andrew Wood 04f99c4951 Use a special type for opts->argv[] so that the whole array, and array entries, can both be NULL, and the array entries pointers to constant strings; and ensure that argv[] always has a NULL pointer on the end - all so argv can be passed to execvp() (#67). 2026-03-19 22:57:41 +00:00
Andrew Wood 29c65ad9e1 Set up stdin/stdout for the monitored command (#67). 2026-03-18 22:28:51 +00:00
Andrew Wood f84a668098 Fork for the command to monitor (#67). 2026-03-17 23:41:23 +00:00
Andrew Wood 06721c7be1 Create pipes for monitoring (#67). 2026-03-14 22:34:17 +00:00
Andrew Wood bd70b0c6cb Set exit status for --monitor errors (#67). 2026-03-14 22:33:52 +00:00
Andrew Wood 220625f370 Add TODO markers for the next steps of monitor mode (#67). 2026-03-14 21:50:50 +00:00
Andrew Wood 4606638567 Constrain the options so that -M cannot be used with -U (as it is a different action) and -M will report the right error message if mixed with -R or -Q (#67). 2026-03-14 17:20:30 +00:00
Andrew Wood 882428883a Remember both -N and -F values if two were given (#67). 2026-03-14 14:54:53 +00:00
Andrew Wood c2bbb8eef1 Parse the monitoring side setting from "--monitor" (#67). 2026-03-14 14:28:30 +00:00
Andrew Wood 111b687449 Give "--monitor" a parameter to set which side(s) of the command to monitor (#67). 2026-03-13 23:06:43 +00:00
Andrew Wood 5f1893f094 Draft documentation and option parsing for a "--monitor" option to run a command and monitor its input and output (#67). 2026-03-11 23:37:09 +00:00
Andrew Wood a33ee8ef26 Avoid a comparison of signed and unsigned values. 2026-03-09 20:28:05 +00:00
heitbaum 6d8fbbf848 fix discard const qualifier from pointers
Since glibc-2.43 and ISO C23, the functions bsearch, memchr, strchr, strpbrk, strrchr, strstr, wcschr, wcspbrk, wcsrchr, wcsstr and wmemchr that return pointers into their input arrays now have definitions as macros that return a pointer to a const-qualified type when the input argument is a pointer to a const-qualified type.

Fixes:
../src/pv/display.c: In function 'pv__format_init':
../src/pv/display.c:715:37: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  715 |                      strchr(format_component_array[component_idx].match, (int) ':');
      |                       ^~~~~~
2026-03-09 01:27:04 +01:00
Andrew Wood d28d2f3155 Address the splint warning due to not recognising strlcat(). 2026-03-08 11:23:08 +00:00
Andrew Wood 9566e7d7ea Run through "make indent" for consistency. 2026-03-08 11:21:38 +00:00
Andrew Wood 0a27a85b4a Update the copyright years. 2026-03-07 23:20:20 +00:00
Andrew Wood d186d618e3 Look up the right maxfds value to use with nftw() for the current system (#179). 2026-03-07 23:15:09 +00:00
Andrew Wood e17f64fce7 Allow "--size @dir" to read the size of all files under "dir" (#179). 2026-03-07 22:23:10 +00:00