Commit Graph
236 Commits
Author SHA1 Message Date
Andrew Wood f0aca0a2ce Store the calculated percentage as a double rather than an int, so the granular progress bar is still granular on wide displays. 2024-12-14 17:06:37 +00:00
Andrew Wood 8fa9df6e7a New --bar-style option; replace "default" with "plain" or with a lookup against the selected default, as appropriate. 2024-12-14 00:06:30 +00:00
Andrew Wood 29c7a21725 Increase the size of the progress bar buffer. 2024-12-13 20:55:39 +00:00
Andrew Wood 7a0ee9c7fa Correct the width calculations. 2024-12-13 20:54:11 +00:00
Andrew Wood cb71277df4 Allocate more space for the display buffer, as wide characters take up more room. 2024-12-13 20:38:45 +00:00
Andrew Wood 9f5923864b Inhibit UTF-8 based bar formats when UTF-8 output support is not detected, falling back to the default format instead. 2024-12-13 20:17:01 +00:00
Andrew Wood 60563f3e3c New bar formats - default, block, granular, shaded - with the granular format providing a smoother bar using Unicode block characters (#15) 2024-12-13 20:02:36 +00:00
Andrew Wood c49abf1608 Indentation updates. 2024-12-13 19:57:18 +00:00
Andrew Wood 78f4a60bf7 Change the formatter functions to take their 6 arguments as one struct pointer, making it less messy. 2024-12-12 22:36:07 +00:00
Andrew Wood 1d76c0bc64 Permit decimals with suffix for --size, --rate-limit, --buffer-size, and --error-skip-block (#35); and document the types of numbers allowed in the manual. 2024-12-10 22:09:32 +00:00
Andrew Wood 51a5de71c1 Add a "can_display_utf8" flag based on the current locale, for future use. 2024-12-09 23:23:07 +00:00
Andrew Wood 06eca8cefa Renamed for consistency - pv__ for static functions, and name the array an array. 2024-12-09 21:52:25 +00:00
Andrew Wood c95e25776e Move the formatter functions into separate files so that display.c is less of a monolith; and replace the ctype.h macros with internal versions. 2024-12-09 21:42:16 +00:00
Andrew Wood 35d5b9efab Handle wide characters and ECMA-48 CSI sequences in the format string when calculating string widths. 2024-12-08 21:38:38 +00:00
Andrew Wood f495303177 List all supported format sequences in the output of "--help". 2024-12-08 20:40:05 +00:00
Andrew Wood fb2e6b4074 New "--format" sequences "{progress-bar-only}" and "{progress-amount-only}". 2024-12-08 20:13:33 +00:00
Andrew Wood 4ffdee0002 Introduce the pv_strwidth() function so that in future we can add support for escape sequences and UTF-8 in format strings. 2024-12-08 17:40:12 +00:00
Andrew Wood 5c5d53e1d1 Address two splint-related TODOs. 2024-12-08 17:31:59 +00:00
Andrew Wood 57149c2d03 Add long names to format sequences, such as "%{rate}". 2024-12-08 17:16:02 +00:00
Andrew Wood 838ebcb78f Improve the handling of dangling or invalid "%" sequences. 2024-12-08 16:18:58 +00:00
Andrew Wood 6298a7be9d Refactor the display formatters into their own functions, remove the static arrays for component contents, and start tracking the displayed width of each segment separately from the length in bytes. 2024-12-08 16:04:00 +00:00
Andrew Wood cfea00b200 Use standalone flags to indicate whether we are tracking the last bytes output or the previous line written, so that the component array is not needed outside of display.c. 2024-12-08 10:23:24 +00:00
Andrew Wood 619a84949f New format sequence "%nL" to display the most recently written line (#121). 2024-12-07 23:12:41 +00:00
Andrew Wood c3648af57f Handle the progress bar appearing more than once in the format string. 2024-12-07 20:23:20 +00:00
Andrew Wood 53b5ea54c6 Track the chosen size of format segments so that "%nA" can appear more than once, with different "n" values (#122). 2024-12-07 19:39:44 +00:00
Andrew Wood c4c7b9ec00 Refer to "bytes" rather than "length", so that in future we can differentiate between the number of bytes in a string and how many display columns it occupies. 2024-12-07 17:17:59 +00:00
Andrew Wood b84432ec7f Change buffer pointer type to "char *" to avoid doing pointer arithmetic on "void *". 2024-12-06 22:46:28 +00:00
Andrew Wood 111b514a05 Replace non-standard \e with \033. 2024-12-06 19:39:57 +00:00
Andrew Wood ebb209a371 Add support for --extra-display to --remote (#123). 2024-12-03 23:48:44 +00:00
Andrew Wood d51c57379a When cross-compiling, we cannot run a test program to check whether a siginfo_t provides the signal sender PID, so we fall back to assuming that it does, and also check that SA_SIGINFO is declared so compilation will not fail on systems without it (#120). 2024-12-03 21:04:58 +00:00
Andrew Wood 503a559b2a Move "--extra-display" and "--stats" to the "Output modifiers" section, since they are not really display switches that directly affect the terminal progress display. 2024-12-02 17:36:16 +00:00
Andrew Wood d7d87fed76 Restructure and reformat the manual to be more in line with man-pages(7), with some small wording changes; move -8 and -k to the modifiers section rather than display switches; adjust "--help" output to report the options in the same order the manual lists them. 2024-12-02 00:02:18 +00:00
Andrew Wood f3774b5987 Indentation update. 2024-12-01 19:40:33 +00:00
Andrew Wood dccc7345ab New option "--extra-display" (#3, #4). 2024-12-01 19:39:59 +00:00
Andrew Wood 0d7c9ac091 Address splint warnings. 2024-12-01 16:05:17 +00:00
Andrew Wood aee34fce32 Address splint warnings when debugging is turned off. 2024-12-01 15:55:48 +00:00
Andrew Wood c29d306d10 Additional configure.ac cleanups. 2024-12-01 15:42:59 +00:00
Andrew Wood 106a673ba8 Test at compile time whether siginfo_t is usable for --remote (#119). 2024-12-01 15:26:59 +00:00
Andrew Wood 68c8046a55 Record the sending PID before setting the flag saying we received a signal. 2024-12-01 01:27:48 +00:00
Andrew Wood c3fae61dda Include the control filename in the error message when a SIGUSR2 is received and the control file cannot be opened. 2024-12-01 01:10:47 +00:00
Andrew Wood a9d4bf4a25 Fix bug with "--watchfd" not reporting file positions (#118). 2024-11-30 17:25:12 +00:00
Andrew Wood 0d618efd0d Remove pointless EOF lines from all sources. 2024-11-30 16:40:50 +00:00
Andrew Wood b4438bbdfb Explain exactly what pv__write_pidfile is intended to do, in its header comment. As per reviewer suggestions, replace the unexplained constant buffer size padding with a static template string and an extra strlen(), and explain why the flawfinder check is being bypassed. 2024-10-20 13:40:37 +01:00
Andrew Wood a1e2651b4c Remove the tcsetpgrp() code, as it did not work, since it turns out that zsh 5.8 was setting the terminal process group ID to that of itself when the last command in the pipeline was not a subshell - not to an invalid pgid or anything like that - so we cannot safely detect this or work around it. 2024-10-11 19:48:56 +01:00
Andrew Wood ec498ec476 Added a possible workaround, and extra debugging, for the missing display output issue in #100, but turned off at the moment. 2024-10-09 22:07:56 +01:00
Andrew Wood 579b592c12 Correct the wording of the line buffer allocation failure error message. 2024-10-09 18:55:33 +01:00
Andrew Wood 856da09741 Add a circular buffer of line positions so that in line mode we can work out how many lines are in the unconsumed portion of the output pipe buffer. 2024-10-05 23:04:18 +01:00
Andrew Wood bfe301ae1c Preserve errno after the output write, and if the output pipe is closed, propagate this to the main loop so it does not wait forever for the pipe buffer to empty. 2024-10-05 17:05:14 +01:00
Andrew Wood d9a0041870 New --store-and-forward option (#100), including refactoring several areas to allow PV to run in two passes, and the ability to look at the output pipe buffer utilisation to more accurately reflect the total data transferred to the receiving end, rather than just the total amount written to the output buffer. 2024-10-05 16:21:59 +01:00
Andrew Wood ea3787e393 Call posix_fadvise() each time we open a new file, not just on the first one. 2024-10-05 15:00:08 +01:00