mirrors/remark42
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix flapping notify drops test, clarify debug logs

Browse Source
This commit is contained in:
Dmitry Verkhoturov
2021-03-28 14:06:58 -05:00
committed by Umputun
parent aa14069f8b
commit 8a3f434bc1
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/app/notify/notify_mock.go
+2 -2
View File
@@ -40,9 +40,9 @@ func (m *MockDest) SendVerification(ctx context.Context, v VerificationRequest)
select {
case <-time.After(10 * time.Millisecond):
m.verificationData = append(m.verificationData, v)
log.Printf("sent %s -> %d", v.User, m.id)
log.Printf("sent verification %s -> %d", v.User, m.id)
case <-ctx.Done():
log.Printf("ctx closed %d", m.id)
log.Printf("verification ctx closed %d", m.id)
m.closed = true
}
return nil
backend/app/notify/notify_test.go
+2 -2
View File
@@ -54,7 +54,7 @@ func TestService_WithDrops(t *testing.T) {
s.Submit(Request{Comment: store.Comment{ID: "101"}})
time.Sleep(time.Millisecond * 11)
s.Submit(Request{Comment: store.Comment{ID: "102"}})
time.Sleep(time.Millisecond * 11)
time.Sleep(time.Millisecond * 21)
s.Close()
s.Submit(Request{Comment: store.Comment{ID: "111"}}) // safe to send after close
@@ -77,7 +77,7 @@ func TestService_SubmitVerificationWithDrops(t *testing.T) {
s.SubmitVerification(VerificationRequest{})
time.Sleep(time.Millisecond * 11)
s.SubmitVerification(VerificationRequest{})
time.Sleep(time.Millisecond * 11)
time.Sleep(time.Millisecond * 21)
s.Close()
s.SubmitVerification(VerificationRequest{}) // safe to send after close