up node version, add nvmrc, recommend nvm

This commit is contained in:
Paul Mineev
2022-07-02 11:48:22 -05:00
committed by Umputun
parent 24e9404a6f
commit 99716984ad
6 changed files with 12 additions and 11 deletions
+4 -4
View File
@@ -19,7 +19,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [16.13.2]
node: [16.15.1]
steps:
- uses: actions/checkout@v2
@@ -44,7 +44,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [16.13.2]
node: [16.15.1]
steps:
- uses: actions/checkout@v2
@@ -69,7 +69,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [16.13.2]
node: [16.15.1]
steps:
- uses: actions/checkout@v2
@@ -87,7 +87,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [16.13.2]
node: [16.15.1]
steps:
- uses: actions/checkout@v2
+2 -2
View File
@@ -33,7 +33,7 @@ RUN \
echo "version=$version" && \
go build -o remark42 -ldflags "-X main.revision=${version} -s -w" ./app
FROM --platform=$BUILDPLATFORM node:16.13.2-alpine as build-frontend-deps
FROM --platform=$BUILDPLATFORM node:16.15.1-alpine as build-frontend-deps
ARG CI
ARG SKIP_FRONTEND_BUILD
@@ -52,7 +52,7 @@ RUN if [ -z "$SKIP_FRONTEND_BUILD" ] ; then \
echo "skip frontend build" \
; fi
FROM --platform=$BUILDPLATFORM node:16.13.2-alpine as build-frontend
FROM --platform=$BUILDPLATFORM node:16.15.1-alpine as build-frontend
ARG CI
ARG SKIP_FRONTEND_TEST
+2 -2
View File
@@ -1,4 +1,4 @@
FROM node:12.16-alpine as build-frontend-deps
FROM node:16.15.1-alpine as build-frontend-deps
ARG CI
@@ -9,7 +9,7 @@ ADD frontend/package.json /srv/frontend/package.json
ADD frontend/package-lock.json /srv/frontend/package-lock.json
RUN cd /srv/frontend && CI=true npm ci
FROM node:12.16-alpine as build-frontend
FROM node:16.15.1-alpine as build-frontend
ARG CI
ARG NODE_ENV=production
+1
View File
@@ -0,0 +1 @@
16.15.1
+1 -1
View File
@@ -22,7 +22,7 @@
"translation:check": "node ./tasks/checkTranslation.js"
},
"engines": {
"node": ">=16.13.0 <=17.*",
"node": ">=16.15 <=17.*",
"npm": ">=8.1.0 <=8.*"
},
"dependencies": {
@@ -8,8 +8,8 @@ title: Frontend Development Guidelines
You must have at least 2GB RAM or swap enabled for building.
- install [Node.js 16.13.0](https://nodejs.org/en/) or higher
- install [NPM 8.1.0](https://www.npmjs.com/package/npm)
- install [Node.js 16.15](https://nodejs.org/en/) or higher (we recommend using [NVM](https://github.com/nvm-sh/nvm) for node version autoswitch)
- install [NPM 8.1](https://www.npmjs.com/package/npm)
- run `npm install` inside `./frontend`
Running `npm install` will set up pre-commit hooks into your git repository. They are used to reformat your frontend code using `prettier` and lint with `eslint` and `stylelint` before every commit.