mirrors/remark42
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

increase ttl block in tests to reduce flakiness (#121)

Browse Source
This commit is contained in:
Aleksei Gurianov
2018-07-01 10:58:34 -05:00
committed by Umputun
parent df9d92cd21
commit e753346255
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/app/rest/api/admin_test.go
+2 -2
View File
@@ -244,7 +244,7 @@ func TestAdmin_BlockedList(t *testing.T) {
// block user2
req, err = http.NewRequest(http.MethodPut,
fmt.Sprintf("%s/api/v1/admin/user/%s?site=radio-t&block=%d&ttl=10ms", ts.URL, "user2", 1), nil)
fmt.Sprintf("%s/api/v1/admin/user/%s?site=radio-t&block=%d&ttl=50ms", ts.URL, "user2", 1), nil)
assert.Nil(t, err)
req.SetBasicAuth("dev", "password")
_, err = client.Do(req)
@@ -259,7 +259,7 @@ func TestAdmin_BlockedList(t *testing.T) {
assert.Equal(t, "user1", users[0].ID)
assert.Equal(t, "user2", users[1].ID)
time.Sleep(11 * time.Millisecond)
time.Sleep(50 * time.Millisecond)
res, code = getWithAuth(t, ts.URL+"/api/v1/admin/blocked?site=radio-t")
require.Equal(t, 200, code, res)
users = []store.BlockedUser{}
backend/app/store/engine/bolt_admin_test.go
+4 -4
View File
@@ -145,9 +145,9 @@ func TestBoltAdmin_BlockUserWithTTL(t *testing.T) {
defer os.Remove(testDb)
b := prep(t)
assert.False(t, b.IsBlocked("radio-t", "user1"), "nothing blocked")
assert.NoError(t, b.SetBlock("radio-t", "user1", true, 10*time.Millisecond))
assert.NoError(t, b.SetBlock("radio-t", "user1", true, 50*time.Millisecond))
assert.True(t, b.IsBlocked("radio-t", "user1"), "user1 blocked")
time.Sleep(11 * time.Millisecond)
time.Sleep(50 * time.Millisecond)
assert.False(t, b.IsBlocked("radio-t", "user1"), "user1 un-blocked automatically")
}
@@ -156,7 +156,7 @@ func TestBoltAdmin_BlockList(t *testing.T) {
b := prep(t)
assert.NoError(t, b.SetBlock("radio-t", "user1", true, 0))
assert.NoError(t, b.SetBlock("radio-t", "user2", true, 10*time.Millisecond))
assert.NoError(t, b.SetBlock("radio-t", "user2", true, 50*time.Millisecond))
assert.NoError(t, b.SetBlock("radio-t", "user3", false, 0))
ids, err := b.Blocked("radio-t")
@@ -167,7 +167,7 @@ func TestBoltAdmin_BlockList(t *testing.T) {
assert.Equal(t, "user2", ids[1].ID)
t.Logf("%+v", ids)
time.Sleep(11 * time.Millisecond)
time.Sleep(50 * time.Millisecond)
ids, err = b.Blocked("radio-t")
assert.NoError(t, err)
assert.Equal(t, 1, len(ids))