Dmitry Verkhoturov
d534247c5a
The bundler used to bake a fixed public path into every entry, so an instance mounted under a prefix, which manuals/subdomain documents, asked the domain root for its provider icons and got nothing. #2197 derived the path from the URL the bundle was loaded from instead, and covered it with nothing: publicPath appears only in webpack.config.js and neither suite touched asset paths. The check is on the assignment webpack emits for its runtime public path, a string literal when the path is fixed and an expression when it is derived. Asset filenames are bare in both builds, so the obvious assertion, looking for a rooted "/web/name.svg" string, finds nothing either way and proves nothing. I wrote that one first and it passed against a deliberately broken build. Every emitted bundle is checked rather than the entry the bug was reported against: it put fifteen icons in remark.mjs and one in last-comments.mjs, so a case reading a single entry would have gone green with half of it still live. Verified by rebuilding the frontend with the public path baked back in: the assertion fails on that build and passes on master's.
Remark42 
Remark42 is a self-hosted, lightweight and simple (yet functional) comment engine, which doesn't spy on users. It can be embedded into blogs, articles, or any other place where readers add comments.
- Social login via Google, Facebook, Microsoft, GitHub, Apple, Yandex, Patreon, Discord, Telegram and custom OAuth2 providers
- Login via email
- Optional anonymous access
- Multi-level nested comments with both tree and plain presentations
- Import from Disqus and WordPress
- Markdown support with friendly formatter toolbar
- Moderator can remove comments and block users
- Voting, pinning and verification system
- Sortable comments
- Images upload with drag-and-drop
- Extractor for recent comments, cross-post
- RSS for all comments and each post
- Telegram, Slack, Webhook and email notifications for Admins (get notified for each new comment)
- Email and Telegram notifications for users (get notified when someone responds to your comment)
- Export data to JSON with automatic backups
- No external databases, everything embedded in a single data file
- Fully dockerized and can be deployed in a single command
- Self-contained executable can be deployed directly to Linux, Windows and macOS
- Clean, lightweight and customizable UI with white and dark themes
- Multi-site mode from a single instance
- Integration with automatic SSL (direct and via nginx-le)
- Privacy focused
Demo site available with all authentication methods, including email auth and anonymous access.
All remark42 documentation is available by the link.
Contribution
In order to start and work on the project locally in development mode check our contribution documentation for backend and frontend.
If you are interested in adding a new localization please check these docs.